HI Reshad,
I've uploaded version -21, which includes the changes we discussed.
Thanks,
Yingzhen
On Mon, Jan 22, 2024 at 11:52 AM Reshad Rahman wrote:
> Thanks Yingzhen. Yes I am good with that.
>
> Regards,
> Reshad.
>
> On Monday, January 22, 2024, 02:39:17 PM EST, Yingzhen Qu <
>
Thanks Yingzhen. Yes I am good with that.
Regards,Reshad.
On Monday, January 22, 2024, 02:39:17 PM EST, Yingzhen Qu
wrote:
Hi Reshad,
Thanks for the review.
The "sid-binding-tlv" and "mt-sid-binding-tlv" are relatively big with more
content, so I thought it might be easier to read
Hi Reshad,
Thanks for the review.
The "sid-binding-tlv" and "mt-sid-binding-tlv" are relatively big with more
content, so I thought it might be easier to read with a container. But
you're right, it's not following the YANG traditions, how about the
following?
container sid-binding-tlvs {
Hi,
Typically we have a container (plural) including a list (singular). In -20 it
was done the other way round. Since this is read-only, IIRC we don't need the
container including a list as we do for read-write. Is the container there for
convenience?
Regards,Reshad.
augment
Hi Yingzhen,
Please see inline.
On Thursday, January 18, 2024, 04:49:28 PM EST, Yingzhen Qu
wrote:
HI Reshad,
Thanks for the review. I've uploaded version -20 to address your comments.
Details below inline.
Thanks,Yingzhen
On Sat, Jan 13, 2024 at 4:24 PM Reshad Rahman via Datatracker
HI Reshad,
Thanks for the review. I've uploaded version -20 to address your comments.
Details below inline.
Thanks,
Yingzhen
On Sat, Jan 13, 2024 at 4:24 PM Reshad Rahman via Datatracker <
nore...@ietf.org> wrote:
> Reviewer: Reshad Rahman
> Review result: Ready with Issues
>
> Hi all,
>
>
Reviewer: Reshad Rahman
Review result: Ready with Issues
Hi all,
This is my YANG Doctor review of -19. Thanks to the authors for making the
effort to align with draft-ietf-ospf-yang (as previously requested).
Comments
Section 3 (YANG Tree)
- There are a few instances of
