Re: [Lsr] Yangdoctors last call review of draft-ietf-lsr-ospfv3-extended-lsa-yang-14

2023-06-28 Thread Acee Lindem
Thanks for the review Renato - I’ve incorporated both your comments into the latest revision. Thanks, Acee > On Jun 28, 2023, at 09:23, Renato Westphal wrote: > > Hi all, > > I think the updated module is looking pretty good. I just have one small > piece of feedback to share. > > According

Re: [Lsr] Yangdoctors last call review of draft-ietf-lsr-ospfv3-extended-lsa-yang-14

2023-06-28 Thread Renato Westphal
Hi all, I think the updated module is looking pretty good. I just have one small piece of feedback to share. According to RFC 8362 Section 3.3, the Attached-Routers TLV doesn't support Sub-TLVs. Therefore, I believe it's necessary to remove the "sub-tlvs" list from the "attached-router-tlv" conta

Re: [Lsr] Yangdoctors last call review of draft-ietf-lsr-ospfv3-extended-lsa-yang-14

2023-06-27 Thread Mahesh Jethanandani
Acee/Yingzhen, Thanks for addressing my comments. > On Jun 27, 2023, at 1:23 PM, Yingzhen Qu wrote: > > Hi Mahesh, > > We just uploaded version -17 and added a configuration example. Please let us > know if you have any other comments. > > Thanks, > Yingzhen > > On Mon, Jun 26, 2023 at 1:4

Re: [Lsr] Yangdoctors last call review of draft-ietf-lsr-ospfv3-extended-lsa-yang-14

2023-06-27 Thread Yingzhen Qu
Hi Mahesh, We just uploaded version -17 and added a configuration example. Please let us know if you have any other comments. Thanks, Yingzhen On Mon, Jun 26, 2023 at 1:44 PM Acee Lindem wrote: > Hi Mahesh, > > Thanks for the review - a lot of good comments. See inline and -16 > version. > > >

Re: [Lsr] Yangdoctors last call review of draft-ietf-lsr-ospfv3-extended-lsa-yang-14

2023-06-26 Thread Acee Lindem
Hi Mahesh, Thanks for the review - a lot of good comments. See inline and -16 version. > On Jun 15, 2023, at 5:18 PM, Mahesh Jethanandani via Datatracker > wrote: > > Reviewer: Mahesh Jethanandani > Review result: On the Right Track > > Document reviewed: draft-ietf-lsr-ospfv3-extended-lsa

[Lsr] Yangdoctors last call review of draft-ietf-lsr-ospfv3-extended-lsa-yang-14

2023-06-15 Thread Mahesh Jethanandani via Datatracker
Reviewer: Mahesh Jethanandani Review result: On the Right Track Document reviewed: draft-ietf-lsr-ospfv3-extended-lsa-yang Status: On the right track I have marked it as On the Right Track, because of some of the points discussed below. Summary: This document defines a YANG data model augmenti