Re: [Lsr] Adam Roach's No Objection on draft-ietf-isis-yang-isis-cfg-40: (with COMMENT)

2019-10-07 Thread Acee Lindem (acee)
Hi Adam, 

Thanks for review. 

On 10/2/19, 6:31 PM, "Adam Roach via Datatracker"  wrote:

Adam Roach has entered the following ballot position for
draft-ietf-isis-yang-isis-cfg-40: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-isis-yang-isis-cfg/



--
COMMENT:
--


Thanks for the work that went into this model. I have only a handful
of minor issues I found when reading through the module.

---

>grouping spf-parameters {
>  container spf-control {
>  leaf paths {
>if-feature max-ecmp;
>type uint16 {
>  range "1..32";
>}

Why is this a uint16 rather than a uint8?

It definitely could be uint8. 

---

>  leaf-list tag {
>type uint32;
>description
>  "List of 32-bit tags associated with the IPv4 prefix.";
>  }
>  leaf-list tag64 {
>type uint64;
>description
>  "List of 32-bit tags associated with the IPv4 prefix.";
>  }

I think this second description is meant to say "64-bit" rather than 
"32-bit".

Fixed and will be in the -41 version. 

---

>  leaf reason {
>type string {
>  length "1..255";
>}
>description
>  "The system may provide a reason to reject the
>   adjacency. If the reason is not available,
>   an empty string will be returned.
>   The expected format is a single line text.";
>  }

This description is inconsistent with the definition: it calls for an empty
string, while the definition requires that at lest one character be 
present. If
you want to keep the description as-is, you need to adjust the length to be
"0..255". Alternately, you might indicate that the field is simply to be
omitted rather than empty, which appears to be the intention for other
"reason" fields in this model.

Actually, I think the intension was to return a string consisting solely of the 
EOL character ('\0'). However, I think not returning a string is a better 
alternative. 

Thanks
Acee




___
Lsr mailing list
Lsr@ietf.org
https://www.ietf.org/mailman/listinfo/lsr


[Lsr] Subject: RtgDir review: draft-ietf-ospf-ospfv2-hbit-09.txt

2019-10-07 Thread Hejia (Jia)
Hello,

I have been selected as the Routing Directorate reviewer for this draft. The

Routing Directorate seeks to review all routing or routing-related drafts as

they pass through IETF last call and IESG review, and sometimes on special

request. The purpose of the review is to provide assistance to the Routing ADs.

For more information about the Routing Directorate, please see

http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would

be helpful if you could consider them along with any other IETF Last Call

comments that you receive, and strive to resolve them through discussion or by

updating the draft.

Document: draft-ietf-ospf-ospfv2-hbit-09.txt
Reviewer: Jia He
Review Date: 07 October 2019
IETF LC End Date: date-if-known
Intended Status: Standards Track

Summary:


This document is basically ready for publication, but has nits that should be

considered prior to publication.


Comments:

The draft is short and the problem to be solved is clear, however, some nits

could be fixed to improve the readability.

Major Issues:
None

Minor Issues:
1) The current version updates RFC6987 only. However, there are modifications to

RFC2328 as described in the draft. Any thought of adding RFC2328 in the update?


Nits:

1) There are several forms of h-bit throughout the document, e.g. Host-Bit (H-

bit),H-Bit, Host Bit It is better that they are aligned.

2) Introduction,

   This document describes the Host-bit (H-Bit)functionality that
   prevents other OSPFv2 routers from using the router for transit
   traffic in OSPFv2 routing domains.

The difference between "other OSPFv2 routers" and "the router" is not clearly

described. How about replacing "the router" with "the host router" or "the

router with H-bit set"?

3) Section 3,
   If the host-bit is NOT set routers MUST act transit routers as
   described in [RFC2328] ensuring backward compatibility.

s/act transit routers/act as transit routers

4) Section 4,

   If this is a router-LSA, and the H-bit
   of the router-LSA is set, and
   vertex V is not the root, then the
   router should not be used for transit

s/used for transit/used for transit traffic


5) Section 5,

   To avoid the possibility of any routing loops due to partial
   deployment, this document defines a OSPF Router Information (RI) LSA
   [RFC7770] with and an area flooding scope and a new bit assigned in
   the OSPF Router Informational Capability Bits Registry.

s/with and/within


6) Section 5,
"  Auto Discovery via announcement of the Host Support Functional
   Capability",

To get aligned with the naming in the OSPF Router Informational Capability Bits

Registry, s/Host Support Functional Capability/Host Router Support capability

7) Section 5,

   For example, in a new router
   joins an area which previous had only H-bit capable routers with
   H-bit set then it may take some time for the RI to propagate to all
   routers.

s/in a new router joins an area which previous had only H-bit capable routers

with H-bit set /when a new router joins an area which previously had only H-bit

capable routers with H-bit set

8) Section 5,

  All routers, with the H-bit set, MUST advertise all of the
  router's non-local links with a metric equal to MaxLinkMetric in
  its LSAs in order to avoid OSPFv2 (unless last resort) routers not
  supporting the H-bit from attempting to use it for transit
  traffic.

s/avoid/prevent


B.R.
Jia


___
Lsr mailing list
Lsr@ietf.org
https://www.ietf.org/mailman/listinfo/lsr