Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-20 Thread bruno . decraene
; > > > > Cc: draft-ietf-lsr-isis-fast-flooding@ietf.org; > > > last-c...@ietf.org; lsr@ietf.org; sec...@ietf.org > > > Subject: RE: Secdir last call review of > > > draft-ietf-lsr-isis-fast-flooding-07 > > > > > >

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread Barry Leiba
rg; > > sec...@ietf.org > > Subject: RE: Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07 > > > > Les, Barry, > > > > > From: Les Ginsberg (ginsberg) > > > Sent: Friday, March 15, 2024 4:29 PM > > > > > > Bruno/Barry - &g

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread Les Ginsberg (ginsberg)
.@ietf.org > Subject: RE: Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07 > > Les, Barry, > > > From: Les Ginsberg (ginsberg) > > Sent: Friday, March 15, 2024 4:29 PM > > > > Bruno/Barry - > > > > In regards to: > > > >

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread bruno . decraene
Les, Barry, > From: Les Ginsberg (ginsberg) > Sent: Friday, March 15, 2024 4:29 PM > > Bruno/Barry - > > In regards to: > > > > — Section 4.4 — > > > > >> Length: Indicates the length in octets (1-8) of the Value field. The > >> length SHOULD be the minimum required to send all

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread Les Ginsberg (ginsberg)
Bruno/Barry - In regards to: > > — Section 4.4 — > > >> Length: Indicates the length in octets (1-8) of the Value field. The >> length SHOULD be the minimum required to send all bits that are set. > > > > The SHOULD seems very odd: what would be a good reason to make it > longer than

Re: [Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-15 Thread bruno . decraene
...@ietf.org; > lsr@ietf.org > Subject: Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07 > > Reviewer: Barry Leiba > Review result: Has Issues > > Only some minor things here: > > — Section 3 — > > Although modern implementations have not strictl

[Lsr] Secdir last call review of draft-ietf-lsr-isis-fast-flooding-07

2024-03-13 Thread Barry Leiba via Datatracker
Reviewer: Barry Leiba Review result: Has Issues Only some minor things here: — Section 3 — Although modern implementations have not strictly adhered to the 33 millisecond interval, it is commonplace for implementations to limit the flooding rate to the same order of magnitude similar