Re: [LTP] [PATCH V2 2/2] syscalls/getgroups: added checks for 16-bit getgroups() syscall

2013-08-28 Thread Stanislav Kholmanskikh
On 08/27/2013 04:16 PM, chru...@suse.cz wrote: Hi! Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testcases/kernel/syscalls/getgroups/compat_16.h | 78 + testcases/kernel/syscalls/getgroups/getgroups01.c | 22 +++---

Re: [LTP] [PATCH 2/2 v2] quotactl/quotactl02.c: create a case to test basic flags of quotactl(2)

2013-08-28 Thread chrubis
Hi! You don't need to have function to statically initialize a structure, I would just initialized it statically and passed right pointer to the testcase addr. I am afraid I don't catch your meaning. This function setup_setqlim set up the structure dquota for the setqlim test, and

Re: [LTP] [PATCH V2 2/2] syscalls/getgroups: added checks for 16-bit getgroups() syscall

2013-08-28 Thread chrubis
Hi! Ok. I'm managing this (compat_16.h from several testcases, compat_uid.h, compat_gid.h). But I need one more clarification. Look at LTP/testcases/kernel/include. There are linux_syscalls_numbers.h and numa_helper.h Maybe move all these compat headers not into LTP/include/sys, but

Re: [LTP] [PATCH 2/2 v2] quotactl/quotactl02.c: create a case to test basic flags of quotactl(2)

2013-08-28 Thread DAN LI
On 08/28/2013 05:38 PM, chru...@suse.cz wrote: Hi! You don't need to have function to statically initialize a structure, I would just initialized it statically and passed right pointer to the testcase addr. I am afraid I don't catch your meaning. This function setup_setqlim set up the

Re: [LTP] RFC add _FORTIFY_SOURCE to default LTP CFLAGS

2013-08-28 Thread chrubis
Hi! unfortunately that does not work. this snippet from coreutils is probably better: AH_VERBATIM([FORTIFY_SOURCE], [/* Enable compile-time and run-time bounds-checking, and some warnings, without upsetting glibc 2.15+. */ #if !defined _FORTIFY_SOURCE defined __OPTIMIZE__

[LTP] LTP release?

2013-08-28 Thread chrubis
Hi! I think it's about the time we do another release, do you have time to work on that or should we take over? -- Cyril Hrubis chru...@suse.cz -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!

[LTP] [PATCH] ltp: Fix races in mmap1

2013-08-28 Thread Dave Kleikamp
Make map_address a volatile pointer so that it is dereferenced in read_mem() after read_lock is set. Also read_lock must protect the verbose printf that reads from map_address as well. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com diff --git a/testcases/kernel/mem/mtest06/mmap1.c

Re: [LTP] [PATCH V4] syscalls/migrate_pages: fix nodemask_memory_allocation

2013-08-28 Thread chrubis
Hi! Changes since V3: * Macros ALIGN, __ALIGN_MASK renamed to LTP_ALIGN, __LTP_ALIGN_MASK * Both macros are placed in compiler.h (instead of test.h) Pushed, thanks. -- Cyril Hrubis chru...@suse.cz -- Learn the

Re: [LTP] [PATCH] ltp: Fix races in mmap1

2013-08-28 Thread Stanislav Kholmanskikh
On 08/28/2013 05:07 PM, Dave Kleikamp wrote: Make map_address a volatile pointer so that it is dereferenced in read_mem() after read_lock is set. Also read_lock must protect the verbose printf that reads from map_address as well. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com diff

Re: [LTP] [PATCH] ltp: Fix races in mmap1

2013-08-28 Thread chrubis
Hi! static int verbose_print = 0; -static char *map_address; +static char *volatile map_address; Ok. static jmp_buf jmpbuf; static volatile char read_lock = 0; @@ -228,11 +228,13 @@ void *read_mem(void *ptr) tst_resm(TINFO, page fault occurred due to

Re: [LTP] LTP release?

2013-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2013 at 3:03 PM, chru...@suse.cz wrote: Hi! I think it's about the time we do another release, do you have time to work on that or should we take over? When I saw Mike's mega-merge into master I assumed there will be a new release. Don't forget the XZ-tarball :-). - Sedat -

Re: [LTP] LTP release?

2013-08-28 Thread chrubis
Hi! I think it's about the time we do another release, do you have time to work on that or should we take over? When I saw Mike's mega-merge into master I assumed there will be a new release. I guess that it's not documented anywhere but the current system is time based. We have four

Re: [LTP] RFC add _FORTIFY_SOURCE to default LTP CFLAGS

2013-08-28 Thread Mike Frysinger
On Wednesday 28 August 2013 07:56:01 chru...@suse.cz wrote: unfortunately that does not work. this snippet from coreutils is probably better: AH_VERBATIM([FORTIFY_SOURCE], [/* Enable compile-time and run-time bounds-checking, and some warnings, without upsetting glibc

Re: [LTP] RFC add _FORTIFY_SOURCE to default LTP CFLAGS

2013-08-28 Thread Mike Frysinger
On Wednesday 28 August 2013 12:34:40 Mike Frysinger wrote: On Wednesday 28 August 2013 07:56:01 chru...@suse.cz wrote: unfortunately that does not work. this snippet from coreutils is probably better: AH_VERBATIM([FORTIFY_SOURCE], [/* Enable compile-time and run-time

[LTP] Wanna execute the ltp and the openposix test suite together by one command

2013-08-28 Thread DAN LI
Hi guys, I want to implement that running the ltp test suite and the openposix test suite together by one command, as currently, they are performed separately. To make it, i get two ways, A. 1. Run configure with option --with-open-posix-testsuite, then the openposix test suite can be

[LTP] [PATCH 2/2 v3] quotactl/quotactl02.c: create a case to test basic flags of quotactl(2)

2013-08-28 Thread DAN LI
Test basic xqm-related flags of quotactl() syscall. Signed-off-by: DAN LI li@cn.fujitsu.com --- runtest/syscalls| 1 + testcases/kernel/syscalls/.gitignore| 1 + testcases/kernel/syscalls/quotactl/quotactl02.c | 250 3