[LTP] broken install in kernel/firmware (possibly all device-drivers)

2013-09-19 Thread Jan Stancek
Hi, we ignore build failures in kernel/firmware, so this doesn't stop build phase. But when build fails (for whatever reason) then it always breaks install phase: make[3]: Entering directory `/root/ltp/testcases/kernel/firmware' make[4]: Entering directory

Re: [LTP] broken install in kernel/firmware (possibly all device-drivers)

2013-09-19 Thread chrubis
Hi! we ignore build failures in kernel/firmware, so this doesn't stop build phase. But when build fails (for whatever reason) then it always breaks install phase: make[3]: Entering directory `/root/ltp/testcases/kernel/firmware' make[4]: Entering directory

Re: [LTP] [PATCH v2] mk/module.mk: add Makefile to build kernel modules

2013-09-19 Thread chrubis
Hi! Makefile example: top_srcdir ?= ../../../.. Why aren't you including env_pre.mk here? It contains mostly compatibility hack for older Make. Does it break something? REQ_VERSION_MAJOR := 2 REQ_VERSION_PATCH := 6 MODULE_NAMES:= Module01 Module02 ...

Re: [LTP] [PATCH v2] mk/module.mk: add Makefile to build kernel modules

2013-09-19 Thread alexey . kodanev
Hi! On 09/19/2013 03:59 PM, chru...@suse.cz wrote: Hi! Makefile example: top_srcdir ?= ../../../.. Why aren't you including env_pre.mk here? It contains mostly compatibility hack for older Make. Does it break something? Yes, I would include it only inside ifeq($(KERNELRELEASE),)

Re: [LTP] Policy regarding BASH

2013-09-19 Thread Stanislav Kholmanskikh
On 09/19/2013 04:47 PM, Stanislav Kholmanskikh wrote: Hi! During looking into shell testcases I came across a situation where * main shell script is a bash script (ie it has #!/bin/bash in the header) * for each testcase number main shell script executes a separate (child) shell-script

Re: [LTP] Policy regarding BASH

2013-09-19 Thread chrubis
Hi! So what is the policy regarding bash presence in LTP? Is it permitted to write testcases using bash specific features? Or are we strongly encouraged to use common shell only? Just fix the tests to work with common shell and send a patch. -- Cyril Hrubis chru...@suse.cz

Re: [LTP] [PATCH v2] mk/module.mk: add Makefile to build kernel modules

2013-09-19 Thread chrubis
Hi! Makefile example: top_srcdir ?= ../../../.. Why aren't you including env_pre.mk here? It contains mostly compatibility hack for older Make. Does it break something? Yes, I would include it only inside ifeq($(KERNELRELEASE),) otherwise make stops in the kernel tree

Re: [LTP] [PATCH v2] mk/module.mk: add Makefile to build kernel modules

2013-09-19 Thread Alexey Kodanev
On 19.09.2013 18:45, chru...@suse.cz wrote: Hi! Makefile example: top_srcdir ?= ../../../.. Why aren't you including env_pre.mk here? It contains mostly compatibility hack for older Make. Does it break something? Yes, I would include it only inside ifeq($(KERNELRELEASE),)