Re: [LTP] [PATCH] lib, tools, pan: old-style function definition fixes

2014-04-23 Thread Stanislav Kholmanskikh
On 04/14/2014 09:13 PM, chru...@suse.cz wrote: > Hi! Hi! >> No functional changes. No "cleanup". Just fixes for >> "old-style function definition" compile warnings. > > This is obviously OK, but needs to wait after we do release as it's > non-critical change. > Thank you. Pushed. --

[LTP] [PATCH] fs/ext4-new-features: cleanup

2014-04-23 Thread Xiaoguang Wang
Using the tst_* interface provided by shell library test.sh and do some bashism fixes. Update README. Signed-off-by: Xiaoguang Wang --- testcases/kernel/fs/ext4-new-features/README | 34 ++ .../ext4-delalloc-mballoc/ext4-alloc-test.sh | 47 + .../ext4-inode-versi

Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

2014-04-23 Thread chrubis
Hi! > I've thought about this. The problem is that these tools is only one way > of doing it. Performing CPU isolation in Linux is still something of a > black art, so my idea was to show one way that we have got it working > for at least some boards. Since how to do this is also dependent on > arc

Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

2014-04-23 Thread Mats Liljegren
On Tue, 22 Apr 2014 17:47:11 +0200 wrote: > Hi! > > +top_srcdir ?= ../../../.. > > + > > +include $(top_srcdir)/include/mk/testcases.mk > > + > > +CFLAGS += -D_GNU_SOURCE -Werror > > We usually define _GNU_SOURCE on the top of the C source and please > remove the -Wer

Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

2014-04-23 Thread Mats Liljegren
On Wed, 23 Apr 2014 12:24:36 +0200 wrote: > Hi! > > I've thought about this. The problem is that these tools is only > > one way of doing it. Performing CPU isolation in Linux is still > > something of a black art, so my idea was to show one way that we > > have got it working for at least some b

Re: [LTP] [PATCH v2 2/2] sbrk/sbrk02.c: add ENOMEM errno test

2014-04-23 Thread Jan Stancek
- Original Message - > From: "Zeng Linggang" > To: "Jan Stancek" > Cc: "ltp-list" > Sent: Wednesday, 23 April, 2014 5:52:56 AM > Subject: [PATCH v2 2/2] sbrk/sbrk02.c: add ENOMEM errno test > > Add ENOMEM errno test for sbrk(2) > > Signed-off-by: Zeng Linggang > --- > runtest/ltpli

Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

2014-04-23 Thread chrubis
Hi! > As for -Werror, I can remove it, but not without shedding some tears... > This was my way of assuring that no one who contributed to my code will > be able to slip in warnings unnoticed. To turn things around: The > -Werror is a way of saying "Now this code has once compiled without > warning

[LTP] [ANNOUNCE] The Linux Test Project has been released for APRIL 2014

2014-04-23 Thread chrubis
Good news everyone, The Linux Test Project test suite stable release for *April 2014* has been released. Since the last release 210 patches by 27 authors were merged. Notable changes are: * Continued effort to cleanup old testcases (about 30 testcases were cleaned up/rewritten) * 20 new sysc

Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

2014-04-23 Thread Mats Liljegren
On Wed, 23 Apr 2014 13:34:59 +0200 wrote: > Hi! > > As for -Werror, I can remove it, but not without shedding some > > tears... This was my way of assuring that no one who contributed to > > my code will be able to slip in warnings unnoticed. To turn things > > around: The -Werror is a way of say

Re: [LTP] [PATCH v3] containers/netns:parameters are not correct when calling, crtchild() function

2014-04-23 Thread chrubis
Hi! > The numbers of parameters for crtchild() function which called in > two_children_ns.c and par_chld_ipv6.c is not correct.And it will make > the child process to be a zombie process. > And also move the definition of the function to the header file(common.h) Pushed, thanks. -- Cyril Hrubis

[LTP] posix_fallocate

2014-04-23 Thread Alexey Kodanev
Hi Cyril, I would like to add "posix_fallocate" test based on what we already have in syscalls/fallocate, because the behavior of "posix_fallocate" is close to what is doing fallocate by default, so most test scenarios will be the same. What is the correct way to do it, place it in open_posix_

Re: [LTP] posix_fallocate

2014-04-23 Thread chrubis
Hi! > I would like to add "posix_fallocate" test based on what we already have > in syscalls/fallocate, because the behavior of "posix_fallocate" is > close to what is doing fallocate by default, so most test scenarios will > be the same. What is the correct way to do it, place it in > open_pos

Re: [LTP] [PATCH V2] numa01.sh: numademo fixes

2014-04-23 Thread chrubis
Hi! > 1) numademo does not accept a 'msize' argument. I think it was an initial > typo mistake that numanode was invoked as > numanode -c msize > instead of > numanode -c ${msize}k > > 2) I think test07 should return TPASS if $x is 0 (not 1), because this test > verifies that after execution o

[LTP] ltp-ddt issue

2014-04-23 Thread THEROND Quentin
hello, I working on ltp-ddt and i have a problem. If i launch <<./runltp -f ddt/usb_stress_io>> on BEAGLEBONE the test PASS but if i launch a same command on BEAGLEBOARD the test FAIL. LTP-DDT return: sh: 1: source: not found sh: 1: do_cmd: not found sh: 1: check_config_options: not fou

[LTP] ltp-ddt issue

2014-04-23 Thread THEROND Quentin
hello, I working on ltp-ddt and i have a problem. If i launch <<./runltp -f ddt/usb_stress_io>> on BEAGLEBONE the test PASS but if i launch a same command on BEAGLEBOARD the test FAIL. LTP-DDT return: sh: 1: source: not found sh: 1: do_cmd: not found sh: 1: check_config_options: not f

Re: [LTP] ltp-ddt issue

2014-04-23 Thread chrubis
Hi! > I working on ltp-ddt and i have a problem. If i launch <<./runltp -f > ddt/usb_stress_io>> on BEAGLEBONE the test PASS but if i launch a same > command on BEAGLEBOARD the test FAIL. LTP-DDT return: LTP-DDT is based on (slightly old) LTP but the file in question ddt/usb_stress_io is not part

Re: [LTP] [PATCH] configure: add configure check for GCC -Wold-style-definition

2014-04-23 Thread chrubis
Hi! > > On Fri 11 Apr 2014 13:26:59 Alexey Kodanev wrote: > > > +backup_cflags="$CFLAGS" > > > +CFLAGS="-Wold-style-definition" > > > > this isn't really safe. the CFLAGS might have critical settings in there > > that > > impact linking. why not just append ? > > We can also change the AC_LIN

Re: [LTP] [PATCH V2 05/14] rpc-tirpc: enabled building of the test binaries

2014-04-23 Thread chrubis
Hi! > +++ b/testcases/network/rpc/rpc-tirpc/tests_pack/Makefile.inc > @@ -0,0 +1,20 @@ > +# > +#Copyright (C) 2014, Oracle and/or its affiliates. All Rights Reserved. > +# > +#This program is free software; you can redistribute it and/or modify > +#it under the terms of the GNU General

Re: [LTP] [PATCH V2 08/14] rpc-tirpc: implemented a wrapper

2014-04-23 Thread chrubis
Hi! > +RHOST=${RHOST:-`hostname`} So the test defaults to local machine if RHOST is not set, but still needs rsh installed to run the testcases. Can we do it without the need for rsh in this case? > +SERVER="" > +CLIENT="" > +CLIENT_EXTRA_OPTS="" > +CLEANER="" > +PROGNUMNOSVC=536875000 What is

Re: [LTP] V2 rpc-tirpc-full-test-suite

2014-04-23 Thread chrubis
Hi! Looks good minus the minor issues I've pointed out. -- Cyril Hrubis chru...@suse.cz -- Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open

Re: [LTP] [PATCH v2 1/2] lib/tst_fs_has_free.c: add tst_fs_has_free() to determine filesystem's free space

2014-04-23 Thread chrubis
Hi! > -int tst_cwd_has_free(int required_kib) > -{ > - struct statfs sf; > - statfs(".", &sf); > - > - /* check that we have enough blocks to create swap file */ > - return ((float)sf.f_bfree) / (1024 / sf.f_bsize) >= > - required_kib ? 1 : 0; > -} > diff --git a/lib/tst_fs_

Re: [LTP] [PATCH v2 2/2] tools/apicmd: add tst_fs_has_free

2014-04-23 Thread chrubis
Hi! > diff --git a/tools/apicmds/ltpapicmd.c b/tools/apicmds/ltpapicmd.c > index c8099c5..de58c1e 100644 > --- a/tools/apicmds/ltpapicmd.c > +++ b/tools/apicmds/ltpapicmd.c > @@ -73,6 +73,7 @@ > #include > #include > #include > +#include > #include "test.h" > #include "usctest.h" > #inclu

Re: [LTP] [PATCH v2 1/2] lib/tst_fs_has_free.c: add tst_fs_has_free() to determine filesystem's free space

2014-04-23 Thread chrubis
Hi! > +int tst_fs_has_free(void (*cleanup)(void), const char *path, > + uint64_t required_kib); And I'm thinking if it would be better to change the interface to get size and multiplier something as: enum { TST_KB = 1024, TST_MB = 1048576, TST_GB = 1073741824, }; int