Re: [lttng-dev] [RFC] adding into middle of RCU list

2013-09-01 Thread Josh Triplett
On Sat, Aug 31, 2013 at 02:32:28PM -0700, Paul E. McKenney wrote: On Thu, Aug 29, 2013 at 07:16:37PM -0700, Josh Triplett wrote: On Thu, Aug 29, 2013 at 05:57:33PM -0700, Paul E. McKenney wrote: On Fri, Aug 23, 2013 at 02:08:22PM -0700, Paul E. McKenney wrote: On Fri, Aug 23, 2013 at

Re: [lttng-dev] [RFC] adding into middle of RCU list

2013-09-01 Thread Paul E. McKenney
On Sun, Sep 01, 2013 at 01:42:10PM -0700, Josh Triplett wrote: On Sat, Aug 31, 2013 at 02:32:28PM -0700, Paul E. McKenney wrote: On Thu, Aug 29, 2013 at 07:16:37PM -0700, Josh Triplett wrote: On Thu, Aug 29, 2013 at 05:57:33PM -0700, Paul E. McKenney wrote: On Fri, Aug 23, 2013 at

Re: [lttng-dev] [RFC] adding into middle of RCU list

2013-09-01 Thread Josh Triplett
On Sun, Sep 01, 2013 at 03:26:19PM -0700, Paul E. McKenney wrote: On Sun, Sep 01, 2013 at 01:42:10PM -0700, Josh Triplett wrote: On Sat, Aug 31, 2013 at 02:32:28PM -0700, Paul E. McKenney wrote: On Thu, Aug 29, 2013 at 07:16:37PM -0700, Josh Triplett wrote: On Thu, Aug 29, 2013 at

[lttng-dev] [PATCH] rcu: Make rcu_assign_pointer's assignment volatile and type-safe

2013-09-01 Thread Josh Triplett
rcu_assign_pointer needs to use ACCESS_ONCE to make the assignment to the destination pointer volatile, to protect against compilers too clever for their own good. In addition, since rcu_assign_pointer force-casts the source pointer to add the __rcu address space (overriding any existing address

Re: [lttng-dev] rcu: Make rcu_assign_pointer's assignment volatile and type-safe

2013-09-01 Thread Josh Triplett
On Mon, Sep 02, 2013 at 07:50:09AM +0800, Wang Shilong wrote: Hello, Using checkpatch.pl, i get the following warnings(errors): WARNING: line over 80 characters #57: FILE: include/linux/rcupdate.h:518: + extern void __rcu_assign_pointer_typecheck(int, typeof(*(v)) __kernel *); \

Re: [lttng-dev] [PATCH] rcu: Make rcu_assign_pointer's assignment volatile and type-safe

2013-09-01 Thread Paul E. McKenney
On Sun, Sep 01, 2013 at 04:42:52PM -0700, Josh Triplett wrote: rcu_assign_pointer needs to use ACCESS_ONCE to make the assignment to the destination pointer volatile, to protect against compilers too clever for their own good. In addition, since rcu_assign_pointer force-casts the source