Re: [lttng-dev] [PATCH lttng-tools v3 0/4] Dynamic probe list support

Thanks David! I've had the impression that LTTng follows kernel coding style but it diverts on the if/else case. Personaly I don't buy the {} is better argument, but I'll try to remember your preference :) If you could help me a bit with the config file syntax I'll be happy to add support for it.

[lttng-dev] [PATCH] Fixed alignment problems on targets not supporting unaligned access.

From: Fredrik Markström fredrik.markst...@gmail.com Accessing floats, doubles and 64 bit int at unalign addresses is not supported on all configurations of arm processors and if it is it's emualted and slow. This patch replaces direct assignments with memcpy. Signed-off-by: Fredrik Markstr枚m

[lttng-dev] [PATCH] FIX: Align buffers on 4 bytes for 64bit access

From: Fredrik Markström fredrik.markst...@gmail.com Signed-off-by: Fredrik Markstr枚m fredrik.markst...@gmail.com --- formats/ctf/metadata/objstack.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/formats/ctf/metadata/objstack.c b/formats/ctf/metadata/objstack.c index 9e264a4..9643b9b

Re: [lttng-dev] [PATCH] FIX: Align buffers on 4 bytes for 64bit access

I suggest adding a comment above that line explaining what it does. On 15 May 2014 04:57, rongqing...@windriver.com wrote: From: Fredrik Markström fredrik.markst...@gmail.com Signed-off-by: Fredrik Markstr枚m fredrik.markst...@gmail.com --- formats/ctf/metadata/objstack.c |2 ++ 1 file

[lttng-dev] lttng-ust missing tracepoints

Hi, I created a simple tracepoint following the examples within lttng-ust documentation. The .C source (travcepoint provider) and header files are generated by means of the lttng-gen-tp helper script and then compiled and linked manually within the application. However, my tracepoints are

Re: [lttng-dev] [PATCH] Fixed alignment problems on targets not supporting unaligned access.

- Original Message - From: rongqing li rongqing...@windriver.com To: lttng-dev@lists.lttng.org Sent: Thursday, May 15, 2014 4:50:49 AM Subject: [lttng-dev] [PATCH] Fixed alignment problems on targets not supporting unaligned access. From: Fredrik Markström

Re: [lttng-dev] [PATCH] FIX: Align buffers on 4 bytes for 64bit access

- Original Message - From: rongqing li rongqing...@windriver.com To: lttng-dev@lists.lttng.org Sent: Thursday, May 15, 2014 4:57:30 AM Subject: [lttng-dev] [PATCH] FIX: Align buffers on 4 bytes for 64bit access Why hardcoded constants ? Why 4 ? What is the intent ? Thanks, Mathieu

[lttng-dev] [PATCH v2] Fix: alignment problems on targets not supporting unaligned access.

From: Fredrik Markström fredrik.markst...@gmail.com Accessing floats, doubles and 64 bit int at unaligned addresses is not supported on all configurations of arm processors and if it is it's emulated and slow. This patch replaces direct assignments with memcpy. Signed-off-by: Fredrik Markström