Re: [lttng-dev] [PATCH lttng-ust 6/8] Manually dlopen() liblttng-ust.so to prevent unloading

- On Feb 8, 2018, at 3:24 PM, Francis Deslauriers francis.deslauri...@efficios.com wrote: > 2018-02-07 15:59 GMT-05:00 Mathieu Desnoyers : >> - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers >> francis.deslauri...@efficios.com wrote: >> >>> dlopen() increments the refcount of the library

Re: [lttng-dev] [PATCH lttng-ust 5/8] Fix: missing enum removal from the enum hashtable

- On Feb 8, 2018, at 3:45 PM, Francis Deslauriers francis.deslauri...@efficios.com wrote: > 2018-02-07 15:55 GMT-05:00 Mathieu Desnoyers : >> - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers >> francis.deslauri...@efficios.com wrote: >> >> Is it a fix or a preparation step for a new feat

Re: [lttng-dev] [PATCH lttng-ust 2/8] Fix: missing event removal from the event hashtable

- On Feb 8, 2018, at 3:42 PM, Francis Deslauriers francis.deslauri...@efficios.com wrote: > 2018-02-07 15:50 GMT-05:00 Mathieu Desnoyers : >> >> >> - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers >> francis.deslauri...@efficios.com wrote: >> >> Is this really a fix ? Or is it a preparat

Re: [lttng-dev] [PATCH lttng-ust 5/8] Fix: missing enum removal from the enum hashtable

2018-02-07 15:55 GMT-05:00 Mathieu Desnoyers : > - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > > Is it a fix or a preparation step for a new feature ? Same thought process that with: cds_hlist_del(&event->hlist); Thanks, Francis > > Thanks, > >

Re: [lttng-dev] [PATCH lttng-ust 2/8] Fix: missing event removal from the event hashtable

2018-02-07 15:50 GMT-05:00 Mathieu Desnoyers : > > > - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > > Is this really a fix ? Or is it a preparation step in order to be able to > remove events before the end of the session lifetime ? It's not a fi

Re: [lttng-dev] [PATCH lttng-ust 6/8] Manually dlopen() liblttng-ust.so to prevent unloading

2018-02-07 15:59 GMT-05:00 Mathieu Desnoyers : > - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > >> dlopen() increments the refcount of the library thus preventing the >> refcount to reach zero in the case of dlclose; > > The changelog and comment

Re: [lttng-dev] [PATCH lttng-ust 4/8] Add probe provider unregister function

2018-02-07 15:54 GMT-05:00 Mathieu Desnoyers : > > - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > >> Signed-off-by: Francis Deslauriers >> --- >> include/lttng/ust-events.h | 1 + >> liblttng-ust/lttng-events.c | 89 >> +

Re: [lttng-dev] [PATCH lttng-tools 2/5] Fix: should pass the reg_enum_lookup pointer directly

2018-02-07 15:48 GMT-05:00 Mathieu Desnoyers : > - On Feb 7, 2018, at 2:36 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > >> As the ht_hash_enum and ht_match_enum functions are not changing the >> pointer there is no need to pass the address of the pointer. > > The changel

Re: [lttng-dev] [PATCH lttng-tools 1/5] Fix: probes should not be compared by their names and callsite signatures

2018-02-07 15:43 GMT-05:00 Mathieu Desnoyers : > - On Feb 7, 2018, at 2:36 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > >> Events with different payloads but identical name and signatures could >> lead to corrupted trace as the Session Daemon would consider them >> ident