Re: [lttng-dev] [PATCH] Avoid using the heap for small strings with tracef/tracelog

2021-05-19 Thread Mathieu Desnoyers via lttng-dev
- On May 19, 2021, at 12:56 PM, lttng-dev lttng-dev@lists.lttng.org wrote: > Try to use vsnprintf with a 512 Byte buffer on the Stack, > if that fails allocate a larger one. I agree with the approach. Can we move the hardcoded "512" to a #define within src/common/tracer.h ? Thanks, Mathieu

Re: [lttng-dev] reading context fields causes syscalls

2021-05-19 Thread Mathieu Desnoyers via lttng-dev
- On May 19, 2021, at 8:11 AM, lttng-dev lttng-dev@lists.lttng.org wrote: > Hello, > > Several context fields will cause a syscall atleast the first time a > tracepoint is > recorded. For example all of the following: > > `lttng add-context -c chan --userspace --type=vpid --type=vtid > --ty

[lttng-dev] [PATCH] Avoid using the heap for small strings with tracef/tracelog

2021-05-19 Thread Norbert Lange via lttng-dev
Try to use vsnprintf with a 512 Byte buffer on the Stack, if that fails allocate a larger one. Signed-off-by: Norbert Lange --- liblttng-ust/tracef.c | 13 ++--- liblttng-ust/tracelog.c | 12 +--- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/liblttng-ust/trac

[lttng-dev] reading context fields causes syscalls

2021-05-19 Thread Norbert Lange via lttng-dev
Hello, Several context fields will cause a syscall atleast the first time a tracepoint is recorded. For example all of the following: `lttng add-context -c chan --userspace --type=vpid --type=vtid --type=procname` Each of them seems cached in TLS however, and most should never change after start

[lttng-dev] tracelog / tracef feature

2021-05-19 Thread Norbert Lange via lttng-dev
Hello, I finally got some time digging into Lttng (using it on Xenomai, see [1] for historic reference). Since we have a hard realtime system, I chosen to use dynamic probes. That means only liblttng-ust-tracepoint.so wil get pulled into the process (it its available), no threads are spawned, etc