Re: [lttng-dev] [PATCH lttng-ust] Copyright ownership transfer

2022-01-17 Thread David Goulet via lttng-dev
On 14 Jan (15:14:09), Mathieu Desnoyers wrote: > Apply copyright ownership transfer from David Goulet and Julien Desfossez > to EfficiOS Inc. > > Link: https://lists.lttng.org/pipermail/lttng-dev/2022-January/030087.html > Link: https://lists.lttng.org/pipermail/lttng-dev/2022-Janu

Re: [lttng-dev] [PATCH lttng-tools] Copyright ownership transfer

2022-01-17 Thread David Goulet via lttng-dev
On 14 Jan (15:48:45), Jérémie Galarneau wrote: > Apply copyright ownership transfer from David Goulet, Julien Desfossez, > and Simon Marchi to EfficiOS Inc. > > Link: https://lists.lttng.org/pipermail/lttng-dev/2022-January/030087.html > Link: https://lists.lttng.org/pipermail

Re: [lttng-dev] Transfer of LTTng copyright ownership: David Goulet

2022-01-14 Thread David Goulet via lttng-dev
rly affects the lttng-tools and lttng-ust files with copyright: > > Copyright (C) 201N David Goulet No problem. I agree and this email is GPG signed :). Cheers! David -- xtN36bqNuwFHhNp1j45nwcCwE5HeLkdFZT9naRvLgG0= signature.asc Description: PGP signature __

[lttng-dev] UST improvement ideas

2014-11-25 Thread David Goulet
Hello LTTng! Yes, I'm not involved in development anymore BUT that does not mean I'm not using LTTng :). Let me share with all of you some improvement ideas for LTTng-UST after using it a bit more extensively in a large application. In a nutshell, we use LTTng to do measurements of certain

Re: [lttng-dev] [PATCH lttng-tools 1/2] Fix: syscall list ioctl number conflict

2014-10-31 Thread David Goulet
merged in 2.6.0-rc2 David On 20 Oct (18:50:32), Mathieu Desnoyers wrote: Signed-off-by: Mathieu Desnoyers mathieu.desnoy...@efficios.com --- src/common/kernel-ctl/kernel-ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/kernel-ctl/kernel-ioctl.h

Re: [lttng-dev] health check and relaunch of lttng daemons

2014-10-23 Thread David Goulet
On 23 Oct (12:37:40), Anand Neeli wrote: Hi All, I have few queries related to notifications when lttng daemons die and their spawning and health-check - When relayd dies then sessiond gets error of connection reset, but it doesnt try to reconnect to relayd again. It just lies on system

[lttng-dev] A kind of farewell :)

2014-10-23 Thread David Goulet
Greetings everyone! This email is to announce that I will be leaving EfficiOS Inc. on November 1st 2014 thus *not* working full time anymore on the LTTng project. dreamy paragraph I've been involved for 5 years in the project of which 4 years maintaining the lttng-tools code base so rest assure

[lttng-dev] [RELEASE] LTTng-Tools 2.6.0-rc1 - Gaia

2014-10-20 Thread David Goulet
Greetings everyone (including LTTng bards!), The lttng-tools project provides a session daemon (lttng-sessiond) that acts as a tracing registry, the lttng command line for tracing control, a lttng-ctl library for tracing control and a lttng-relayd for network streaming and live reading. This is

[lttng-dev] [RELEASE] LTTng-Tools 2.5.1

2014-10-20 Thread David Goulet
Greetings everyone (including LTTng bards!), The lttng-tools project provides a session daemon (lttng-sessiond) that acts as a tracing registry, the lttng command line for tracing control, a lttng-ctl library for tracing control and a lttng-relayd for network streaming and live reading. This is

Re: [lttng-dev] [PATCH lttng-tools] Fix: FD leak in accept error handling

2014-10-04 Thread David Goulet
That has been fix. commit 475cd9fa36ab2ad108f94bb8292bdcdbbbc6e38f This was a coverity issue fixed on sept. 30th. David On 04 Oct (13:24:02), Mathieu Desnoyers wrote: Bump. - Original Message - From: Mathieu Desnoyers mathieu.desnoy...@efficios.com To: dgou...@efficios.com

Re: [lttng-dev] [PATCH lttng-tools] Fix out-of-tree build

2014-09-25 Thread David Goulet
Merged! On 19 Sep (21:29:23), Simon Marchi wrote: Signed-off-by: Simon Marchi simon.mar...@polymtl.ca --- tests/regression/tools/mi/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/regression/tools/mi/Makefile.am

Re: [lttng-dev] [PATCH lttng-tools] Fix: report UST consumer channel creation error

2014-09-25 Thread David Goulet
Merged! On 22 Sep (12:39:08), Mathieu Desnoyers wrote: The session daemon reports no error whatsoever when the consumer daemon fails to create a channel. We don't want to print errors when failing to send the channel to the UST application though, because the application may be concurrently

Re: [lttng-dev] [RFC PATCH lttng-tools] Fix: Propagate socket timeouts on lttcomm_accept_inet_sock()

2014-09-25 Thread David Goulet
Merged! On 23 Sep (17:46:32), Jérémie Galarneau wrote: Ensure that send/recv timeouts are applied to new sockets created from a lttcomm_accept_inet_sock(). Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- src/common/sessiond-comm/inet.c | 14 ++ 1 file

Re: [lttng-dev] [PATCH lttng-tools] sessiond: add --extra-kmod-probes option

2014-09-19 Thread David Goulet
Merged! Small fixes of the syntax in the commit. David On 12 Sep (21:37:18), Philippe Proulx wrote: This patch adds the --extra-kmod-probes option to lttng-sessiond. The LTTNG_EXTRA_KMOD_PROBES environment variable may also be used. The option specifies a list of extra probe kernel

Re: [lttng-dev] [PATCH lttng-tools] Fix: ignore error when loading optional kmod

2014-09-19 Thread David Goulet
Merged! On 15 Sep (13:43:56), Philippe Proulx wrote: This commit also improves the accuracy of debug messages: a module is not successfully loaded when it's optional and actually not loaded. Fixes: #837 Signed-off-by: Philippe Proulx eeppelitel...@gmail.com ---

Re: [lttng-dev] Odd file and path in lttng-tools tarball

2014-09-10 Thread David Goulet
On 10 Sep (20:14:56), Thibault, Daniel wrote: In the almost-current tarball for lttng-tools (2.5.0-rc2-93, 6e7241f) (current version is 2.5.0-rc2-101, 883d80f), there is an odd file present, presumably a leftover from testing: tests/regression/tools/save-load/

Re: [lttng-dev] Odd file and path in lttng-tools tarball

2014-09-10 Thread David Goulet
On 10 Sep (20:28:48), Thibault, Daniel wrote: -Message d'origine- De : David Goulet [mailto:dgou...@efficios.com] Envoyé : 10 septembre 2014 16:24 tests/regression/tools/save-load/ /tmp/tmp.eAJ1f0oCZE/test-42/save-42.lttng Hrm ... I don't see that in any 2.5.0-rcX tarball

Re: [lttng-dev] [PATCH] Load modules through kmod

2014-09-08 Thread David Goulet
Merged! I've made some basic syntax fix. Big thanks for this! Cheers! David On 04 Sep (10:30:53), Umut Tezduyar Lindskog wrote: Instead of forking processes, load modules through libkmod. This adds an optional package dependency to kmod but can be disabled by --disable-kmod option in

Re: [lttng-dev] [PATCH lttng-tool] Fix: list without a name is not an error

2014-09-03 Thread David Goulet
Merged! On 22 Aug (16:25:47), Jonathan Rajotte Julien wrote: Signed-off-by: Jonathan Rajotte Julien jonathan.r.jul...@gmail.com --- src/bin/lttng/commands/list.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/bin/lttng/commands/list.c b/src/bin/lttng/commands/list.c index

Re: [lttng-dev] [PATCH lttng-tool] Fix: parse_prob_opts return the actual success of the function

2014-09-03 Thread David Goulet
Merged On 27 Aug (15:46:57), Jonathan Rajotte Julien wrote: This bug have been triggered by the mi merging and the use of a command_ret in enable_events functions. Previously, enable_events was reusing the ret variable for another operation and always replacing ret. Parse_probe_event returned

Re: [lttng-dev] [PATCH lttng-tool] Fix: mi print of probe attributes + validation

2014-09-03 Thread David Goulet
Merged On 28 Aug (16:51:09), Jonathan Rajotte Julien wrote: Signed-off-by: Jonathan Rajotte Julien jonathan.r.jul...@gmail.com --- src/common/mi-lttng.c | 37 - src/common/mi_lttng.xsd | 6 +++--- 2 files changed, 39 insertions(+), 4 deletions(-)

Re: [lttng-dev] [PATCH lttng-tools 1/2] Fix: Parenthesize previous statement when adding conditions to a filter

2014-09-03 Thread David Goulet
Both patches merged! On 28 Aug (12:53:43), Jérémie Galarneau wrote: Not parenthesizing the clauses in a filter string causes JUL events to be traced even though they are not enabled when an enable-event command is issued with a filter and the --loglevel-only option. For instance, lttng

Re: [lttng-dev] [PATCH lttng-tools] Load modules through kmod

2014-09-03 Thread David Goulet
On 26 Aug (16:27:46), Umut Tezduyar Lindskog wrote: Instead of forking processes, load modules through libkmod. This adds a package dependency to kmod but can be disabled by --disable-kmod option in ./configure. First, thanks for this patch, this is really good to have! Adding a dependency

Re: [lttng-dev] [PATCH lttng-tools] Fix: Man page typos

2014-08-16 Thread David Goulet
Merged. Backported to stable-2.5 also On 14 Aug (16:17:22), Jérémie Galarneau wrote: Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- doc/man/lttng-sessiond.8 | 8 doc/man/lttng.1 | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff

Re: [lttng-dev] [PATCH lttng-tool] Mi save/load: add option to indent or not on config writer creation

2014-08-16 Thread David Goulet
Merged On 06 Aug (10:13:48), Jonathan Rajotte Julien wrote: The presence of tabulation and newline in mi is irrelevant and can impact client performance. The parsing processing of a lot of data from mi with many /t and /n impact performance. This aim to fix the problem at the source. Style

Re: [lttng-dev] [PATCH lttng-tool] fix: mi: xsd: wrong comment for context_type_type

2014-08-16 Thread David Goulet
Merged On 13 Aug (16:58:29), Jonathan Rajotte Julien wrote: Signed-off-by: Jonathan Rajotte Julien jonathan.r.jul...@gmail.com --- src/common/mi_lttng.xsd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/mi_lttng.xsd b/src/common/mi_lttng.xsd index

Re: [lttng-dev] [PATCH lttng-tool] Fix: list command: revert merge error made when adding mi on pretty printing

2014-08-16 Thread David Goulet
On 12 Aug (13:55:40), Jonathan Rajotte Julien wrote: Signed-off-by: Jonathan Rajotte Julien jonathan.r.jul...@gmail.com --- src/bin/lttng/commands/list.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/bin/lttng/commands/list.c b/src/bin/lttng/commands/list.c

[lttng-dev] Vacation 2014

2014-08-14 Thread David Goulet
Hi everyone! Quick announcement to inform that i'll be on vacation meaning away from emails/IRC from August 17th to Sept 1st 2014. While I'm away, Jérémie Galarneau is the maintainer of lttng-tools so please be nice to him :). Cheers! David signature.asc Description: Digital signature

[lttng-dev] [PATCH lttng-ust] Change JUL agent to use the new ABI

2014-08-08 Thread David Goulet
From: David Goulet dgou...@efficios.com Two things have changed, the agent port file created by the session daemon, the name is now agent.port. The second thing is that upon registration, the agent needs to send its domain which is here LTTNG_DOMAIN_JUL (val: 3). Signed-off-by: David Goulet dgou

Re: [lttng-dev] [PATCH lttng-tools 1/2] Fix: out of tree build by adding missing ini.c include

2014-07-30 Thread David Goulet
Merged On 29 Jul (18:10:27), Mathieu Desnoyers wrote: Signed-off-by: Mathieu Desnoyers mathieu.desnoy...@efficios.com --- src/common/config/ini.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/common/config/ini.c b/src/common/config/ini.c index 4369a32..7b2a4b6 100644 ---

Re: [lttng-dev] [PATCH lttng-tools] Fix: git version build system integration (v2)

2014-07-30 Thread David Goulet
Merged On 29 Jul (18:36:51), Mathieu Desnoyers wrote: Fix: - Don't overwrite version.h if the previous content matches. - While we are there, if we notice the previous content matches, print a (cached) message to show that we do not overwrite the content. - Introduce

Re: [lttng-dev] [PATCH lttng-tool] Fix: mi: logically dead code, missing ret assignment

2014-07-29 Thread David Goulet
Merged On 28 Jul (15:50:28), Jonathan Rajotte Julien wrote: Signed-off-by: Jonathan Rajotte Julien jonathan.r.jul...@gmail.com --- src/bin/lttng/commands/list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/lttng/commands/list.c b/src/bin/lttng/commands/list.c

Re: [lttng-dev] [PATCH lttng-tool] mi: add machine interface description to man page

2014-07-29 Thread David Goulet
Merged. I corrected a couple of things but most of it is there. Thanks! David On 29 Jul (10:25:52), Jonathan Rajotte Julien wrote: Signed-off-by: Jonathan Rajotte Julien jonathan.r.jul...@gmail.com --- doc/man/lttng.1 | 20 1 file changed, 20 insertions(+) diff --git

Re: [lttng-dev] [PATCH lttng-tool] Fix: mi: missing files on make dist

2014-07-29 Thread David Goulet
Merged On 29 Jul (15:24:16), Jonathan Rajotte Julien wrote: Signed-off-by: Jonathan Rajotte Julien jonathan.r.jul...@gmail.com --- src/common/Makefile.am| 1 + tests/regression/tools/mi/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [lttng-dev] [PATCH lttng-tools] Fix: unbalanced ustconsumer32_data.pid_mutex lock

2014-07-28 Thread David Goulet
Merged and backported! Thanks! David On 27 Jul (20:38:50), Mathieu Desnoyers wrote: It is never locked in this function, but should be. This is triggering spurious runtime failures on my system, where it seems that sessiond was sometimes breaking the communication pipe with liblttng-ctl when

Re: [lttng-dev] [PATCH lttng-tools] Change wfq usages for wfcq

2014-07-28 Thread David Goulet
So there is quite an issue with that which is that tools does not work with urcu 0.7 anymore. That would mean urcu 0.8 and later would be the requirement from now on. Not sure I'm comfortable with that but again I don't see why we should not do that also David On 26 Jul (01:26:56), Simon

Re: [lttng-dev] [PATCH lttng-tools] Change wfq usages for wfcq

2014-07-28 Thread David Goulet
As agreed on #lttng, I've merged that patch and changed the requirements for userspace RCU from = 0.7.2 to = 0.8.0. Thanks! David On 28 Jul (15:10:44), Simon Marchi wrote: On 28 July 2014 14:50, David Goulet dgou...@efficios.com wrote: So there is quite an issue with that which is that tools

[lttng-dev] [RELEASE] LTTng-Tools 2.4.2

2014-07-16 Thread David Goulet
Greetings everyone (including LTTng gnomes), The lttng-tools project provides a session daemon (lttng-sessiond) that acts as a tracing registry, the lttng command line for tracing control, a lttng-ctl library for tracing control and a lttng-relayd for network streaming. This is the minor release

[lttng-dev] [RELEASE] LTTng-Tools 2.5.0 - Fumisterie

2014-07-16 Thread David Goulet
Greetings everyone (including LTTng gnomes), The lttng-tools project provides a session daemon (lttng-sessiond) that acts as a tracing registry, the lttng command line for tracing control, a lttng-ctl library for tracing control and a lttng-relayd for network streaming. This is the stable

Re: [lttng-dev] lttng-tools compilation error v2.5.0 rc1

2014-07-09 Thread David Goulet
Merged! Sorry for the delay, AFK from work :). Cheers! David On 27 Jun (13:27:19), Martin Townsend wrote: Hi, I updated to version 2.5.0 rc1 today and found that I couldn't build lttng-tools for my Microblaze based system. | error.c: In function 'log_add_time': | error.c:52:17: error:

[lttng-dev] [RELEASE] LTTng-Tools 2.5.0-rc2

2014-06-27 Thread David Goulet
Greetings everyone (including LTTng elves), The lttng-tools project provides a session daemon (lttng-sessiond) that acts as a tracing registry, the lttng command line for tracing control, a lttng-ctl library for tracing control and a lttng-relayd for network streaming. This is the release

Re: [lttng-dev] [PATCH lttng-ust] JUL: use root logger to capture events

2014-06-26 Thread David Goulet
On 26 Jun (16:05:31), Tan Dung Le Tran wrote: Hi David, Is this patch applicable for lttng-ust origin/stable-2.4 ? Yes, Mathieu will merge this in 2.4 today and we will do a release. David Thanks, Tan -Original Message- From: David Goulet [mailto:dgou...@efficios.com

[lttng-dev] [PATCH] Fix: set thread in daemon mode

2014-06-26 Thread David Goulet
This way, when the JVM stops the main thread, the agent's thread will be automatically shutdown thus making the .dispose() call optional. Signed-off-by: David Goulet dgou...@efficios.com --- liblttng-ust-jul/org/lttng/ust/jul/LTTngAgent.java | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [lttng-dev] trace time out of order

2014-06-25 Thread David Goulet
On 25 Jun (15:15:50), zhenyu.ren wrote: Hi,lttng-dev I traced my rpc application. On the server side ,a thread reads a request from the socket and push the workitem to a queue(pushWorkItem tracepoint after queuing),another thread will get the workitem from queue and process

Re: [lttng-dev] lttng enable-event fails

2014-06-24 Thread David Goulet
On 24 Jun (08:47:21), Thierry Bultel wrote: Hi, I am using lttng (2.4.1), target is ARM Cortex A9; compiler is gcc-4.7.3, but I have the same issue with gcc-4.8.2 The kernel is Freescale's 3.0.35-4.1.0 lttng fails to start: [root@buildroot ~]# lttng create Session

Re: [lttng-dev] [PATCH lttng-tools] Add vpid, vppid and vtid explanation in add-context help menu

2014-06-19 Thread David Goulet
On 18 Jun (22:19:40), francis.deslauri...@efficios.com wrote: From: Francis Deslauriers francis.deslauri...@efficios.com Signed-off-by: Francis Deslauriers francis.deslauri...@efficios.com --- src/bin/lttng/commands/add_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [lttng-dev] [PATCH lttng-tools] Add vpid, vppid and vtid explanation in add-context help menu

2014-06-19 Thread David Goulet
On 19 Jun (14:38:52), Francis Deslauriers wrote: On Thu, Jun 19, 2014 at 2:21 PM, David Goulet dgou...@efficios.com wrote: On 18 Jun (22:19:40), francis.deslauri...@efficios.com wrote: From: Francis Deslauriers francis.deslauri...@efficios.com Signed-off-by: Francis Deslauriers

[lttng-dev] [PATCH v2 lttng-ust] JUL: use root logger to capture events

2014-06-18 Thread David Goulet
filtering is done in UST, we just the LTTng handler to the root logger and send everything to UST. Signed-off-by: David Goulet dgou...@efficios.com --- .../org/lttng/ust/jul/LTTngLogHandler.java | 98 + .../org/lttng/ust/jul/LTTngSessiondCmd2_4.java | 162

Re: [lttng-dev] [PATCH lttng-tool] Fix: wrong behavior of save command when no session name is provided

2014-06-17 Thread David Goulet
Merged! Thanks David On 17 Jun (15:59:41), Jonathan Rajotte Julien wrote: No session name and no option --all should default to --all. Signed-off-by: Jonathan Rajotte Julien jonathan.r.jul...@gmail.com --- src/bin/lttng/commands/save.c | 7 ++- 1 file changed, 2 insertions(+), 5

Re: [lttng-dev] [lttng-tool] Fix: wrong casting of return value

2014-06-12 Thread David Goulet
Merged! On 09 Jun (11:40:36), Jonathan Rajotte Julien wrote: The function uri_parse_str_urls return a ssize_t and the return was casted to a size_t. This caused the following error checking to fail as -1 was interpreted as 18446744073709551615. Fixes #803 Signed-off-by: Jonathan Rajotte

Re: [lttng-dev] [PATCH lttng-tool] Fix: missing context type string in save for ust context

2014-06-12 Thread David Goulet
Merged! On 09 Jun (15:45:39), Jonathan Rajotte Julien wrote: Return string for LTTNG_UST_CONTEXT_PERF_THREAD_COUNTER was missing and caused an error on save when a context of PERF_THREAD_COUNTER type was present (Error: Invalid parameter). Fixes #804 Signed-off-by: Jonathan Rajotte

Re: [lttng-dev] LTTng 2.5 save/load feature feedback

2014-06-02 Thread David Goulet
On 30 May (11:54:02), Julien Desfossez wrote: Hi, I recently tried the new save/load feature and I have some feedback I'd like to share. My understanding was that I could create some kind of profile for complex tracing setups. Lttngtop is a good example, because we have a specific set of

Re: [lttng-dev] [PATCH v2] Fix: alignment problems on targets not supporting unaligned access.

2014-05-28 Thread David Goulet
Merged! Thanks David On 16 May (09:10:07), rongqing...@windriver.com wrote: From: Fredrik Markström fredrik.markst...@gmail.com Accessing floats, doubles and 64 bit int at unaligned addresses is not supported on all configurations of arm processors and if it is it's emulated and slow. This

[lttng-dev] [RELEASE] LTTng-Tools 2.5.0-rc1 - Fumisterie - International Hamburger Day

2014-05-28 Thread David Goulet
Greetings everyone (including LTTng elves), The lttng-tools project provides a session daemon (lttng-sessiond) that acts as a tracing registry, the lttng command line for tracing control, a lttng-ctl library for tracing control and a lttng-relayd for network streaming. We are VERY happy to

[lttng-dev] [PATCH] Fix: out of tree build for lib Java and JUL

2014-05-27 Thread David Goulet
Reported-by: Daniel Olivier daniel.oliv...@ericsson.com Signed-off-by: David Goulet dgou...@efficios.com --- liblttng-ust-java/Makefile.am | 2 +- liblttng-ust-jul/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/liblttng-ust-java/Makefile.am b/liblttng-ust-java

Re: [lttng-dev] [PATCH lttng-tools] Documentation: document tracefile max size discarded event limitation

2014-05-26 Thread David Goulet
On 22 May (13:35:12), Mathieu Desnoyers wrote: - Original Message - From: Daniel Thibault daniel.thiba...@drdc-rddc.gc.ca To: lttng-dev@lists.lttng.org Cc: Mathieu Desnoyers mathieu.desnoy...@efficios.com, David Goulet dgou...@efficios.com Sent: Thursday, May 22, 2014 9:01:20

Re: [lttng-dev] [PATCH lttng-tools] Documentation: document tracefile max size discarded event limitation

2014-05-21 Thread David Goulet
Merged On 21 May (12:10:24), Mathieu Desnoyers wrote: Signed-off-by: Mathieu Desnoyers mathieu.desnoy...@efficios.com CC: David Goulet dgou...@efficios.com --- doc/man/lttng.1 |2 ++ src/bin/lttng/commands/enable_channels.c |2 ++ 2 files changed, 4

Re: [lttng-dev] [PATCH lttng-tools] Fix: Copy-pasted PERROR messages may be misleading

2014-05-14 Thread David Goulet
Merged On 14 May (11:32:10), Jérémie Galarneau wrote: Some PERRORs in lttng-sessiond's pthread_create's error handling code indicate the wrong thread name which may be misleading during debugging. Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com ---

Re: [lttng-dev] [PATCH lttng-tools] Docs: Add a section documenting lttng-sessiond's -l/--load option

2014-05-14 Thread David Goulet
Merged! On 14 May (13:46:06), Jérémie Galarneau wrote: Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- doc/man/lttng-sessiond.8 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/man/lttng-sessiond.8 b/doc/man/lttng-sessiond.8 index 633cf81..e6e37a0 100644 ---

Re: [lttng-dev] [PATCH lttng-tools v3 0/4] Dynamic probe list support

2014-05-14 Thread David Goulet
Merged! I merged it with some minor syntax fixes mostly in modprobe.c. There is one thing I don't accept at all is if/else without {}. Remember the goto fail; bug :). Anyhow, I fixed them to fit my OCD if/else issue. ;) Big thanks for that, this is really great! I would love to improve that

Re: [lttng-dev] [PATCH lttng-tools] Fix: Tests should set the LTTNG_SESSION_CONFIG_XSD_PATH variable

2014-05-14 Thread David Goulet
Merged! On 14 May (16:52:22), Jérémie Galarneau wrote: Tests should set the LTTNG_SESSION_CONFIG_XSD_PATH environment variable to use the in-tree session configuration schema. Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- tests/utils/utils.sh | 2 ++ 1 file changed,

Re: [lttng-dev] [PATCH lttng-tools] Docs: Add load and save sections to the lttng.1 man page

2014-05-13 Thread David Goulet
Merged with minor modifications. David On 13 May (12:14:10), Jérémie Galarneau wrote: Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- doc/man/lttng.1 | 60 + 1 file changed, 60 insertions(+) diff --git

Re: [lttng-dev] [RFC Patch Tools 3/4] Remove required parameter from module parameters

2014-05-13 Thread David Goulet
Hi Jan, I was merging those for 2.5 but this one (3/4) does not apply. I tried to play with it but I can't make it work. The only thing that has changed is that we've added a module lately but even by modifying your patch to add that module, it still does not apply. Do you think you can simply

Re: [lttng-dev] [PATCH lttng-tools] Fix: Don't report an error if no sessions are found with default options

2014-05-12 Thread David Goulet
Merged! And all three other fixes that followed this one: Print an error message when a session fails to load Fix: Possible out-of-bounds read Fix: Ressource leak, missing fclose Cheers! David On 08 May (12:12:28), Jérémie Galarneau wrote: Signed-off-by: Jérémie Galarneau

Re: [lttng-dev] [PATCH lttng-tools] Add a -l/--load option to the session-daemon

2014-05-12 Thread David Goulet
Merged with modifications discussed with the Author. commit 39120e55fda06380e866f5c1c87b2a094bcca4ab David On 08 May (12:02:52), Jérémie Galarneau wrote: This option makes it possible to set a PATH from which session configurations are loaded by the session daemon on startup.

Re: [lttng-dev] [PATCH lttng-tools] Fix: Don't output to stdout from lttng-ctl

2014-05-07 Thread David Goulet
Merged! On 07 May (14:27:45), Jérémie Galarneau wrote: Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- src/bin/lttng/commands/stop.c | 29 - src/lib/lttng-ctl/lttng-ctl.c | 7 --- 2 files changed, 24 insertions(+), 12 deletions(-) diff

Re: [lttng-dev] Pull request: lttng-tools UST x86 perf counters

2014-05-05 Thread David Goulet
Merged! Thanks David On 27 Apr (11:57:52), Mathieu Desnoyers wrote: Hi David, Please pull from: https://github.com/compudj/lttng-tools-dev.git branch: perf-counter-ust Top commit: commit 462125b4a2658a3c1c6c00d2be5bd2653c4ae2f6 Author: Julien Desfossez jdesfos...@efficios.com Date:

Re: [lttng-dev] [PATCH lttng-tools] Fix: Out of tree build fails in libconfig

2014-05-05 Thread David Goulet
Merged On 05 May (10:41:46), Jérémie Galarneau wrote: libconfig_la_CPPFLAGS should also include the top-level AM_CPPFLAGS. Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- src/common/config/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [lttng-dev] [PATCH lttng-tools] Fix: Don't include the binary in the live test's EXTRA_DIST

2014-05-05 Thread David Goulet
Merged On 05 May (15:21:18), Jérémie Galarneau wrote: Adding the binary in EXTRA_DIST causes the dist target to fail with a No rule to make target libtap.la error. Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- tests/regression/tools/live/Makefile.am | 2 +- 1 file

Re: [lttng-dev] [PATCH] Clarify limitations of the --syscall flag with enable-event command

2014-04-30 Thread David Goulet
Merged On 16 Apr (12:26:25), Christian Babeux wrote: Signed-off-by: Christian Babeux christian.bab...@efficios.com --- doc/man/lttng.1 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/man/lttng.1 b/doc/man/lttng.1 index 972f71c..9882083 100644 ---

Re: [lttng-dev] [PATCH v4 lttng-tools] Backported to glibc 2.8

2014-04-24 Thread David Goulet
On 24 Apr (08:58:19), Mathieu Desnoyers wrote: /* See man epoll(7) for this define path */ #define COMPAT_EPOLL_PROC_PATH /proc/sys/fs/epoll/max_user_watches @@ -71,7 +73,15 @@ enum { LPOLLNVAL = EPOLLHUP, LPOLLRDHUP = EPOLLRDHUP, /* Close on exec feature of epoll */

Re: [lttng-dev] [PATCH lttng-tools] Better error reporting when a snapshot record size is too small

2014-04-15 Thread David Goulet
On 15 Apr (10:32:09), Jérémie Galarneau wrote: Print an error message when a snapshot record is made with a max size smaller than the subbuffers. This limitation is now documented in the man page. Why is this not done on the session daemon side? Like Oh you provided me with a wrong max size

Re: [lttng-dev] [PATCH lttng-tools] Better error reporting when a snapshot record size is too small

2014-04-15 Thread David Goulet
On 15 Apr (11:14:18), Jérémie Galarneau wrote: On Tue, Apr 15, 2014 at 10:44 AM, David Goulet dgou...@efficios.com wrote: On 15 Apr (10:32:09), Jérémie Galarneau wrote: Print an error message when a snapshot record is made with a max size smaller than the subbuffers. This limitation is now

Re: [lttng-dev] [PATCH lttng-tools 1/2] Override the session.xsd path with an environment variable

2014-04-14 Thread David Goulet
On 10 Apr (23:58:02), Jérémie Galarneau wrote: The LTTNG_SESSION_CONFIG_XSD_PATH environment variable can be used to specify a path which contains the session configuration schema. This will allow save-load tests to be ran without installing the XSD on the system. Signed-off-by: Jérémie

Re: [lttng-dev] [PATCH lttng-tools] Fix: replace 1 for true in libxml checking

2014-04-14 Thread David Goulet
Merged! On 14 Apr (10:42:38), Jonathan Rajotte wrote: Initial bug on ./configure: checking for libxml - version = 2.7.6... yes (version 2.9.1) ./configure: line 5137: 1: command not found Signed-off-by: Jonathan Rajotte jonathan.r.jul...@gmail.com --- configure.ac | 2 +- 1 file

Re: [lttng-dev] [MI RFC 1/3] Mi: mi backend + mi for command version

2014-04-14 Thread David Goulet
for merging upstream. https://github.com/dgoulet/lttng-tools-dev.git (branch: mi) Cheers! David Thanks On Mon, Apr 14, 2014 at 11:26 AM, David Goulet dgou...@efficios.com wrote: I've fixed some minor things and prepared this one for a merge. Once the full patch set is ready

Re: [lttng-dev] [RFC Patch Tools 0/4] Configurable lttng-probe modules

2014-04-14 Thread David Goulet
On 11 Apr (10:40:47), Jan Glauber wrote: On Thu, Apr 10, 2014 at 03:45:51PM -0400, David Goulet wrote: On 03 Apr (12:57:43), Jan Glauber wrote: Hi LTTng'ers, I've asked briefly for the configurable probes feature at the Tracing summit, here is an RFC how we could implement

Re: [lttng-dev] [PATCH lttng-tools 1/2] Override the session.xsd path with an environment variable

2014-04-14 Thread David Goulet
Merged. David On 14 Apr (12:10:44), Jérémie Galarneau wrote: The LTTNG_SESSION_CONFIG_XSD_PATH environment variable can be used to specify a path which contains the session configuration schema. This will allow save-load tests to be ran without installing the XSD on the system.

Re: [lttng-dev] [PATCH lttng-tools] Backported to glibc 2.8

2014-04-10 Thread David Goulet
Hi Jesper, Code wise, this looks good but I can't test that feature since glibc 2.8 is kind of *old* and I have no system to test that. Could you provide me a Tested-by: string and I'll trust you words that you did a make check on a glibc 2.8. Thanks! David On 27 Mar (14:38:52),

Re: [lttng-dev] [PATCH lttng-tools] Add MIT license header to session.xsd

2014-04-10 Thread David Goulet
Merged! On 07 Apr (11:47:37), Jérémie Galarneau wrote: Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- src/common/config/session.xsd | 21 + 1 file changed, 21 insertions(+) diff --git a/src/common/config/session.xsd b/src/common/config/session.xsd

Re: [lttng-dev] [PATCH lttng-tools] utils: Rework utils_parse_size_suffix

2014-04-10 Thread David Goulet
On 10 Apr (11:30:19), Simon Marchi wrote: Ok, so there are a lot of problems with this function (sorry :|). Taking the regex road is probably to complicated for nothing, so here is a version without regexes. I added many test cases as suggested by Sandeep Chaudhary and Daniel Thibault. I

[lttng-dev] [RELEASE] LTTng-Tools 2.4.1 (OpenSSL heartbleed day)

2014-04-08 Thread David Goulet
Greetings everyone (including LTTng elves), The lttng-tools project provides a session daemon (lttng-sessiond) that acts as a tracing registry, the lttng command line for tracing control, a lttng-ctl library for tracing control and a lttng-relayd for network streaming. This version is bug fixes

Re: [lttng-dev] lttng-sessiond: ht-cleanup.c:92: thread_ht_cleanup: Assertion `pollfd == ht_cleanup_pipe[0]' failed.

2014-04-03 Thread David Goulet
On 20 Mar (13:54:55), Gerlando Falauto wrote: Hi, I'm trying to bring lttng-tools up to date, but I get the following message: lttng-sessiond: ht-cleanup.c:92: thread_ht_cleanup: Assertion `pollfd == ht_cleanup_pipe[0]' failed. I noticed this was already filed as a bug:

Re: [lttng-dev] Regarding Bug #633 - utils_parse_size_suffix suffers from several problems

2014-04-03 Thread David Goulet
the default diff command output is a bit unreadable for my passionate git eye :). Thanks! David Thanks and regards, Sandeep. On Tue, Mar 25, 2014 at 7:22 AM, David Goulet dgou...@efficios.com wrote: On 21 Mar (00:22:57), Sandeep K Chaudhary wrote: Hi guys, I checked the fix

Re: [lttng-dev] Announcing sysdig: a new take on system instrumentation

2014-04-03 Thread David Goulet
Hi Loris, I have to say that I'm quite impress with the analysis tool you guys have (Chisel). Quick very useful command for monitoring use cases, very nice stuff. Question time! Have you at some point consider using LTTng toolchain for the tracing part? Using the lttng-modules for your probes,

Re: [lttng-dev] Minor documentation issue with 2.4.0

2014-04-02 Thread David Goulet
On 02 Apr (10:48:02), Jérémie Galarneau wrote: Hi Amit, Can you open a bug against lttng-tools on bugs.lttng.org? This way we'll be sure to track the change. You can't enable channel in JUL, this is one of the limitations. First, it shouldn't mention -j at all in the help or man page.

Re: [lttng-dev] [MI-prototype] MI: mi-lttng into libcommon, global option lttng_mi_opt , command version

2014-03-25 Thread David Goulet
On 21 Mar (13:25:12), Jonathan Rajotte wrote: Hi guys, This is our current machine interface backend. You can test it by applying this patch to master. Finally after discussion with Jeremie Galard and David Goulet, we chosed to use a global option for the machine interface. lttng

Re: [lttng-dev] Working on some bugs

2014-03-12 Thread David Goulet
On 11 Mar (23:59:57), Sandeep K Chaudhary wrote: http://bugs.lttng.org/issues/621 This one should be quite straight forward. There is already version check for the create_session command I think. Here is your starting point. I don't see the version check in create_session in

Re: [lttng-dev] [PATCH lttng-tools] Use autoconf AM_MAINTAINER_MODE.

2014-03-12 Thread David Goulet
Merged! Thanks David On 12 Mar (10:22:40), Lars Persson wrote: Give distribution maintainers the option to skip rebuilding autoconf and automake generated files. The default behaviour is still to have the rebuild rules enabled. Signed-off-by: Lars Persson lar...@axis.com ---

Re: [lttng-dev] [PATCH lttng-tools] Remove unused tracepoint in high-throughput test

2014-03-12 Thread David Goulet
Merged! Thanks! David On 12 Mar (17:44:10), Zifei Tong wrote: Signed-off-by: Zifei Tong zifeit...@gmail.com --- tests/regression/ust/high-throughput/tp.h | 5 - 1 file changed, 5 deletions(-) diff --git a/tests/regression/ust/high-throughput/tp.h

Re: [lttng-dev] Working on some bugs

2014-03-11 Thread David Goulet
On 10 Mar (23:00:36), Sandeep K Chaudhary wrote: Hi guys, I want to submit patches for some bugs before making my GSoC application. I was looking at the bug tracker and I think I can work some of these before/during the application. Can you please give some suggestion as to whether I will

Re: [lttng-dev] epoll_wait reboot kernel? [or --disable-epoll causes lttng-sessiond assert]

2014-03-03 Thread David Goulet
On 03 Mar (10:17:11), David OShea wrote: Hi all, Apologies if I'm confusing things, but I think my issue may be related. Please see below: -Original Message- From: zhenyu.ren [mailto:zhenyu@aliyun.com] Sent: Tuesday, 25 February 2014 4:32 PM To: Mathieu Desnoyers Cc:

[lttng-dev] [RELEASE] LTTng-Tools 2.2.6

2014-02-28 Thread David Goulet
Greetings everyone (including LTTng elves), The lttng-tools project provides a session daemon (lttng-sessiond) that acts as a tracing registry, the lttng command line for tracing control, a lttng-ctl library for tracing control and a lttng-relayd for network streaming. This is the last stable

[lttng-dev] [RELEASE] LTTng-Tools 2.3.2

2014-02-28 Thread David Goulet
Greetings everyone (including LTTng elves), The lttng-tools project provides a session daemon (lttng-sessiond) that acts as a tracing registry, the lttng command line for tracing control, a lttng-ctl library for tracing control and a lttng-relayd for network streaming. 2014-02-28 lttng-tools

Re: [lttng-dev] error in generation of trace files

2014-02-27 Thread David Goulet
On 27 Feb (16:36:24), Mariya Rampurawala wrote: Hello, I'm new to lttng. I use ubuntu 13.10. While performing basic operations, on command lttng view, i get the following error. [error] Cannot open any trace for reading. [error] opening trace

Re: [lttng-dev] error in generation of trace files

2014-02-27 Thread David Goulet
/mariya/.lttng/ustconsumerd64/command [in main() at main.c:4019] Error: Already running daemon. On Thu, Feb 27, 2014 at 7:12 PM, David Goulet dgou...@efficios.com wrote: On 27 Feb (16:36:24), Mariya Rampurawala wrote: Hello, I'm new to lttng. I use ubuntu 13.10. While performing

Re: [lttng-dev] [PATCH lttng-tools] Tests fix: Missing waitpid in fork test

2014-02-26 Thread David Goulet
Merged! On 26 Feb (10:56:57), Jérémie Galarneau wrote: Signed-off-by: Jérémie Galarneau jeremie.galarn...@efficios.com --- tests/regression/ust/fork/fork.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/regression/ust/fork/fork.c

[lttng-dev] [UST Pull request] Fix: handle registration done command

2014-02-26 Thread David Goulet
Repo: https://github.com/dgoulet/lttng-ust-dev.git (branch: bug692) This needs to go in lockstep with a commit in lttng-tools so please inform me once pushed so I can update tools. Cheers! David signature.asc Description: Digital signature ___

Re: [lttng-dev] [lttng-tools][Patch] Fix format + PACKAGE_URL for dynamic printing

2014-02-25 Thread David Goulet
Merged! Thanks On 25 Feb (13:04:17), Jonathan Rajotte wrote: --- src/bin/lttng/commands/version.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bin/lttng/commands/version.c b/src/bin/lttng/commands/version.c index bd88659..2b41b05 100644 ---

Re: [lttng-dev] [PATCH lttng-tool] Comments fix: lttngerr.h - error.h (./Changelog:754)

2014-02-24 Thread David Goulet
Merged! Thanks On 23 Feb (19:50:52), Jonathan Rajotte wrote: Signed-off-by: Jonathan Rajotte jonathan.r.jul...@gmail.com --- tests/unit/test_kernel_data.c |2 +- tests/unit/test_session.c |2 +- tests/unit/test_uri.c |2 +-

  1   2   3   4   5   >