Re: [lttng-dev] User-space RCU: call rcu_barrier() before dissociating helper thread?

2021-05-05 Thread Martin Wilck via lttng-dev
Hello Mathieu, thanks again. On Wed, 2021-05-05 at 10:46 -0400, Mathieu Desnoyers wrote: > > > > > > So my understanding is that you implement your own call rcu > > > worker > > > thread because the > > > one provided by liburcu leaks data structure on process exit, and > > > you > > > expect th

Re: [lttng-dev] User-space RCU: call rcu_barrier() before dissociating helper thread?

2021-05-05 Thread Paul E. McKenney via lttng-dev
On Wed, May 05, 2021 at 10:46:58AM -0400, Mathieu Desnoyers wrote: > - On May 5, 2021, at 3:54 AM, Martin Wilck mwi...@suse.com wrote: > > > On Fri, 2021-04-30 at 14:41 -0400, Mathieu Desnoyers wrote: > >> - On Apr 29, 2021, at 9:49 AM, lttng-dev > >> lttng-dev@lists.lttng.org wrote: > >>

Re: [lttng-dev] User-space RCU: call rcu_barrier() before dissociating helper thread?

2021-05-05 Thread Mathieu Desnoyers via lttng-dev
- On May 5, 2021, at 3:54 AM, Martin Wilck mwi...@suse.com wrote: > On Fri, 2021-04-30 at 14:41 -0400, Mathieu Desnoyers wrote: >> - On Apr 29, 2021, at 9:49 AM, lttng-dev >> lttng-dev@lists.lttng.org wrote: >> >> > In multipath-tools, we are using a custom RCU helper thread, which >> > i

Re: [lttng-dev] User-space RCU: call rcu_barrier() before dissociating helper thread?

2021-05-05 Thread Martin Wilck via lttng-dev
On Fri, 2021-04-30 at 14:41 -0400, Mathieu Desnoyers wrote: > - On Apr 29, 2021, at 9:49 AM, lttng-dev > lttng-dev@lists.lttng.org wrote: > > > In multipath-tools, we are using a custom RCU helper thread, which > > is cleaned > > out > > on exit: > > > > https://github.com/opensvc/multipath-

Re: [lttng-dev] User-space RCU: call rcu_barrier() before dissociating helper thread?

2021-04-30 Thread Mathieu Desnoyers via lttng-dev
- On Apr 29, 2021, at 9:49 AM, lttng-dev lttng-dev@lists.lttng.org wrote: > In multipath-tools, we are using a custom RCU helper thread, which is cleaned > out > on exit: > > https://github.com/opensvc/multipath-tools/blob/23a01fa679481ff1144139222fbd2c4c863b78f8/multipathd/main.c#L3058 > >

[lttng-dev] User-space RCU: call rcu_barrier() before dissociating helper thread?

2021-04-29 Thread Martin Wilck via lttng-dev
In multipath-tools, we are using a custom RCU helper thread, which is cleaned out on exit: https://github.com/opensvc/multipath-tools/blob/23a01fa679481ff1144139222fbd2c4c863b78f8/multipathd/main.c#L3058 I put a call to rcu_barrier() there in order to make sure all callbacks had finished before