[lttng-dev] [PATCH lttng-tools stable-2.6] Fix: free ust channel object after grace period in consumer

2016-04-27 Thread Mathieu Desnoyers
[ Backport from master branch commit b83e03c499 "Fix: free metadata cache after grace period in consumer" ] Signed-off-by: Mathieu Desnoyers --- src/common/consumer.c | 11 +++ src/common/ust-consumer/ust-consumer.c | 8

[lttng-dev] lttng-modules 2.6.x: important fix for kernel compatibility check

2016-04-27 Thread Mathieu Desnoyers
Hi, Everyone using lttng-modules from 2.6.1 to 2.6.5 and using moderately recent Linux kernels should consider upgrading to stable-2.7, or at least picking up this commit from the stable-2.6 branch: commit c782f1f3e8c799b7ba531ba940209014b66d4564 Author: Mathieu Desnoyers

Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-27 Thread Paul E. McKenney
Try building without it and see what happens when you run the tests. Might well be that it is unnecessary, but I will defer to Mathieu on that point. Thanx, Paul On Wed, Apr 27, 2016 at 10:18:04PM -0400, Yuxin Ren wrote: > As they don't

Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-27 Thread Yuxin Ren
As they don't currently perform grace period, why do we use the rcu_gp_lock? Thank you. Yuxin On Wed, Apr 27, 2016 at 10:08 PM, Paul E. McKenney wrote: > On Wed, Apr 27, 2016 at 09:34:16PM -0400, Yuxin Ren wrote: >> Hi, >> >> I am learning the URCU code. >> >> Why do

[lttng-dev] [PATCH 3/3] tests/lib: Make test_dwarf and test_bin_info tests work out-of-tree

2016-04-27 Thread Simon Marchi
When building out of tree, these tests fail to find the test data. This patch makes them (their _complete wrappers, actually) generated by Autoconf, so the proper path to the test data (which is in the source directory) can be written. Signed-off-by: Simon Marchi ---

[lttng-dev] [PATCH 2/3] tests/lib/Makefile.am: use DISTCLEANFILES instead of CLEANFILES

2016-04-27 Thread Simon Marchi
Files test_seek_empty_packet and test_seek_big_trace are generated by configuring, not by making. Therefore, we do not want a make clean to remove them. Otherwise, doing... * make * make clean * make * make check ... fails. We want, however, to delete them when doing make distclean.

[lttng-dev] [PATCH 1/3] tests/lib/Makefile.am: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST

2016-04-27 Thread Simon Marchi
Since these files are generated by autoconf, they shouldn't be included in SCRIPT_LIST, which is the list of scripts to copy from the source directory to the build directory. This gets rid of these warnings when building: cp: cannot stat

[lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-27 Thread Yuxin Ren
Hi, I am learning the URCU code. Why do we need rcu_gp_lock in synchronize_rcu? https://github.com/urcu/userspace-rcu/blob/master/urcu.c#L401 In the comment, it says this lock ensures mutual exclusion between threads calling synchronize_rcu(). But only the first thread added to waiter queue can

Re: [lttng-dev] Question about lock in synchronize_rcu implementation of URCU

2016-04-27 Thread Paul E. McKenney
On Wed, Apr 27, 2016 at 09:34:16PM -0400, Yuxin Ren wrote: > Hi, > > I am learning the URCU code. > > Why do we need rcu_gp_lock in synchronize_rcu? > https://github.com/urcu/userspace-rcu/blob/master/urcu.c#L401 > > In the comment, it says this lock ensures mutual exclusion between > threads

Re: [lttng-dev] [PATCH 1/3] tests/lib/Makefile.am: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST

2016-04-27 Thread Simon Marchi
On 2016-04-27 22:52, Simon Marchi wrote: Since these files are generated by autoconf, they shouldn't be included in SCRIPT_LIST, which is the list of scripts to copy from the source directory to the build directory. This gets rid of these warnings when building: cp: cannot stat