[lttng-dev] [PATCH lttng-ust v2 5/6] Rename lttng_ust_enum_get to lttng_ust_enum_get_from_desc

2018-02-09 Thread Francis Deslauriers
Change the prototype to take a descriptor instead of a char *. Now that provider names can have duplicates enum names are not necessarily unique. Signed-off-by: Francis Deslauriers --- include/lttng/ust-events.h | 5 +++--

[lttng-dev] [PATCH lttng-ust v2 2/6] Cleanup: Move version numbers in separate variables in configure script

2018-02-09 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- configure.ac | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index fb2f278..b0b4157 100644 --- a/configure.ac +++ b/configure.ac @@ -20,7 +20,11 @@

[lttng-dev] [PATCH lttng-ust v2 0/6] Support provider duplicates and unloading

2018-02-09 Thread Francis Deslauriers
This patch set adds the support for duplicated probe providers and support for unloading probe providers using dlclose(). It allows to advance scenarios where probe providers can be upgraded during tracing. For example, during tracing the user could dlopen() a new version of a probe provider and

[lttng-dev] [PATCH lttng-ust v2 6/6] Support unloading of probe providers

2018-02-09 Thread Francis Deslauriers
With this commit, it's now possible to dlclose() a library containing an actively used probe provider. The destructor of such library will now iterate over all the sessions and over all probe definitions to unregister them from the respective callsites in the process. Signed-off-by: Francis

[lttng-dev] [PATCH lttng-ust v2 1/6] Remove duplicate provider name checks

2018-02-09 Thread Francis Deslauriers
From: Mathieu Desnoyers It's now possible to register a probe provider with a name that has already been registered. This is useful when wanting to load a new version of a shared library on a already running process. Changes are necessary in the lttng-session

Re: [lttng-dev] [PATCH lttng-ust v2 0/6] Support provider duplicates and unloading

2018-02-09 Thread Mathieu Desnoyers
All merged into lttng-ust master, thanks! Mathieu - On Feb 9, 2018, at 3:15 PM, Francis Deslauriers francis.deslauri...@efficios.com wrote: > This patch set adds the support for duplicated probe providers and > support for unloading probe providers using dlclose(). > > It allows to

Re: [lttng-dev] [PATCH lttng-ust v2 4/6] Manually dlopen() liblttng-ust.so to prevent unloading

2018-02-09 Thread Mathieu Desnoyers
Cleaned up this changelog, which has tabs (should be spaces), and has lines above ~74 columns (which is odd in a git log). Thanks, Mathieu - On Feb 9, 2018, at 3:15 PM, Francis Deslauriers francis.deslauri...@efficios.com wrote: > The support of probe provider dlclose() allows for the

[lttng-dev] [PATCH lttng-tools v2 5/5] Tests: add duplicated providers tests

2018-02-09 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- configure.ac| 1 + tests/fast_regression | 1 + tests/regression/ust/multi-lib/Makefile.am | 114 +++ tests/regression/ust/multi-lib/README

[lttng-dev] [PATCH lttng-tools v2 1/5] Fix: probes should be compared strictly by events metadata

2018-02-09 Thread Francis Deslauriers
Currently, events are compared using names and signatures. Events with different payloads but identical name and signatures could lead to corrupted trace because the Session Daemon would consider them identical and give them the same event ID. Events should be compared using the name, loglevel,

[lttng-dev] [PATCH lttng-tools v2 0/5] Support probes with the same name but different event payload

2018-02-09 Thread Francis Deslauriers
This patch set allows for multiple probes with the same name to be hooked on the same callsite. Right now, the Session Daemon only considers the name and signature of the events to determine if two events are identical. This could lead to trace corruptions when two probes would have the same name

[lttng-dev] [PATCH lttng-tools v2 3/5] Tests: allow the use of regular expressions to match events

2018-02-09 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- tests/utils/utils.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh index e8dfcda..9bf1fcc 100644 --- a/tests/utils/utils.sh +++ b/tests/utils/utils.sh @@

[lttng-dev] [PATCH lttng-tools v2 2/5] Fix: calling ht_{hash, match}_enum with wrong argument

2018-02-09 Thread Francis Deslauriers
ht_hash_enum and ht_match_enum are currently called with the address of the pointer to a ust_registry_enum rather than the expected pointer to a ust_registry_enum. This means that those function calls would end up using garbage for hashing and comparing. Signed-off-by: Francis Deslauriers

[lttng-dev] [PATCH lttng-tools v2 4/5] Tests: add function to validate the number of an event name in metadata

2018-02-09 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- tests/utils/utils.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh index 9bf1fcc..60df376 100644 --- a/tests/utils/utils.sh +++

[lttng-dev] [PATCH lttng-ust v2 4/6] Manually dlopen() liblttng-ust.so to prevent unloading

2018-02-09 Thread Francis Deslauriers
The support of probe provider dlclose() allows for the following problematic scenario: - Application is not linked against the liblttng-ust.so - Application dlopen() a probe provider library that is linked against liblttng-ust.so - Application dlclose() the probe provider In this

[lttng-dev] [LTTNG] Empty traces output file

2018-02-09 Thread Shieryn Tjandra
tracepractice]# lttng list --userspace UST events: - None [root@localhost tracepractice]# lttng create mytrace Session mytrace created. Traces will be written in /root/lttng-traces/mytrace-20180209-013417 [root@localhost tracepractice]# lttng enable-event --userspace