Re: [lttng-dev] Bug in lttng-ust tool lttng-gen-tp which replaces all ".c" with ".h" in the path

Hi, On 09/18/17 18:27, Jonathan Rajotte-Julien wrote: Hi, On Mon, Sep 18, 2017 at 11:47:28AM +0200, Gunnar Strand wrote: Hi, It does not seem like anonymous bug reporting is supported, so I am submitting the report here instead. I found the following bug in the tools/lttng-gen-tp tool in

[lttng-dev] [RFC PATCH v2 06/13] Fix: unregister app notify socket on sessiond tear down

A race between the sessiond tear down and applications initialization can lead to a deadlock. Applications try to communicate via the notify sockets while sessiond does not listen anymore on these sockets since the thread responsible for reception/response is terminated

[lttng-dev] [RFC PATCH v2 00/13] Sessiond teardown overhaul

Hi, This series objective is to review how the sessiond teardown is conducted. This is the result of stress testing the teardown code path using [1] and the discussion following previous proposed fixes [2][3]. The main problematic is that applications could hang on application-initiated

[lttng-dev] [RFC PATCH v2 13/13] Fix: quit early if instructed to

If the wait_queue size is considerable, not checking if the thread should quit delays the termination (3+ seconds during stress testing). Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[lttng-dev] [RFC PATCH v2 10/13] Teardown apps_notify_thread before thread_manage_apps

RFC: This is necessary since we use the ust_app_ht_by_notify_sock to perform the cleanup operation. Since both ust_app_unregister and ust_app_ust_app_notify_unregister perform a remove of the app on the ust_ust_app_by_notify_sock but only ust_app_notify_unregister actually end up performing a

[lttng-dev] [RFC PATCH v2 12/13] Fix: delay termination on consumerd to allow metadata flushing

Move consumerd ownership to thread_manage_consumer to scope the lifetime on the consumerd to its manager thread. "thread_manage_consumer" is responsible for signaling and waiting the termination of its consumerd. All thread_manage_consumer threads now wait on a unique quit pipe different from

[lttng-dev] [RFC PATCH v2 07/13] Always reply to an inquiring app

Reply to the app on errors to prevent an app-side receive hang. Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/ust-app.c | 64 ++-- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git

[lttng-dev] [RFC PATCH v2 11/13] Comments update

Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index 216d0da6..a840e8de 100644 ---

[lttng-dev] [RFC PATCH v2 09/13] Perform ust_app_unregister on thread_manage_apps teardown

Previous work on thread termination ordering permits the dismissal of the following comment: We don't clean the UST app hash table here since already registered applications can still be controlled so let them be until the session daemon dies or the applications stop. At the moment of

[lttng-dev] [RFC PATCH v2 08/13] Fix: perform lookup then test for condition

Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/main.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index 3596d7e3..8cffa6f6 100644 ---

[lttng-dev] [RFC PATCH v2 05/13] Control thread_apps_notify lifetime with specialized quit pipe

Listen to application longer and quit only when most other thread are terterminated. This simplifies data interaction with other threads. Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/lttng-sessiond.h | 2 ++ src/bin/lttng-sessiond/main.c

[lttng-dev] [RFC PATCH v2 02/13] Reorder pthread_join for easier ordering later on

Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/main.c | 96 --- 1 file changed, 45 insertions(+), 51 deletions(-) diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index

[lttng-dev] [RFC PATCH v2 03/13] Terminate dispatch thread after reg_apps_thread is terminated

Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index 45c0270e..0ca72ec8 100644 ---

[lttng-dev] [RFC PATCH v2 04/13] Order termination of thread_manage_apps after dispatch_thread

This ensure that no registration are ongoing when thread_manage_apps perform it's cleanup and termination. Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/main.c | 46 +-- 1 file changed, 40 insertions(+),

[lttng-dev] [RFC PATCH v2 01/13] Extend health thread lifetime

Allow easier control over the thread by providing a dedicated quit pipe. Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/main.c | 74 --- 1 file changed, 55 insertions(+), 19 deletions(-) diff --git

[lttng-dev] [RELEASE] Babeltrace 2.0.0-pre4

Hi everyone! We are happy to announce the release of Babeltrace 2.0.0-pre4. What's new since pre3? -- * Project-wide: * Lots of fixes in all the project's modules (Python bindings, library, CLI, plugins, tests, build system). * Continued efforts to port Babeltrace

Re: [lttng-dev] [PATCH babeltrace] Fix: ctf writer tests were moved to test_python_babeltrace

Fixed by: commit e9e36a3889cd30d2bc1a193fd87fbc0535109972 Author: Jérémie Galarneau Date: Mon Sep 18 17:15:49 2017 -0400 Tests: moved files pointed-to in Makefile Signed-off-by: Jérémie Galarneau Thanks! Jérémie On 18

Re: [lttng-dev] [PATCH lttng-tools] Fix: lost packet accounting always lost on snapshot

This was merged a while ago, but it seems I never sent an acknowledgement. Thanks! Jérémie On 25 July 2017 at 15:23, Julien Desfossez wrote: > Because of the continue when we fail to get a subbuff, the lost_packet > count is always reset to 0 before we can account it in

[lttng-dev] [PATCH babeltrace] Fix: use the configured swig executable

Signed-off-by: Michael Jeanson --- bindings/python/bt2/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bindings/python/bt2/Makefile.am b/bindings/python/bt2/Makefile.am index fe1c83b..9474ebb 100644 --- a/bindings/python/bt2/Makefile.am +++

[lttng-dev] [PATCH babeltrace] Fix: ctf writer tests were moved to test_python_babeltrace

Signed-off-by: Michael Jeanson --- tests/Makefile.am | 6 -- 1 file changed, 6 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index f9c207f..ee0d706 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -38,12 +38,6 @@ TESTS_LIB = \

Re: [lttng-dev] Bug in lttng-ust tool lttng-gen-tp which replaces all ".c" with ".h" in the path

Hi, On Mon, Sep 18, 2017 at 11:47:28AM +0200, Gunnar Strand wrote: > Hi, > > It does not seem like anonymous bug reporting is supported, so I am > submitting the report here instead. > > I found the following bug in the tools/lttng-gen-tp tool in the lttng-ust > component, which is present in

Re: [lttng-dev] Babeltrace performance issue in live-reading mode

Hi, On Mon, Sep 18, 2017 at 11:32:07AM +0800, liguang li wrote: >Hi, > >Create a session in live-reading mode, run a application which having very >high event throughput, then prints >the events with babeltrace. We found the live trace viewer are viewing >events a few seconds

[lttng-dev] Babeltrace performance issue in live-reading mode

Hi, Create a session in live-reading mode, run a application which having very high event throughput, then prints the events with babeltrace. We found the live trace viewer are viewing events a few seconds ago, and as time goes on, the delay will be bigger and bigger. I checked the source code,

Re: [lttng-dev] babeltrace tests (master/2.0)

Philippe Proulx writes: > On Fri, Sep 15, 2017 at 3:53 PM, Nathan Lynch wrote: >> Nathan Lynch writes: >>> Philippe Proulx writes: I asked the Automake mailing list about this

[lttng-dev] Bug in lttng-ust tool lttng-gen-tp which replaces all ".c" with ".h" in the path

Hi, It does not seem like anonymous bug reporting is supported, so I am submitting the report here instead. I found the following bug in the tools/lttng-gen-tp tool in the lttng-ust component, which is present in the latest commit on master, d0f6cf574ef992620b09c183cb3a0ea771070ea5:  66