[lttng-dev] Can liburcu protect multiple independent shared resource?

2018-04-10 Thread 志昌 余
According to https://github.com/urcu/userspace-rcu/blob/master/doc/rcu-api.md, none librcu API take the resource address. If there're multiple independent shared resource, seems there's interference between read_lock of resource A and write_lock of resource B. _

Re: [lttng-dev] Can liburcu protect multiple independent shared resource?

2018-04-10 Thread Mathieu Desnoyers
Hi, There is no "write_lock" in RCU per se. The update side uses a synchronize_rcu() instead. Yes, there can be interference between multiple shared resources using the same liburcu flavor. Very long read-side critical sections can delay completion of synchronize_rcu. I've done prototypes

[lttng-dev] [PATCH lttng-tools] Fix: Hold consumer socket lock for consumer_send_msg

2018-04-10 Thread Jonathan Rajotte
The lock is held and released during the recv section but not during the send section for a failure to lookup the PID registry. Signed-off-by: Jonathan Rajotte --- src/bin/lttng-sessiond/ust-consumer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/bin/lttng-sessiond/ust-consumer.c b

Re: [lttng-dev] [PATCH lttng-tools] Fix: Hold consumer socket lock for consumer_send_msg

2018-04-10 Thread Jérémie Galarneau
Merged in master, stable-2.10, and stable-2.9. Thanks! Jérémie On Tue, Apr 10, 2018 at 01:56:47PM -0400, Jonathan Rajotte wrote: > The lock is held and released during the recv section but not > during the send section for a failure to lookup the PID registry. > > Signed-off-by: Jonathan Rajotte

[lttng-dev] [PATCH lttng-tools] Fix: null pointer dereference

2018-04-10 Thread Jonathan Rajotte
Signed-off-by: Jonathan Rajotte --- src/lib/lttng-ctl/rotate.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/lib/lttng-ctl/rotate.c b/src/lib/lttng-ctl/rotate.c index bdce8d8..e340429 100644 --- a/src/lib/lttng-ctl/rotate.c +++ b/src/lib/lttng-ctl/rotate.c @@ -268

Re: [lttng-dev] [PATCH lttng-tools] Fix: null pointer dereference

2018-04-10 Thread Jérémie Galarneau
Merged in master, thanks! Jérémie On Tue, Apr 10, 2018 at 04:33:32PM -0400, Jonathan Rajotte wrote: > Signed-off-by: Jonathan Rajotte > --- > src/lib/lttng-ctl/rotate.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/lib/lttng-ctl/rotate.c b/src/lib/lttng-ct