Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-23 Thread PCMan
On Thu, Jun 23, 2011 at 11:28 PM, Jonathan Marsden wrote: >>> (3) A couple of source files seem to lack a copyright and licence >>> statement: > >>>   src/xml-purge.c: *No copyright* UNKNOWN > >>>   autogen.sh: *No copyright* UNKNOWN > > >>> (4) One has a rather different copyright, and a license

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-23 Thread Jonathan Marsden
>> (3) A couple of source files seem to lack a copyright and licence >> statement: >> src/xml-purge.c: *No copyright* UNKNOWN >> autogen.sh: *No copyright* UNKNOWN >> (4) One has a rather different copyright, and a license statement that >> needs fixing: >> src/gseal-gtk-compat.h: LGPL (

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-23 Thread Martin Bagge / brother
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2011-06-18 09:53, Jonathan Marsden wrote: > (1) Copyright statements generally say 2009-2010, and it is now 2011. Probably due to no release in 2011. > (2) The translatable one that shows in the About dialog box also does > this, so this may be

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Phill Whiteside
Gee, Goes to show how rusty I am when it comes down to testing!. As Jonathan knows (Thanks loads for helping me get my 'head round' VM's), I have finally gotten my Virtual Box up and running. Currently has 11-04 and 11-10 available. From discussions with JM, I have allocated 250GB of disk space f

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Julien Lavergne
Le Sunday 19 June 2011 à 06:27 -0700, Jonathan Marsden a écrit : > On 06/18/2011 10:07 PM, PCMan wrote: > > >> Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher: > > > We do not translate desktop files directly. Neither do we commit the > > translated desktop files. Most like

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Jonathan Marsden
On 06/19/2011 03:57 AM, Julien Lavergne wrote: > Could we push them to a shared PPA, like lubuntu-dev/lubuntu-daily ? Done :) Jonathan ___ Mailing list: https://launchpad.net/~lubuntu-desktop Post to : lubuntu-desktop@lists.launchpad.net Unsubsc

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Jonathan Marsden
On 06/18/2011 10:07 PM, PCMan wrote: >> Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher: > We do not translate desktop files directly. Neither do we commit the > translated desktop files. OK... then this patch is not needed upstream. I'm not sure why it was done this way

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Lance
but I may be tied up with this mess for a while. --- On Sun, 6/19/11, Julien Lavergne wrote: From: Julien Lavergne Subject: Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release. To: "Jonathan Marsden" Cc: "Lance" , lubuntu-desktop@lists.launchp

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Julien Lavergne
Le Saturday 18 June 2011 à 21:31 -0700, Jonathan Marsden a écrit : > Option (2) happened, or is happening. > > My PPA at ppa:jmarsden/lubuntu now has libfm and pcmanfm versions for > Natty 11.04, packages that you can help us test. They are being built > from the upstream git development source c

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Martin Bagge / brother
On Sun, 19 Jun 2011, PCMan wrote: Cons: 1. If some newly added po files are broken, this automatically breaks the build process. I see this as a pro rather than a con. I do builds of git HEAD within 120 minutes after a change enters the master branch (during my wokring hours and when I am no

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-18 Thread PCMan
On Sun, Jun 19, 2011 at 1:07 PM, PCMan wrote: > Thank you for the patches. I took some time to look at them and found > some issues. > >    jmarsden committed 1963619 >    Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher: Regarding to the LINGUAS file, we have a special issue

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-18 Thread PCMan
Thank you for the patches. I took some time to look at them and found some issues. jmarsden committed 1963619 Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher: We do not translate desktop files directly. Neither do we commit the translated desktop files. We did the tr

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-18 Thread Jonathan Marsden
Lance, On 06/13/2011 10:59 PM, Jonathan Marsden wrote: > ... you have two > options if you want a package of the current libfm and pcmanfm code: > (1) go ahead and package it now, yourself, in your own PPA, or > (2) wait for someone else to package it. Option (2) happened, or is happening.

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-18 Thread Jonathan Marsden
On 06/18/2011 12:53 AM, Jonathan Marsden wrote: > On 06/13/2011 10:12 AM, PCMan wrote: >> https://sourceforge.net/tracker/?group_id=156956&atid=801864 I think we might also want to go through the bugs reported at https://bugs.launchpad.net/ubuntu/+source/pcmanfm since some of these look li

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-18 Thread Jonathan Marsden
So, what is missing for having a stable release of pcmanfm ? Any major features are still missing ? On 06/13/2011 10:12 AM, PCMan wrote: > https://sourceforge.net/tracker/?group_id=156956&atid=801864 > I give the bugs different priority. The ones with highest priority > should be fixe

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-15 Thread Jonathan Marsden
On 06/14/2011 03:17 PM, Julien Lavergne wrote: >> I'm playing with writing a script to grab the libfm git head and >> Julien's package and automatically create a new package based on the >> combination of the two. ... > If you want to spend more time on this, you should look at recipes on > Laun

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-14 Thread Julien Lavergne
Le Monday 13 June 2011 à 22:05 -0700, Jonathan Marsden a écrit : > > I'm playing with writing a script to grab the libfm git head and > Julien's package and automatically create a new package based on the > combination of the two. It doesn't quite work yet... if it does, I'll > try to do the same

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Jonathan Marsden
Lance, On 06/11/2011 01:55 PM, Lance wrote: > As a complete noob to Lubuntu (moving from Ubuntu/Gnome) I wonder if > it would be possible to test this via a PPA before committing to a > change for Oneiric. Yes, it is possible :) By definition, a new upstream release of pcmanfm will need to be

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Jonathan Marsden
On Tue, 14 Jun 2011 01:12:06 +0800 PCMan wrote: > https://sourceforge.net/tracker/?group_id=156956&atid=801864 OK, thanks, that's good to know. >> SUGGESTION: Let's test the current "almost-0.9.9" codebase, fix any >> major issues found in the next week or so, then bump the SONAME version >> an

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread PCMan
On Mon, Jun 13, 2011 at 11:48 PM, Jonathan Marsden wrote: > On 06/13/2011 07:11 AM, Martin Bagge / brother wrote: > >> On 2011-06-13 14:27, Julien Lavergne wrote: > >>> So, what is missing for having a stable release of pcmanfm ? Any >>> major features are still missing ? > > This is a key questio

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Chris
Aloha oukou, > >> Last official release is 2010-10-14 ... > > Which is both fairly old, and also "bad timing" regarding Ubuntu > releases, being only about two weeks before the Ubuntu 10.10 final release. > That was 4 days AFTER the Ubuntu 10.10 release. But if you want to get something in L/Ubu

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Jonathan Marsden
On 06/13/2011 07:11 AM, Martin Bagge / brother wrote: > On 2011-06-13 14:27, Julien Lavergne wrote: >> So, what is missing for having a stable release of pcmanfm ? Any >> major features are still missing ? This is a key question for Lubuntu right now. > Using git HEAD as source for a package in

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Julien Lavergne
Le Monday 13 June 2011 à 19:17 +0800, PCMan a écrit : > > - Please bump the soname of your library each time you change your API. > > Distributions can do smooth transitions between versions of > > libfm/pcmanfm. Also, if you expect other applications to use libfm, you > > need to use the soname. >

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread PCMan
On Mon, Jun 13, 2011 at 6:34 PM, Julien Lavergne wrote: > Le Sunday 12 June 2011 à 01:21 +0800, PCMan a écrit : >> >> A new release as 0.9.9 is required. Please help review and test the code in >> git. >> Thanks a lot. > > Thanks PCMan. So far, It's working nice on L/Ubuntu 10.10. > > Some commen

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Julien Lavergne
Le Sunday 12 June 2011 à 01:21 +0800, PCMan a écrit : > > A new release as 0.9.9 is required. Please help review and test the code in > git. > Thanks a lot. Thanks PCMan. So far, It's working nice on L/Ubuntu 10.10. Some comments : - Please bump the soname of your library each time you change y

Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-11 Thread Lance
From: PCMan Subject: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release. To: "lxde-list" , "pcmanfm-develop" , "lubuntu-desktop" , lxde-i...@lists.sourceforge.net Date: Saturday, June 11, 2011, 12:21 PM Hi all, I'm here to call for a re

[Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-11 Thread PCMan
Hi all, I'm here to call for a review for PCManFM as the source code in git is in quite good shape now. Many known bugs are fixed and I did much refactor to the tabbed browsing part and merge changes in tab-rework3 branch with master. Please help test and update translations in various distros. If