Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-23 Thread PCMan
On Thu, Jun 23, 2011 at 11:28 PM, Jonathan Marsden jmars...@fastmail.fm wrote:
 (3) A couple of source files seem to lack a copyright and licence
 statement:

   src/xml-purge.c: *No copyright* UNKNOWN

   autogen.sh: *No copyright* UNKNOWN


 (4) One has a rather different copyright, and a license statement that
 needs fixing:
   src/gseal-gtk-compat.h: LGPL (with incorrect FSF address)

Is it possible to make it GPL? I forgot who added this file.

 On 06/23/2011 06:06 AM, Martin Bagge / brother wrote:

 For debian this is RC and will possibly prevent pcmanfm from being
 included in the stable release.


 Well, it appears to have been there for a while, both the xml-purge.c
 one and then gseal-gtk-compat.h ones are there in the Debian pcmanfm
 0.98-1 packages that are in wheezy, and in the 0.97-1 packages that are
 in squeeze, which *is* Debian stable.

 If was OK when squeeze was released, why is it RC now?

 Anyway: we can fix (4) by editing debian/copyright to state the
 copyright info for that one file.

 Adding a copyright to autogen.sh is something PCMan would need to do,
 since he wrote it (I presume).

I forgot who wrote it, but IIRC, Marty Jack did it long time ago.
Later all lxde components use that copy, with some individualized
modifications.

 I do not know how to fix the lack of copyright and licence in
 xml-purge.c, because I have no idea who wrote it.  If PCman did, then he
 can add a licence and copyright notice to it, too.
I did it long time ago.

 AUTOMATED PACKAGE BUILDS:


 I have made good progress with this, and expect there will be test
 packages automatically showing up in my ppa:jmarsden/lubuntu in a few

 I have been working on getting better shape of the server that hosts the
 buildbot. I was thinking about adding a auto export at the end of each
 successful build. The plan is also to get the code tree updates to
 trigger builds (I do them by hand at the moment).

 Sounds good.  Right now my automated pcmanfm package builds for Ubuntu
 are apparently working OK, see ppa:lubuntu-dev/lubuntu-daily i.e.
 https://code.launchpad.net/~lubuntu-dev/+archive/lubuntu-daily

 Jonathan


___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Martin Bagge / brother

On Sun, 19 Jun 2011, PCMan wrote:


Cons:
1. If some newly added po files are broken, this automatically breaks
the build process.


I see this as a pro rather than a con. I do builds of git HEAD within 120 
minutes after a change enters the master branch (during my wokring hours 
and when I am not away ofc). This is intended to be more automated but I 
haven't really seen the absolute need.
As I am almost always part of adding new PO files I blame myself and fixes 
the issues when I see them.



2. Some translation with bad quality becomes available before they're
well-tested.


This is always a problem and can also be part of long standing 
translations that don't get proper reviews and such.



Current approach is very convenient, but later proven to be
problematic sometimes if there are some broken po files added to the
repo. So, should we change it? If we do change it, I hope that our
translation coordinator can help maintain the LINGUAS files for all
LXDE components to keep them up to date.
Any comments?


I rather not maitain a LINGUAS file. It was a PITA when we did that back 
then. Some benefits but more administration.


--
/brother
http://martin.bagge.nu
Bruce Schneier once killed a man using only linear cryptanalysis.

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Julien Lavergne
Le Saturday 18 June 2011 à 21:31 -0700, Jonathan Marsden a écrit :
 Option (2) happened, or is happening.
 
 My PPA at ppa:jmarsden/lubuntu now has libfm and pcmanfm versions for
 Natty 11.04, packages that you can help us test.  They are being built
 from the upstream git development source code.  Right now, the amd64
 versions are already there, and the i386 build of pcmanfm should
 arrive
 in a couple of hours.  So
 
   sudo add-apt-repository ppa:jmarsden/lubuntu
   sudo apt-get update
   sudo apt-get install pcmanfm
 
 should get you a packaged pcmanfm you can test.
 
 Jonathan 

Could we push them to a shared PPA, like lubuntu-dev/lubuntu-daily ?
I'll will set up the rest of lxde components to have fully daily build
fo LXDE.

Regards,
Julien Lavergne


___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Lance
@ Jonathan and Julien,

This sounds great. I'll try to check this out in the next couple of days:

https://launchpad.net/~jmarsden/+archive/lubuntu

A shared PPA, like lubuntu-dev/lubuntu-daily sounds like a great idea.

I'm moving my home office ATM, LAN wiring is complete, but I may be tied up 
with this mess for a while.


--- On Sun, 6/19/11, Julien Lavergne gi...@ubuntu.com wrote:

From: Julien Lavergne gi...@ubuntu.com
Subject: Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a 
new release.
To: Jonathan Marsden jmars...@fastmail.fm
Cc: Lance lbsol...@yahoo.com, lubuntu-desktop@lists.launchpad.net
Date: Sunday, June 19, 2011, 5:57 AM

Le Saturday 18 June 2011 à 21:31 -0700, Jonathan Marsden a écrit :
 Option (2) happened, or is happening.
 
 My PPA at ppa:jmarsden/lubuntu now has libfm and pcmanfm versions for
 Natty 11.04, packages that you can help us test.  They are being built
 from the upstream git development source code.  Right now, the amd64
 versions are already there, and the i386 build of pcmanfm should
 arrive
 in a couple of hours.  So
 
   sudo add-apt-repository ppa:jmarsden/lubuntu
   sudo apt-get update
   sudo apt-get install pcmanfm
 
 should get you a packaged pcmanfm you can test.
 
 Jonathan 

Could we push them to a shared PPA, like lubuntu-dev/lubuntu-daily ?
I'll will set up the rest of lxde components to have fully daily build
fo LXDE.

Regards,
Julien Lavergne

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Jonathan Marsden
On 06/18/2011 10:07 PM, PCMan wrote:

 Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher:
 
 We do not translate desktop files directly. Neither do we commit the
 translated desktop files.


OK... then this patch is not needed upstream.  I'm not sure why it was
done this way as a patch in the Debian packaging, in that case.  Perhaps
a historical artifact?

 We did the translation for desktop files in po files, and only put
 *.desktop.in files in git.


I think I see what could have happened here; the package build process
was not running all the autoconf tools the way autogen.sh does, and so
it tried to work around that.  I have very recently created some changed
packaging files in lp:~lxde/pcmanfm/libfm-packaging which *do* run all
the needed autoconf and intltoolize stuff, and that seems to work
without the translated files being in the tree, because it generates
them at build time.

 Ensure correct icon is used in panel.

 A better fix is to set the icon-name property for the window in
 GtkBuilder glade file instead.


OK.  I am more of a command-line person than a GUI programmer, the GTK
UI stuff is relatively new to me.  As I recall, I fixed the bug in the
way Julien suggested it be fixed.  There were several similar issues
with icon names not being set in various LXDE-related tools.  I fixed
them all in a similar way to this, and those patches were accepted by
Julien into the Ubuntu packaging.  I can redo this in glade if that is
the correct approach.  I'm not really sure I understand the benefit of
moving one line from code into a glade file, though.

 Add GLIB_LIBS when linking documentation.


 This seems to be fine, but I'm not sure which files should be pushed
 to git repo since some are generated files.


This commit should have added exactly one line to exactly one file:

  docs/reference/libfm/Makefile.am

The debian/patches/04_fix_docs_linker.patch file it was based on only
affects that one line.  If the commit did more than that, that was a
mistake I made!  As far as I can tell, it only changed that one line, see


https://gitorious.org/lxde-jmarsden/libfm-jmarsden/commit/284a1640d146b7bc6483ebb0b02058a78e91

I *think* you should have been able to git cherrypick this commit
directly into your master git repository, where it should have changed
just that one file; that was my intention, at least.  If that didn't
work, then we should probably try to figure out why, so that we can do
this kind of cooperation more smoothly next time.

 Disable deprecated gio code by default.


 This looks fine, but will this affect distros with older versions of glib?


Possibly, I'm not sure.  However, are new releases of pcmanfm intended
for backporting to those older distros?  I'm not sure this is an issue
in practice for a new pcmanfm/libfm release, unless current development
releases of major distros (Fedora, SuSE, Debian, ...) are still using
older glib versions.

 Specify default terminal emulator (was: 01-lxde-conf.patch in Ubuntu


 The x-terminal-emulator thing IIRC is Debian-specific. So this better
 goes to debian package rather than upstream.


OK, then yes, that should stay as a patch, in Debian/Ubuntu packaging.

I'd definitely like to see the GLIB_LIBS change included upstream, as (I
think) it will allow me to re-enable gtk-doc use in my test packages
made from the libfm git sources.  Removing the deprecated gio code would
also be good to see, too, unless it will cause issues building libfm on
other current distributions.

I'll take a look at the glade change idea for the icon, but not this
weekend.

Jonathan

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Jonathan Marsden
On 06/19/2011 03:57 AM, Julien Lavergne wrote:

 Could we push them to a shared PPA, like lubuntu-dev/lubuntu-daily ?


Done :)

Jonathan


___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-19 Thread Phill Whiteside
Gee,

Goes to show how rusty I am when it comes down to testing!.

As Jonathan knows (Thanks loads for helping me get my 'head round' VM's), I
have finally gotten my Virtual Box up and running. Currently has 11-04 and
11-10 available. From discussions with JM, I have allocated 250GB of disk
space for Virtual Machines so have plenty of room for additional ones.

The other 250GB of that drive is not being used, come the point of wanting
to test 'real life', then I will happily put on full installs onto that
area.

Please feel more than welcome to give me a set of instructions if anyone
wants things testing out.

Regards,

Phill.
P.S. I tried to think of a funky new name for IRC for when both main and
virtual machines are running. I got as far as phillw-virtual :)

On Sun, Jun 19, 2011 at 3:17 PM, Julien Lavergne gi...@ubuntu.com wrote:

 Le Sunday 19 June 2011 à 06:27 -0700, Jonathan Marsden a écrit :
  On 06/18/2011 10:07 PM, PCMan wrote:
 
   Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher:
 
   We do not translate desktop files directly. Neither do we commit the
   translated desktop files.
 Most likely a quick and dirty patch on Ubuntu packaging for the .desktop
 part :)

 
   Ensure correct icon is used in panel.
 
   A better fix is to set the icon-name property for the window in
   GtkBuilder glade file instead.
 
 
  OK.  I am more of a command-line person than a GUI programmer, the GTK
  UI stuff is relatively new to me.  As I recall, I fixed the bug in the
  way Julien suggested it be fixed.  There were several similar issues
  with icon names not being set in various LXDE-related tools.  I fixed
  them all in a similar way to this, and those patches were accepted by
  Julien into the Ubuntu packaging.  I can redo this in glade if that is
  the correct approach.  I'm not really sure I understand the benefit of
  moving one line from code into a glade file, though.
 Yes, it makes sense to keep all the UI magic in the glade/ui file. I
 wasn't aware that it can be done like this.


   Disable deprecated gio code by default.
 
 
   This looks fine, but will this affect distros with older versions of
 glib?
 
 
  Possibly, I'm not sure.  However, are new releases of pcmanfm intended
  for backporting to those older distros?  I'm not sure this is an issue
  in practice for a new pcmanfm/libfm release, unless current development
  releases of major distros (Fedora, SuSE, Debian, ...) are still using
  older glib versions.
 As far as I know, this flag just makes the build fail when a deprecated
 code is detected. It doesn't affect the code itself or the behavior of
 the program.

 Regards,
 Julien Lavergne



 ___
 Mailing list: https://launchpad.net/~lubuntu-desktop
 Post to : lubuntu-desktop@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~lubuntu-desktop
 More help   : https://help.launchpad.net/ListHelp




-- 
https://wiki.ubuntu.com/phillw
___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-18 Thread Jonathan Marsden
On 06/18/2011 12:53 AM, Jonathan Marsden wrote:

 On 06/13/2011 10:12 AM, PCMan wrote:
 
 https://sourceforge.net/tracker/?group_id=156956atid=801864


I think we might also want to go through the bugs reported at

  https://bugs.launchpad.net/ubuntu/+source/pcmanfm

since some of these look like pcmanfm crashes if you do *this* type of
bugs, which IMO are important to fix, if they can be reproduced.

Jonathan

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-18 Thread Jonathan Marsden
Lance,

On 06/13/2011 10:59 PM, Jonathan Marsden wrote:

 ... you have two
 options if you want a package of the current libfm and pcmanfm code:

  (1) go ahead and package it now, yourself, in your own PPA, or
  (2) wait for someone else to package it.


Option (2) happened, or is happening.

My PPA at ppa:jmarsden/lubuntu now has libfm and pcmanfm versions for
Natty 11.04, packages that you can help us test.  They are being built
from the upstream git development source code.  Right now, the amd64
versions are already there, and the i386 build of pcmanfm should arrive
in a couple of hours.  So

  sudo add-apt-repository ppa:jmarsden/lubuntu
  sudo apt-get update
  sudo apt-get install pcmanfm

should get you a packaged pcmanfm you can test.

Jonathan

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-18 Thread PCMan
Thank you for the patches. I took some time to look at them and found
some issues.

jmarsden committed 1963619
Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher:

We do not translate desktop files directly. Neither do we commit the
translated desktop files.
We did the translation for desktop files in po files, and only put
*.desktop.in files in git.
So the translation should go to *.po, and merged with *.desktop.in
during build process.

jmarsden committed 530ac5a
Ensure correct icon is used in panel.
A better fix is to set the icon-name property for the window in
GtkBuilder glade file instead.
We generally avoid building dialog UI in source code and tend to use
GtkBuilder instead when applicable.

jmarsden committed 284a164
Add GLIB_LIBS when linking documentation.
This seems to be fine, but I'm not sure which files should be pushed
to git repo since some are generated files.

jmarsden committed b61f3d6
Disable deprecated gio code by default.
This looks fine, but will this affect distros with older versions of glib?

jmarsden committed 618594e
API change deprecating fmpath_new
This one looks fine.

jmarsden committed 09b6061
Specify default terminal emulator (was: 01-lxde-conf.patch in Ubuntu
The x-terminal-emulator thing IIRC is Debian-specific. So this better
goes to debian package rather than upstream.

On Tue, Jun 14, 2011 at 1:05 PM, Jonathan Marsden jmars...@fastmail.fm wrote:
 On Tue, 14 Jun 2011 01:12:06 +0800 PCMan pcman...@gmail.com wrote:

 https://sourceforge.net/tracker/?group_id=156956atid=801864

 OK, thanks, that's good to know.

 SUGGESTION: Let's test the current almost-0.9.9 codebase, fix any
 major issues found in the next week or so, then bump the SONAME version
 and release it before the end of June 2011.  Can we do that?

 Yes, if with help from the community. No if I do it myself.
 Patches from Lubuntu is appreciated.

 Since you mentioned it:

 I *already* turned  libfm patches from Julien's Ubuntu package of
 libfm into a git repo for you, six commits, and posted about doing
 that to this list.  All that was left for you to do was to cherrypick
 which ones you want to include in the upstream sources:

  https://lists.launchpad.net/lubuntu-desktop/msg03977.html

 As far as I can see, *none* of them have been included so far!  Either I did
 something wrong, or else you don't really want those patches?  Help me
 understand what I have to do so you will accept the commits I made for you 
 from
 Ubuntu patches, please.

 Since some testers seem to need packaged versions to test, I'll look at
 creating a test unofficial package from git for them, so we get slightly
 more testing.  Another way to go would be to release a 0.9.9~rc1
 tarball, and a corresponding one for libfm, if that is preferred --
 doing that means noone has to use git head for packaging :)

 That's true.

 I'm playing with writing a script to grab the libfm git head and
 Julien's package and automatically create a new package based on the
 combination of the two.  It doesn't quite work yet... if it does, I'll
 try to do the same for pcmanfm, and then we can create test packages for
 pcmanfm testers much more easily :)

 Jonathan


___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-18 Thread PCMan
On Sun, Jun 19, 2011 at 1:07 PM, PCMan pcman...@gmail.com wrote:
 Thank you for the patches. I took some time to look at them and found
 some issues.

    jmarsden committed 1963619
    Add LINGUAS, reference doc files and libfm-pref-apps.desktop launcher:

Regarding to the LINGUAS file, we have a special issue here.
In the past, we ship LINGUAS file with the packages. After we
introduced online tranlation systems, I changed this part and have the
configure script scan the po dir, and build the LINGUAS file
on-the-fly. So each time a new language is added from the translation
systems, nobody needs to edit the LINGUAS file.

Pros:
1. Nobody needs to maintain LINGUAS file.
2. Everytime a new language is added, it's immediately available and
will be picked up automatically by the build process so users can test
the translations immediately.
3. XFCE, AFAIK, seems to use similar approach

Cons:
1. If some newly added po files are broken, this automatically breaks
the build process.
2. Some translation with bad quality becomes available before they're
well-tested.

Current approach is very convenient, but later proven to be
problematic sometimes if there are some broken po files added to the
repo. So, should we change it? If we do change it, I hope that our
translation coordinator can help maintain the LINGUAS files for all
LXDE components to keep them up to date.
Any comments?

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-15 Thread Jonathan Marsden
On 06/14/2011 03:17 PM, Julien Lavergne wrote:

 I'm playing with writing a script to grab the libfm git head and
 Julien's package and automatically create a new package based on the
 combination of the two.  ...

 If you want to spend more time on this, you should look at recipes on
 Launchpad.

Ah... thanks.  I didn't know recipes could use git, I've done one for
daily builds that uses bzr... I'll take a look.  It may be Friday or
Saturday before I can spend more time on this, though.

Jonathan

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-14 Thread Jonathan Marsden
Lance,

On 06/11/2011 01:55 PM, Lance wrote:

 As a complete noob to Lubuntu (moving from Ubuntu/Gnome) I wonder if 
 it would be possible to test this via a PPA before committing to a 
 change for Oneiric.

Yes, it is possible :)

By definition, a new upstream release of pcmanfm will need to be
packaged before it can appear in a PPA or in Oneiric.  So you have two
options if you want a package of the current libfm and pcmanfm code:

 (1) go ahead and package it now, yourself, in your own PPA, or

 (2) wait for someone else to package it.

Right now, as far as I know, no-one has done that work, so this new code
is currently only available from git, for those comfortable compiling
and installing it directly from sources.

Once things settle down slightly, it will be packaged.  I may have a
quick go at packaging libfm and pcmanfm from their respective git trees
somewhere in the couple of days, but no promises :)  I don't have much
time available for doing this right now, unfortunately.

Jonathan

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-14 Thread Julien Lavergne
Le Monday 13 June 2011 à 22:05 -0700, Jonathan Marsden a écrit :
 
 I'm playing with writing a script to grab the libfm git head and
 Julien's package and automatically create a new package based on the
 combination of the two.  It doesn't quite work yet... if it does, I'll
 try to do the same for pcmanfm, and then we can create test packages
 for
 pcmanfm testers much more easily :) 
If you want to spend more time on this, you should look at recipes on
Launchpad. It's easy to import git branch and enable building packages
automatically in a PPA. In fact, it's possible to enable daily builds
for most Ubuntu releases, and for all LXDE components with no human
intervention.

Regards,
Julien Lavergne




___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Julien Lavergne
Le Sunday 12 June 2011 à 01:21 +0800, PCMan a écrit :
 
 A new release as 0.9.9 is required. Please help review and test the code in 
 git.
 Thanks a lot.

Thanks PCMan. So far, It's working nice on L/Ubuntu 10.10.

Some comments :
- Please bump the soname of your library each time you change your API.
Distributions can do smooth transitions between versions of
libfm/pcmanfm. Also, if you expect other applications to use libfm, you
need to use the soname.

- Is it possible to force a reload when you do any operations on a
remote place ? When I create a file on my sftp place, I expect that it
appears on pcmanfm after the creation. Monitoring is not needed, but any
user interactions should affect what pcmanfm shows.

-  I'm not sure having the tabs above the sidebar is good. I personally
prefer to have them just above the main window, like Nautilus do. But
maybe other people like this behavior ?

- Don't hesitate to do releases often, it's better for distributions :)
Even if bugs are discovered shortly after the release, you can still do
a quick X.X.1 release to fix this.

Regards,
Julien Lavergne


___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread PCMan
On Mon, Jun 13, 2011 at 6:34 PM, Julien Lavergne gi...@ubuntu.com wrote:
 Le Sunday 12 June 2011 à 01:21 +0800, PCMan a écrit :

 A new release as 0.9.9 is required. Please help review and test the code in 
 git.
 Thanks a lot.

 Thanks PCMan. So far, It's working nice on L/Ubuntu 10.10.

 Some comments :
 - Please bump the soname of your library each time you change your API.
 Distributions can do smooth transitions between versions of
 libfm/pcmanfm. Also, if you expect other applications to use libfm, you
 need to use the soname.
I want to do this for stable tarball releases only. In current stage
of development, change of API/ABIs can be frequent.
 - Is it possible to force a reload when you do any operations on a
 remote place ? When I create a file on my sftp place, I expect that it
 appears on pcmanfm after the creation. Monitoring is not needed, but any
 user interactions should affect what pcmanfm shows.
PCManFM should show the created files even on remote filesystems right
after you create them. Otherwise it's a bug.
 -  I'm not sure having the tabs above the sidebar is good. I personally
 prefer to have them just above the main window, like Nautilus do. But
 maybe other people like this behavior ?
Firefox + IE + Opera all does this. So does old PCManFM 0.5 series.
In addition, design like nautilus greatly limited the usability of
tabs since you can only have very few tabs due to limited space.
 - Don't hesitate to do releases often, it's better for distributions :)
 Even if bugs are discovered shortly after the release, you can still do
 a quick X.X.1 release to fix this.
Given the program is now used by so many users, it's better to have
releases with better quality.
 Regards,
 Julien Lavergne



___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Julien Lavergne
Le Monday 13 June 2011 à 19:17 +0800, PCMan a écrit :
  - Please bump the soname of your library each time you change your API.
  Distributions can do smooth transitions between versions of
  libfm/pcmanfm. Also, if you expect other applications to use libfm, you
  need to use the soname.
 I want to do this for stable tarball releases only. In current stage
 of development, change of API/ABIs can be frequent.
Ok, but technically, it's used as a stable application on, at least,
Debian and Ubuntu (and probably many other distributions).

So, what is missing for having a stable release of pcmanfm ? Any major
features are still missing ?

  - Is it possible to force a reload when you do any operations on a
  remote place ? When I create a file on my sftp place, I expect that it
  appears on pcmanfm after the creation. Monitoring is not needed, but any
  user interactions should affect what pcmanfm shows.
 PCManFM should show the created files even on remote filesystems right
 after you create them. Otherwise it's a bug.
Ok, so it's a bug. I just test it with sftp, and the folder is not
refreshed when I create a directory or a file, from right click and
New.

  -  I'm not sure having the tabs above the sidebar is good. I personally
  prefer to have them just above the main window, like Nautilus do. But
  maybe other people like this behavior ?
 Firefox + IE + Opera all does this. So does old PCManFM 0.5 series.
 In addition, design like nautilus greatly limited the usability of
 tabs since you can only have very few tabs due to limited space.
But I don't think browsers are designed to work full time with a
sidebar, like a files manager. I don't think the comparaison is fully
accurate. But well, it's just personal taste here :)

  - Don't hesitate to do releases often, it's better for distributions :)
  Even if bugs are discovered shortly after the release, you can still do
  a quick X.X.1 release to fix this.
 Given the program is now used by so many users, it's better to have
 releases with better quality.
But it's better than no release at all, especially for application still
in development. Last official release is 2010-10-14 (according to
http://sourceforge.net/projects/pcmanfm/files/ ), more than six months
ago.

Regards,
Julien Lavergne



___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Jonathan Marsden
On 06/13/2011 07:11 AM, Martin Bagge / brother wrote:

 On 2011-06-13 14:27, Julien Lavergne wrote:

 So, what is missing for having a stable release of pcmanfm ? Any
 major features are still missing ?

This is a key question for Lubuntu right now.

 Using git HEAD as source for a package in a distribution is not what
 pcman wants (and I support this way).

Agreed -- and the simplest way to prevent this is to release often
enough that distributions do not feel any need to package from git :)

 Last official release is 2010-10-14 ...

Which is both fairly old, and also bad timing regarding Ubuntu
releases, being only about two weeks before the Ubuntu 10.10 final release.

SUGGESTION: Let's test the current almost-0.9.9 codebase, fix any
major issues found in the next week or so, then bump the SONAME version
and release it before the end of June 2011.  Can we do that?

Since some testers seem to need packaged versions to test, I'll look at
creating a test unofficial package from git for them, so we get slightly
more testing.  Another way to go would be to release a 0.9.9~rc1
tarball, and a corresponding one for libfm, if that is preferred --
doing that means noone has to use git head for packaging :)

Jonathan

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Chris
Aloha oukou,


  Last official release is 2010-10-14 ...

 Which is both fairly old, and also bad timing regarding Ubuntu
 releases, being only about two weeks before the Ubuntu 10.10 final release.


That was 4 days AFTER the Ubuntu 10.10 release. But if you want to get
something in L/Ubuntu, you have to keep in mind the Feature Freeze [1] this
cycle set on August 11th.

With metta,

Chris Druif

[1] https://wiki.ubuntu.com/FeatureFreeze
___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread PCMan
On Mon, Jun 13, 2011 at 11:48 PM, Jonathan Marsden jmars...@fastmail.fm wrote:
 On 06/13/2011 07:11 AM, Martin Bagge / brother wrote:

 On 2011-06-13 14:27, Julien Lavergne wrote:

 So, what is missing for having a stable release of pcmanfm ? Any
 major features are still missing ?

 This is a key question for Lubuntu right now.
See this:
https://sourceforge.net/tracker/?group_id=156956atid=801864

I give the bugs different priority. The ones with highest priority
should be fixed before 0.9.9, I think. Please see if you can help.
Personally I will take this one:
https://sourceforge.net/tracker/?func=detailaid=3094303group_id=156956atid=801864
This is my bottom line. At least this one should be fixed before 0.9.9.
 Using git HEAD as source for a package in a distribution is not what
 pcman wants (and I support this way).

 Agreed -- and the simplest way to prevent this is to release often
 enough that distributions do not feel any need to package from git :)
Yes, so I plan to make a new release and asked for testing here. In
the past I mistakenly released some broken stuff, and this should not
happen again, especially when there are more and more people using
this.

 Last official release is 2010-10-14 ...

 Which is both fairly old, and also bad timing regarding Ubuntu
 releases, being only about two weeks before the Ubuntu 10.10 final release.

 SUGGESTION: Let's test the current almost-0.9.9 codebase, fix any
 major issues found in the next week or so, then bump the SONAME version
 and release it before the end of June 2011.  Can we do that?

Yes, if with help from the community. No if I do it myself.
Patches from Lubuntu is appreciated.

 Since some testers seem to need packaged versions to test, I'll look at
 creating a test unofficial package from git for them, so we get slightly
 more testing.  Another way to go would be to release a 0.9.9~rc1
 tarball, and a corresponding one for libfm, if that is preferred --
 doing that means noone has to use git head for packaging :)

That's true.
 Jonathan

Actually I have a primitive button-style path bar implemented in libfm
already, but I don't have time yet to add it to pcmanfm. I decided to
do it next time. Let's fix the important bugs first and make a good
release first.

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-13 Thread Jonathan Marsden
On Tue, 14 Jun 2011 01:12:06 +0800 PCMan pcman...@gmail.com wrote:

 https://sourceforge.net/tracker/?group_id=156956atid=801864

OK, thanks, that's good to know.

 SUGGESTION: Let's test the current almost-0.9.9 codebase, fix any
 major issues found in the next week or so, then bump the SONAME version
 and release it before the end of June 2011.  Can we do that?

 Yes, if with help from the community. No if I do it myself.
 Patches from Lubuntu is appreciated.

Since you mentioned it:

I *already* turned  libfm patches from Julien's Ubuntu package of
libfm into a git repo for you, six commits, and posted about doing 
that to this list.  All that was left for you to do was to cherrypick
which ones you want to include in the upstream sources:

  https://lists.launchpad.net/lubuntu-desktop/msg03977.html

As far as I can see, *none* of them have been included so far!  Either I did
something wrong, or else you don't really want those patches?  Help me
understand what I have to do so you will accept the commits I made for you from
Ubuntu patches, please.

 Since some testers seem to need packaged versions to test, I'll look at
 creating a test unofficial package from git for them, so we get slightly
 more testing.  Another way to go would be to release a 0.9.9~rc1
 tarball, and a corresponding one for libfm, if that is preferred --
 doing that means noone has to use git head for packaging :)

 That's true.

I'm playing with writing a script to grab the libfm git head and
Julien's package and automatically create a new package based on the
combination of the two.  It doesn't quite work yet... if it does, I'll
try to do the same for pcmanfm, and then we can create test packages for
pcmanfm testers much more easily :)

Jonathan

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


[Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-11 Thread PCMan
Hi all,
I'm here to call for a review for PCManFM as the source code in git is
in quite good shape now.
Many known bugs are fixed and I did much refactor to the tabbed
browsing part and merge changes in tab-rework3 branch with master.
Please help test and update translations in various distros. If things
are ok, I propose a new release.

Some major changes:
1. Reload Folder is available now in View menu.
2. Directory Tree mode is available in side pane.
3. Filesystem size is updated in a more correctly and efficient way.
4. Many bugs causing crashes are fixed.
5. Shows a warning icon in toolbar when running as root.
6. Supports menu keys.

minor changes:
1. Fixed some memory leaks.
2. ~ and / to move focus to location bar
3. Improve internal structure of PCManFM.
4. Code cleanup.

A new release as 0.9.9 is required. Please help review and test the code in git.
Thanks a lot.

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp


Re: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new release.

2011-06-11 Thread Lance
As a complete noob to Lubuntu (moving from Ubuntu/Gnome) I wonder if it would 
be possible to test this via a PPA before committing to a change for Oneiric.

Take note; I'm only an iso-tester so I'm clueless about the complexity 
involved, but I find pcmanfm quite easy to adapt to (basically just simple and 
intuitive) so I'm reluctant to see the devs make any changes that could 
possibly have a negative effect ;^)

I just want to see Lubuntu remain as stable as it is while confronting it's 
current challenges:

1) Becoming a full fledged member of the Ubuntu family.

2) IMHO maintaining a very feasible fall-back for those turned off by gnome3, 
gnome-shell, and/or unity :^)

3) Implementing the change to GTK+ 3.

Of course this is just an opinion from a true end user with a bit of testing 
experience.


--- On Sat, 6/11/11, PCMan pcman...@gmail.com wrote:

From: PCMan pcman...@gmail.com
Subject: [Lubuntu-desktop] Call for review: PCManFM is almost ready for a new 
release.
To: lxde-list lxde-l...@lists.sourceforge.net, pcmanfm-develop 
pcmanfm-deve...@lists.sourceforge.net, lubuntu-desktop 
lubuntu-desktop@lists.launchpad.net, lxde-i...@lists.sourceforge.net
Date: Saturday, June 11, 2011, 12:21 PM

Hi all,
I'm here to call for a review for PCManFM as the source code in git is
in quite good shape now.
Many known bugs are fixed and I did much refactor to the tabbed
browsing part and merge changes in tab-rework3 branch with master.
Please help test and update translations in various distros. If things
are ok, I propose a new release.

Some major changes:
1. Reload Folder is available now in View menu.
2. Directory Tree mode is available in side pane.
3. Filesystem size is updated in a more correctly and efficient way.
4. Many bugs causing crashes are fixed.
5. Shows a warning icon in toolbar when running as root.
6. Supports menu keys.

minor changes:
1. Fixed some memory leaks.
2. ~ and / to move focus to location bar
3. Improve internal structure of PCManFM.
4. Code cleanup.

A new release as 0.9.9 is required. Please help review and test the code in git.
Thanks a lot.

___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to     : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~lubuntu-desktop
Post to : lubuntu-desktop@lists.launchpad.net
Unsubscribe : https://launchpad.net/~lubuntu-desktop
More help   : https://help.launchpad.net/ListHelp