Re: [lustre-discuss] Small bug in 2.14 debian/rules

2022-06-02 Thread Åke Sandgren 

No I didn't, forgot to. Sebastien handled it though.

On 6/3/22 00:16, Peter Jones wrote:

Ake

Have you opened a JIRA ticket about this?

Peter

On 2022-06-02, 2:01 AM, "lustre-discuss on behalf of Åke Sandgren" 
 wrote:

 Sorry, meant master not 2.14, and it's commit a5084c2f2ec

 On 6/2/22 10:33, Åke Sandgren wrote:
 > Hi!
 >
 > In 2.14.0 debian/rules there is a comment that breaks a commands \-line
 > continuation causing exported env vars to be dropped.
 >
 > Simple fix is (configure-stamp rule):
 > ===
 > diff --git a/debian/rules b/debian/rules
 > index df80c077ba..14b1892fbf 100755
 > --- a/debian/rules
 > +++ b/debian/rules
 > @@ -199,8 +203,6 @@ configure-stamp: autogen-stamp debian/control.main
 > debian/control.modules.in
 >  elif echo "$${DEB_BUILD_PROFILES}" | grep -qw "nocrypto"; then \
 >  export EXTRAFLAGS="$${EXTRAFLAGS} --disable-crypto"; \
 >  fi; \
 > -   # remove env variables from config cache built by initial
 > configure,
 > -   # and create dedicated cache in temporary build directory
 >  if [ -f "$${CONFIG_CACHE_FILE}" ]; then \
 >  export TMP_CACHE_FILE=$$(mktemp); \
 >  sed "/ac_cv_env/d" "$${CONFIG_CACHE_FILE}" >
 > $${TMP_CACHE_FILE}; \
 > ===
 >
 > Same bug exists in the kdist_config rule.
 >

 --
 Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
 Internet: a...@hpc2n.umu.se  Mobile: +46 70 7716134  Fax: +46 90-580 14
 WWW: http://www.hpc2n.umu.se
 ___
 lustre-discuss mailing list
 lustre-discuss@lists.lustre.org
 http://lists.lustre.org/listinfo.cgi/lustre-discuss-lustre.org



--
Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
Internet: a...@hpc2n.umu.se  Mobile: +46 70 7716134  Fax: +46 90-580 14
WWW: http://www.hpc2n.umu.se
___
lustre-discuss mailing list
lustre-discuss@lists.lustre.org
http://lists.lustre.org/listinfo.cgi/lustre-discuss-lustre.org

Re: [lustre-discuss] Small bug in 2.14 debian/rules

2022-06-02 Thread Peter Jones via lustre-discuss 
Ake

Have you opened a JIRA ticket about this?

Peter

On 2022-06-02, 2:01 AM, "lustre-discuss on behalf of Åke Sandgren" 
 wrote:

Sorry, meant master not 2.14, and it's commit a5084c2f2ec

On 6/2/22 10:33, Åke Sandgren wrote:
> Hi!
> 
> In 2.14.0 debian/rules there is a comment that breaks a commands \-line 
> continuation causing exported env vars to be dropped.
> 
> Simple fix is (configure-stamp rule):
> ===
> diff --git a/debian/rules b/debian/rules
> index df80c077ba..14b1892fbf 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -199,8 +203,6 @@ configure-stamp: autogen-stamp debian/control.main 
> debian/control.modules.in
>  elif echo "$${DEB_BUILD_PROFILES}" | grep -qw "nocrypto"; then \
>  export EXTRAFLAGS="$${EXTRAFLAGS} --disable-crypto"; \
>  fi; \
> -   # remove env variables from config cache built by initial 
> configure,
> -   # and create dedicated cache in temporary build directory
>  if [ -f "$${CONFIG_CACHE_FILE}" ]; then \
>  export TMP_CACHE_FILE=$$(mktemp); \
>  sed "/ac_cv_env/d" "$${CONFIG_CACHE_FILE}" > 
> $${TMP_CACHE_FILE}; \
> ===
> 
> Same bug exists in the kdist_config rule.
> 

-- 
Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
Internet: a...@hpc2n.umu.se  Mobile: +46 70 7716134  Fax: +46 90-580 14
WWW: http://www.hpc2n.umu.se
___
lustre-discuss mailing list
lustre-discuss@lists.lustre.org
http://lists.lustre.org/listinfo.cgi/lustre-discuss-lustre.org

___
lustre-discuss mailing list
lustre-discuss@lists.lustre.org
http://lists.lustre.org/listinfo.cgi/lustre-discuss-lustre.org

Re: [lustre-discuss] Small bug in 2.14 debian/rules

2022-06-02 Thread Sebastien Buisson via lustre-discuss 
Thanks for reporting this. I created Jira ticket LU-15908 
(https://jira.whamcloud.com/browse/LU-15908), and pushed patch 
https://review.whamcloud.com/47512 to fix the problem.

Cheers,
Sebastien.

> Le 2 juin 2022 à 11:01, Åke Sandgren  a écrit :
> 
> Sorry, meant master not 2.14, and it's commit a5084c2f2ec
> 
> On 6/2/22 10:33, Åke Sandgren wrote:
>> Hi!
>> In 2.14.0 debian/rules there is a comment that breaks a commands \-line 
>> continuation causing exported env vars to be dropped.
>> Simple fix is (configure-stamp rule):
>> ===
>> diff --git a/debian/rules b/debian/rules
>> index df80c077ba..14b1892fbf 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -199,8 +203,6 @@ configure-stamp: autogen-stamp debian/control.main 
>> debian/control.modules.in
>> elif echo "$${DEB_BUILD_PROFILES}" | grep -qw "nocrypto"; then \
>> export EXTRAFLAGS="$${EXTRAFLAGS} --disable-crypto"; \
>> fi; \
>> -   # remove env variables from config cache built by initial configure,
>> -   # and create dedicated cache in temporary build directory
>> if [ -f "$${CONFIG_CACHE_FILE}" ]; then \
>> export TMP_CACHE_FILE=$$(mktemp); \
>> sed "/ac_cv_env/d" "$${CONFIG_CACHE_FILE}" > 
>> $${TMP_CACHE_FILE}; \
>> ===
>> Same bug exists in the kdist_config rule.
> 
> -- 
> Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
> Internet: a...@hpc2n.umu.se  Mobile: +46 70 7716134  Fax: +46 90-580 14
> WWW: http://www.hpc2n.umu.se
> ___
> lustre-discuss mailing list
> lustre-discuss@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-discuss-lustre.org

___
lustre-discuss mailing list
lustre-discuss@lists.lustre.org
http://lists.lustre.org/listinfo.cgi/lustre-discuss-lustre.org

Re: [lustre-discuss] Small bug in 2.14 debian/rules

2022-06-02 Thread Åke Sandgren 

Sorry, meant master not 2.14, and it's commit a5084c2f2ec

On 6/2/22 10:33, Åke Sandgren wrote:

Hi!

In 2.14.0 debian/rules there is a comment that breaks a commands \-line 
continuation causing exported env vars to be dropped.


Simple fix is (configure-stamp rule):
===
diff --git a/debian/rules b/debian/rules
index df80c077ba..14b1892fbf 100755
--- a/debian/rules
+++ b/debian/rules
@@ -199,8 +203,6 @@ configure-stamp: autogen-stamp debian/control.main 
debian/control.modules.in

     elif echo "$${DEB_BUILD_PROFILES}" | grep -qw "nocrypto"; then \
     export EXTRAFLAGS="$${EXTRAFLAGS} --disable-crypto"; \
     fi; \
-   # remove env variables from config cache built by initial 
configure,

-   # and create dedicated cache in temporary build directory
     if [ -f "$${CONFIG_CACHE_FILE}" ]; then \
     export TMP_CACHE_FILE=$$(mktemp); \
     sed "/ac_cv_env/d" "$${CONFIG_CACHE_FILE}" > 
$${TMP_CACHE_FILE}; \

===

Same bug exists in the kdist_config rule.



--
Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
Internet: a...@hpc2n.umu.se  Mobile: +46 70 7716134  Fax: +46 90-580 14
WWW: http://www.hpc2n.umu.se
___
lustre-discuss mailing list
lustre-discuss@lists.lustre.org
http://lists.lustre.org/listinfo.cgi/lustre-discuss-lustre.org