Re: [lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
Dirk, I appreciate your point. I find that makefiles are elegant concise and powerful. When all fail I just take the time to write a makefile using vpath for source files anywhere. With other IDEs you are at the mercy of ever changing formats (especially msvc and eclipse) I am not sure how cmake deals with new formats for every IDE version. It is a moving target. No? For no extra charge your are subject to the gui system. I will try your cmake system. My point is that you could leave alone working makefiles for people who choose to use them. Thanks Yigal On Sat, Jun 16, 2018 at 2:09 PM, Dirk Ziegelmeier wrote: > I agree a simple build system ideally without any dependency is best. But > cmake provides a great advantage: you prefer Makefiles, others prefer > Visual Studio projects, others Eclipse projects, others Ninja as a build > system etc. - cmake provides all of this and the cmake files are more > readable, at least after getting used to yet-another-syntax. The drawback > is you have to install one more dependency... > I still want to provide the Filelists.mk files, these won't go away, so it > will be always easy to maintain a Makefile based system for your own > projects without installing cmake. > > Dirk > > > On Fri, Jun 15, 2018 at 11:57 PM Yigal Hochberg > wrote: > >> Thanks Dirk, >> >> I like and prefer gnu Makefiles ready to go. They work work well in Linux >> and on Windows using Mingw and Cygwin. >> For msvc all you need is to change the CC and CFLAGS and you are good to >> go. msvc 2017 is finally very close to c99 or even later. >> The "older" file organization with Makefiles without the need to >> additional cmake processing. >> For all windows the final link needs win pcap lib (taken from wherever it >> was installed). >> >> I will try your suggestion for cmake (will need to install cmake). >> If it is simple and reliable maybe it is a godo improvement. >> >> Thanks >> Yigal >> >> >> >> >> >> >> >> >> On Fri, Jun 15, 2018 at 3:28 PM, Dirk Ziegelmeier >> wrote: >> >>> Hi Yigal, >>> >>> I removed it because you can generate easily a Makefile-based build (and >>> many others) using cmake. >>> >>> - cd into example_app dir >>> - mkdir build >>> - cd build >>> - cmake .. -G "MinGW Makefiles" >>> - make >>> >>> The msvc_netif_init contains no platform specific code. I just forgot >>> to rename it. Just pushed a fix it a few minutes before. >>> >>> >>> Dirk >>> >>> >>> ___ >>> lwip-users mailing list >>> lwip-users@nongnu.org >>> https://lists.nongnu.org/mailman/listinfo/lwip-users >>> >> >> >> >> -- >> Yigal >> ___ >> lwip-users mailing list >> lwip-users@nongnu.org >> https://lists.nongnu.org/mailman/listinfo/lwip-users > > > ___ > lwip-users mailing list > lwip-users@nongnu.org > https://lists.nongnu.org/mailman/listinfo/lwip-users > -- Yigal ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
I agree a simple build system ideally without any dependency is best. But cmake provides a great advantage: you prefer Makefiles, others prefer Visual Studio projects, others Eclipse projects, others Ninja as a build system etc. - cmake provides all of this and the cmake files are more readable, at least after getting used to yet-another-syntax. The drawback is you have to install one more dependency... I still want to provide the Filelists.mk files, these won't go away, so it will be always easy to maintain a Makefile based system for your own projects without installing cmake. Dirk On Fri, Jun 15, 2018 at 11:57 PM Yigal Hochberg wrote: > Thanks Dirk, > > I like and prefer gnu Makefiles ready to go. They work work well in Linux > and on Windows using Mingw and Cygwin. > For msvc all you need is to change the CC and CFLAGS and you are good to > go. msvc 2017 is finally very close to c99 or even later. > The "older" file organization with Makefiles without the need to > additional cmake processing. > For all windows the final link needs win pcap lib (taken from wherever it > was installed). > > I will try your suggestion for cmake (will need to install cmake). > If it is simple and reliable maybe it is a godo improvement. > > Thanks > Yigal > > > > > > > > > On Fri, Jun 15, 2018 at 3:28 PM, Dirk Ziegelmeier > wrote: > >> Hi Yigal, >> >> I removed it because you can generate easily a Makefile-based build (and >> many others) using cmake. >> >> - cd into example_app dir >> - mkdir build >> - cd build >> - cmake .. -G "MinGW Makefiles" >> - make >> >> The msvc_netif_init contains no platform specific code. I just forgot to >> rename it. Just pushed a fix it a few minutes before. >> >> >> Dirk >> >> >> ___ >> lwip-users mailing list >> lwip-users@nongnu.org >> https://lists.nongnu.org/mailman/listinfo/lwip-users >> > > > > -- > Yigal > ___ > lwip-users mailing list > lwip-users@nongnu.org > https://lists.nongnu.org/mailman/listinfo/lwip-users ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
Thanks Dirk, I like and prefer gnu Makefiles ready to go. They work work well in Linux and on Windows using Mingw and Cygwin. For msvc all you need is to change the CC and CFLAGS and you are good to go. msvc 2017 is finally very close to c99 or even later. The "older" file organization with Makefiles without the need to additional cmake processing. For all windows the final link needs win pcap lib (taken from wherever it was installed). I will try your suggestion for cmake (will need to install cmake). If it is simple and reliable maybe it is a godo improvement. Thanks Yigal On Fri, Jun 15, 2018 at 3:28 PM, Dirk Ziegelmeier wrote: > Hi Yigal, > > I removed it because you can generate easily a Makefile-based build (and > many others) using cmake. > > - cd into example_app dir > - mkdir build > - cd build > - cmake .. -G "MinGW Makefiles" > - make > > The msvc_netif_init contains no platform specific code. I just forgot to > rename it. Just pushed a fix it a few minutes before. > > > Dirk > > > ___ > lwip-users mailing list > lwip-users@nongnu.org > https://lists.nongnu.org/mailman/listinfo/lwip-users > -- Yigal ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
Hi Yigal, I removed it because you can generate easily a Makefile-based build (and many others) using cmake. - cd into example_app dir - mkdir build - cd build - cmake .. -G "MinGW Makefiles" - make The msvc_netif_init contains no platform specific code. I just forgot to rename it. Just pushed a fix it a few minutes before. Dirk ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
On 15.06.2018 15:34, Yigal Hochberg wrote: Hi Dirk, Somewhat related, I like and use the lwip-contrib/ports/win32 Specifically mingw/Makefile. I was surprised to see it was gone (unified). It is very convenient to build a test app using mingw/Makefile. Dirk has started to create cmake files as a replacement for the mingw and unix/linux Makefiles. This might be more inconvenient under windows. I think we might need some documentation here... The source files in lwip-contrib/ports/win32 including test.c are Windows specific because of msvc_netif_init() That's a name which got there by copy & paste. Anything really windows specific? Simon ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
Hi Dirk, Well, I'm not good with makefiles but I guess I can transform example_app into what I need. And I can always write a bash script. Just as long as you keep the tapif and tapif_select(), I can keep going with minimum effort. Regards ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
Hi Dirk, Somewhat related, I like and use the lwip-contrib/ports/win32 Specifically mingw/Makefile. I was surprised to see it was gone (unified). It is very convenient to build a test app using mingw/Makefile. The source files in lwip-contrib/ports/win32 including test.c are Windows specific because of msvc_netif_init() Thanks Yigal On Fri, Jun 15, 2018 at 4:56 AM, Dirk Ziegelmeier wrote: > Hello all, > > in order to clean up for lwIP 2.1, I'd like to remove the UNIX port test > applications > > - lib > - minimal > - unixsim > > The only remaining test/debug app would be the new "example_app" that > shares most of the code with the windows port. > We would then have only one common app shared between windows and unix > port to reduce maintenance effort. > > Any objections? Please speak up now :-) > > Dirk > > > ___ > lwip-users mailing list > lwip-users@nongnu.org > https://lists.nongnu.org/mailman/listinfo/lwip-users > -- Yigal ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
Hi Sergio, you "*started long ago* using 'minimal' for development and teaching" - does that mean you still use it today? Do you want me to keep it? The TAP (not TUN) interface will remain, since the example_app uses it. Do you need the TUN interface? If I got you right, lib, simhost, simnode and simrouter can be removed - you do not care about it. I have no objections against keeping this stuff, but most of it is not really maintained - I try to keep it compileable, but I don't know whether everything except simhost is actually working. To reduce maintenance and to improve quality (by only shipping tested stuff) I'd like to remove everything where noone cares about. Dirk On Fri, Jun 15, 2018 at 2:53 PM Sergio R. Caprile wrote: > Hi, > I started long ago using 'minimal' for development and teaching. > I need a tap interface and the stack compiled to run as NO_SYS=1, as my > work is on bare metal stuff. > Yes, I use the lib. I guess there is no _need_ for it and I can just > compile lwIP and link to it as in a regular embedded project. Since the > lib was there, I've been using it. > > ___ > lwip-users mailing list > lwip-users@nongnu.org > https://lists.nongnu.org/mailman/listinfo/lwip-users > ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
Re: [lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
Hi, I started long ago using 'minimal' for development and teaching. I need a tap interface and the stack compiled to run as NO_SYS=1, as my work is on bare metal stuff. Yes, I use the lib. I guess there is no _need_ for it and I can just compile lwIP and link to it as in a regular embedded project. Since the lib was there, I've been using it. ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
[lwip-users] lwIP 2.1 cleanup - remove UNIX test apps
Hello all, in order to clean up for lwIP 2.1, I'd like to remove the UNIX port test applications - lib - minimal - unixsim The only remaining test/debug app would be the new "example_app" that shares most of the code with the windows port. We would then have only one common app shared between windows and unix port to reduce maintenance effort. Any objections? Please speak up now :-) Dirk ___ lwip-users mailing list lwip-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/lwip-users
