[lxc-devel] [lxc/lxc] 496397: lxc-debian: We should only check the kernel archit...

Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 4963978bb6e8f4eafc73bf0a3e93278b704ce784 https://github.com/lxc/lxc/commit/4963978bb6e8f4eafc73bf0a3e93278b704ce784 Author: Stéphane Graber Date: 2015-09-28 (Mon, 28 Sep 2015) Changed

Re: [lxc-devel] [PATCH] lxc-alpine: use getopt to parse options

On Mon, Sep 28, 2015 at 02:51:21PM +0300, Kaarle Ritvanen wrote: > Signed-off-by: Kaarle Ritvanen Acked-by: Stéphane Graber > --- > templates/lxc-alpine.in | 51 > + > 1 file changed, 13

Re: [lxc-devel] [PATCH] lxc-alpine: avoid GNU BRE extensions for better portability

On Mon, Sep 28, 2015 at 02:49:14PM +0300, Kaarle Ritvanen wrote: > Signed-off-by: Kaarle Ritvanen Acked-by: Stéphane Graber > --- > templates/lxc-alpine.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[lxc-devel] [lxc/lxc] f2e4dd: Remove unnecessary call to free()

Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: f2e471d427f9cacbab4016ffe18b0e4a4a0a https://github.com/lxc/lxc/commit/f2e471d427f9cacbab4016ffe18b0e4a4a0a Author: Christian Brauner Date: 2015-09-28 (Mon, 28 Sep 2015)

Re: [lxc-devel] Networking and LXD

Quoting Tom Denham (tom.den...@metaswitch.com): > I'm going to need to digest this a bit more but my initial concern is that > lxd relies on bridges for networking whereas Calico is more L3 focused. > > The way Calico works is similar to what you described below > * Create a veth > * Put one end

Re: [lxc-devel] [RFC 3/5] added stop-hook entries

Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): No signed-off-by Note this will need a very good description in the documentation, to explain that this will run as a child of the monitor in the container's namespace, and iiuc with the container under $rootfs. so it will want to umount under

Re: [lxc-devel] [RFC 4/5] run stop hook between STOPPING and STOPPED states

Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > --- Acked-by: Serge E. Hallyn > src/lxc/start.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/lxc/start.c b/src/lxc/start.c > index 87fc32f..a1eb961 100644 > --- a/src/lxc/start.c > +++

Re: [lxc-devel] Networking and LXD

> -Original Message- > From: Serge Hallyn [mailto:serge.hal...@ubuntu.com] > Sent: Monday, September 28, 2015 7:42 AM > To: Tom Denham > Cc: LXC development mailing-list > Subject: Re: [lxc-devel] Networking and LXD > > Quoting Tom Denham (tom.den...@metaswitch.com): > > I'm going to need

Re: [lxc-devel] [PATCH] Add lxc-copy executable lxc-copy merges lxc-clone + lxc-start-ephemeral into one

I'm working on a couple of small bug fixes brought to my attention by additional tests. Furthermore, since we allow all backingstorages that allow snapshots to be started as ephemeral containers it makes sense to allow users to directly specify the type of the union mounts he wants. So the current

Re: [lxc-devel] Networking and LXD

I'm going to need to digest this a bit more but my initial concern is that lxd relies on bridges for networking whereas Calico is more L3 focused. The way Calico works is similar to what you described below * Create a veth * Put one end in the netns and leave the other in the host netns * But

Re: [lxc-devel] [PATCH] Free allocated memory on failure (v2)

Quoting Christian Brauner (christianvanbrau...@gmail.com): > Signed-off-by: Christian Brauner Thanks! Acked-by: Serge E. Hallyn > --- > src/lxc/bdev.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [lxc-devel] [RFC 0/5] stop hook with namespace access

Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > Just a quick followup: What about actually shipping this in /usr/share/lxc/hooks/ from lxc/hooks ? > I thought I'd drop a stop hook example here and a reason for why it's > useful. > > As I mentioned, it's mostly about unmounting NFS

Re: [lxc-devel] [RFC 1/5] start.c:preserve_ns: added pid parameter

Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): No signed-off-by here. Acked-by: Serge E. Hallyn > --- > src/lxc/start.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/lxc/start.c b/src/lxc/start.c > index 0601333..1a7d5a3

Re: [lxc-devel] [RFC 2/5] preserve container namespace

Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > --- No signed-off-by Acked-by: Serge E. Hallyn > src/lxc/start.c | 18 ++ > src/lxc/start.h | 1 + > 2 files changed, 19 insertions(+) > > diff --git a/src/lxc/start.c b/src/lxc/start.c > index

Re: [lxc-devel] [RFC 5/5] pass namespace handles to the stop hook

Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > --- > src/lxc/start.c | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/src/lxc/start.c b/src/lxc/start.c > index a1eb961..7a909de 100644 > --- a/src/lxc/start.c > +++ b/src/lxc/start.c > @@

Re: [lxc-devel] [RFC 0/5] stop hook with namespace access

Just a quick followup: I thought I'd drop a stop hook example here and a reason for why it's useful. As I mentioned, it's mostly about unmounting NFS mountpoints. However, you could say that that's not usually an issue as the container usually performs a (hopefully) clean shutdown sequence which

[lxc-devel] [PATCH] lxc-alpine: use getopt to parse options

Signed-off-by: Kaarle Ritvanen --- templates/lxc-alpine.in | 51 + 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/templates/lxc-alpine.in b/templates/lxc-alpine.in index d62f891..29c7b7c 100644 ---

[lxc-devel] [PATCH] Free allocated memory on failure (v2)

Signed-off-by: Christian Brauner --- src/lxc/bdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index 21a64f7..846fd82 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -2461,12 +2461,15 @@ static int

[lxc-devel] [PATCH] lxc-alpine: avoid GNU BRE extensions for better portability

Signed-off-by: Kaarle Ritvanen --- templates/lxc-alpine.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/lxc-alpine.in b/templates/lxc-alpine.in index 6dcc51b..d62f891 100644 --- a/templates/lxc-alpine.in +++

Re: [lxc-devel] [RFC 0/5] stop hook with namespace access

Hi, Please note that even though Serge acked most of this patchset, I won't be pushing it until it's re-sent with all commits including the required Signed-off-by line. Thanks! On Wed, Sep 23, 2015 at 04:12:05PM +0200, Wolfgang Bumiller wrote: > As I mentioned in an earlier email (sorry it took