> On September 30, 2015 at 6:07 PM Serge Hallyn wrote:
>
>
> Quoting Wolfgang Bumiller (w.bumil...@proxmox.com):
> > Signed-off-by: Wolfgang Bumiller
> > ---
> > src/lxc/start.c | 21 +++--
> > 1 file changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/lxc/sta
Quoting Christian Brauner (christianvanbrau...@gmail.com):
> Signed-off-by: Christian Brauner
Acked-by: Serge E. Hallyn
> ---
> doc/lxc.container.conf.sgml.in | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/doc/lxc.container.conf.sgml.in b/doc/lxc.container.conf
Quoting Christian Brauner (christianvanbrau...@gmail.com):
> While lxc-copy is under review let users benefit (reboot survival etc.) from
> the
> new lxc.ephemeral option already in lxc-start-ephemeral. This way we can
> remove
> the lxc.hook.post-stop script-
>
> Signed-off-by: Christian Braune
This would have caught the regression last night.
Signed-off-by: Serge Hallyn
---
src/tests/lxc-test-symlink | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/tests/lxc-test-symlink b/src/tests/lxc-test-symlink
index 37320f0..7bf6c1c 100755
--- a/src/tests/lxc-test-symlink
+++ b/src/tests/
Branch: refs/heads/master
Home: https://github.com/lxc/lxc
Commit: 3a05a669c1ad73fc57a5295d8aaae04b20e40c88
https://github.com/lxc/lxc/commit/3a05a669c1ad73fc57a5295d8aaae04b20e40c88
Author: Matteo Bernardini
Date: 2015-09-29 (Tue, 29 Sep 2015)
Changed paths:
M config/te
Branch: refs/heads/master
Home: https://github.com/lxc/lxc
Commit: c6be89f8570be19c33af49198d4eb8e6d27d626f
https://github.com/lxc/lxc/commit/c6be89f8570be19c33af49198d4eb8e6d27d626f
Author: Colin Watson
Date: 2015-09-30 (Wed, 30 Sep 2015)
Changed paths:
M src/lxc/lxc-st
The same anti-goto was originally pounded into me, then I did some kernel
coding and saw how nice it can be compared to alternatives :)
fwiw, the plus side of the goto in this case is to commonize the work to
be done before the next loop (in this case just a 'counter++'). The minus
side is that "
Quoting Christian Brauner (christianvanbrau...@gmail.com):
> A bit of pedantry usually doesn't hurt. The code should be easier to follow
> now
> and avoids some repetitions.
>
> Signed-off-by: Christian Brauner
Note I still don't really feel the first hunk is an improvement
in readability, but
Sorry, my teachers pounded a violent hatred for gotos for non-cleanup purposes
into me. Thanks. :)
On Wed, Sep 30, 2015 at 04:13:12PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > A bit of pedantry usually doesn't hurt. The code should be easier to fol
Quoting Wolfgang Bumiller (w.bumil...@proxmox.com):
> Signed-off-by: Wolfgang Bumiller
Acked-by: Serge E. Hallyn
> ---
> doc/lxc.container.conf.sgml.in | 27 +--
> 1 file changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/doc/lxc.container.conf.sgml.in b/doc/lx
Quoting Wolfgang Bumiller (w.bumil...@proxmox.com):
> Signed-off-by: Wolfgang Bumiller
> ---
> src/lxc/start.c | 21 +++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/src/lxc/start.c b/src/lxc/start.c
> index a1eb961..38e7e97 100644
> --- a/src/lxc/start.c
Signed-off-by: Christian Brauner
---
doc/lxc.container.conf.sgml.in | 20
1 file changed, 20 insertions(+)
diff --git a/doc/lxc.container.conf.sgml.in b/doc/lxc.container.conf.sgml.in
index eb3241f..f816491 100644
--- a/doc/lxc.container.conf.sgml.in
+++ b/doc/lxc.container.
While lxc-copy is under review let users benefit (reboot survival etc.) from the
new lxc.ephemeral option already in lxc-start-ephemeral. This way we can remove
the lxc.hook.post-stop script-
Signed-off-by: Christian Brauner
---
src/lxc/lxc-start-ephemeral.in | 10 +-
1 file changed, 1 i
* Added sign-off lines
* Added acked-by serge to the ones he acked in the RFC email series
* Patch 5: moved the counter increment to after the error handling
* Added stop hook documentation (Patch 6)
* Added hooks/unmount-namespace.c (Patch 7)
Summary from the [RFC] series replies:
Serge Hallyn me
Signed-off-by: Wolfgang Bumiller
Acked-by: Serge E. Hallyn
---
src/lxc/start.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/lxc/start.c b/src/lxc/start.c
index 87fc32f..a1eb961 100644
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -493,6 +493,8 @@ void lxc_fini(const char *name, str
Signed-off-by: Wolfgang Bumiller
Acked-by: Serge E. Hallyn
---
src/lxc/conf.c| 4 +++-
src/lxc/conf.h| 2 +-
src/lxc/confile.c | 3 +++
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/lxc/conf.c b/src/lxc/conf.c
index 0913b22..f81efcd 100644
--- a/src/lxc/conf.c
+++ b/
Signed-off-by: Wolfgang Bumiller
---
hooks/Makefile.am | 6 ++
hooks/unmount-namespace.c | 180 ++
2 files changed, 186 insertions(+)
create mode 100644 hooks/unmount-namespace.c
diff --git a/hooks/Makefile.am b/hooks/Makefile.am
index be556
Signed-off-by: Wolfgang Bumiller
---
src/lxc/start.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/src/lxc/start.c b/src/lxc/start.c
index a1eb961..38e7e97 100644
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -486,15 +486,32 @@ out_free:
void lxc_f
Signed-off-by: Wolfgang Bumiller
Acked-by: Serge E. Hallyn
---
src/lxc/start.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/lxc/start.c b/src/lxc/start.c
index 0601333..1a7d5a3 100644
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -124,14 +124,15 @@ static v
Signed-off-by: Wolfgang Bumiller
---
doc/lxc.container.conf.sgml.in | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/doc/lxc.container.conf.sgml.in b/doc/lxc.container.conf.sgml.in
index 7b599e5..f1a87e9 100644
--- a/doc/lxc.container.conf.sgml.in
+
Signed-off-by: Wolfgang Bumiller
Acked-by: Serge E. Hallyn
---
src/lxc/start.c | 18 ++
src/lxc/start.h | 1 +
2 files changed, 19 insertions(+)
diff --git a/src/lxc/start.c b/src/lxc/start.c
index 1a7d5a3..87fc32f 100644
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -379,6 +3
> On September 29, 2015 at 5:41 PM Serge Hallyn wrote:
>
>
> Quoting Wolfgang Bumiller (w.bumil...@proxmox.com):
> > > On September 28, 2015 at 5:14 PM Serge Hallyn
> > > wrote:
> > > Quoting Wolfgang Bumiller (w.bumil...@proxmox.com):
> > > > Just a quick followup:
> > >
> > > What about actu
22 matches
Mail list logo
