Re: [lxc-devel] [PATCH] lxc_start: report error message when config is not a regular file

2015-10-15 Thread Serge Hallyn
Quoting Yang Shi (yang@linaro.org): > When run the below command: > lxc-start -n name -f /path/to/config > > If config is not a regular file, lxc-start will be killed by SEG FAULT > directly. What exactly was the file to get a segfault? When I try with a device or a directory I do not get a

[lxc-devel] [PATCH] Trivial: fix missing space before closing bracket

2015-10-15 Thread Christian Brauner
Signed-off-by: Christian Brauner --- share/lxc.mount.hook.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/share/lxc.mount.hook.in b/share/lxc.mount.hook.in index 7194ab8..5ed2d60 100755 --- a/share/lxc.mount.hook.in +++

Re: [lxc-devel] [PATCH] Trivial: fix missing space before closing bracket

2015-10-15 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > Signed-off-by: Christian Brauner Acked-by: Serge E. Hallyn > --- > share/lxc.mount.hook.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [lxc-devel] [PATCH] Make mount_entry_create_*_dirs() more robust

2015-10-15 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > The mount_entry_create_*_dirs() functions currently assume that the rootfs of > the container is actually named "rootfs". This has the consequence that > > del = strstr(lxcpath, "/rootfs"); > if (!del) { >

Re: [lxc-devel] [PATCH] Make mount_entry_create_*_dirs() more robust

2015-10-15 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > The mount_entry_create_*_dirs() functions currently assume that the rootfs of > the container is actually named "rootfs". This has the consequence that > > del = strstr(lxcpath, "/rootfs"); > if (!del) { >

Re: [lxc-devel] [PATCH] lxc_start: report error message when config is not a regular file

2015-10-15 Thread Shi, Yang
On 10/15/2015 7:31 AM, Serge Hallyn wrote: Quoting Yang Shi (yang@linaro.org): When run the below command: lxc-start -n name -f /path/to/config If config is not a regular file, lxc-start will be killed by SEG FAULT directly. What exactly was the file to get a segfault? When I try with a

Re: [lxc-devel] [PATCH] ubuntu-cloud: Replace .tar.gz by .tar.xz and don't auto-generate missing tarballs

2015-10-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > templates/lxc-ubuntu-cloud.in | 46 > --- > 1 file changed, 4 insertions(+), 42 deletions(-)

[lxc-devel] [PATCH] Ignore trailing /init.scope in init cgroups

2015-10-15 Thread Serge Hallyn
The lxc monitor does not store the container's cgroups, rather it recalculates them whenever needed. Systemd moves itself into a /init.scope cgroup for the systemd controller. It might be worth changing that (by storing all cgroup info in the lxc_handler), but for now go the hacky route and chop