[lxc-devel] [PATCH v5] Parse rootfs->path

2015-10-22 Thread Christian Brauner
Changes: if ((s3 = strstr(s2, ":/"))) s2[strlen(s2) - strlen(s3)] obviously simplifies to if ((s3 = strstr(s2, ":/"))) *s3 = '\0'; Christian Brauner (1): Parse rootfs->path src/lxc/conf.c | 98

[lxc-devel] [PATCH v5] Parse rootfs->path

2015-10-22 Thread Christian Brauner
The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They try to make sure that the workdirs and upperdirs can only be created under the containerdir (e.g. /path/to/the/container/CONTAINERNAME). In order to

Re: [lxc-devel] [PATCH v4] Parse rootfs->path

2015-10-22 Thread Christian Brauner
On Thu, Oct 22, 2015 at 03:33:30AM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create > > workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They > > try > > to

Re: [lxc-devel] [ACK] [PATCH v5] Parse rootfs->path

2015-10-22 Thread Serge Hallyn
Sorry, resending with clearer subject line for ppor Stéphane's benefit. Quoting Christian Brauner (christianvanbrau...@gmail.com): > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create > workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They try > to

Re: [lxc-devel] [PATCH v2] Update absolute paths for overlay and aufs mounts

2015-10-22 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Thu, Oct 22, 2015 at 01:13:35PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > On Tue, Oct 20, 2015 at 04:17:18PM +, Serge Hallyn wrote: > > > > Quoting Christian Brauner

Re: [lxc-devel] [PATCH v2] Update absolute paths for overlay and aufs mounts

2015-10-22 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Tue, Oct 20, 2015 at 04:17:18PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > When using overlay and aufs mounts with lxc.mount.entry users have to > > > specify > > > absolute paths

Re: [lxc-devel] [PATCH v5] Parse rootfs->path

2015-10-22 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create > workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They try > to make sure that the workdirs and upperdirs can only be created under the >

Re: [lxc-devel] [PATCH v4] Parse rootfs->path

2015-10-22 Thread Christian Brauner
On Thu, Oct 22, 2015 at 02:59:28AM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Tue, Oct 20, 2015 at 09:21:48PM +0200, Christian Brauner wrote: > > > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions > > > create > > > workdirs