Re: [lxc-devel] [PATCH 0/2] Create random workdir for overlay mounts

2015-10-27 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > - When no explicit workdir is given we simply create a random workdir using > mkdtemp(). > - The temporary workdir is not removed when the container stops as it is not > obvious to me at this point how to do this cleanly. This means

Re: [lxc-devel] [PATCH 1/2] Simplify function

2015-10-27 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > Instead of duplicating the cleanup-code, once for success and once for > failure, > simply keep a variable fret which is -1 in the beginning and gets set to 0 on > success or stays -1 on failure. > > Signed-off-by: Christian Brauner

Re: [lxc-devel] [PATCH 0/2] Create random workdir for overlay mounts

2015-10-27 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Tue, Oct 27, 2015 at 05:26:53PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > - When no explicit workdir is given we simply create a random workdir > > > using > > > mkdtemp(). > >

[lxc-devel] [PATCH] lxc-net: switch After target to network-online.target

2015-10-27 Thread Serge Hallyn
Otherwise it may start too early and end up taking 10.0.3.1 even though eth0 was eventually going to end up on 10.0.3.x. https://bugs.launchpad.net/juju-core/+bug/1510619 Reported-by: Ryan Harper Cc: Martin Pitt Signed-off-by: Serge Hallyn

[lxc-devel] [PATCH 0/2] Update absolute paths for overlay and aufs mounts

2015-10-27 Thread Christian Brauner
Changes: (1) Make updating lxc_conf->mnt_list and lxc_conf->unexpanded_config independent of each other so that users can include overlay mounts from other files. (2) Update lxc_conf->unexpanded_config by using a separate function clone_update_unexp_ovl_dir() in confile.c. (3) Move various

Re: [lxc-devel] [PATCH 0/2] Create random workdir for overlay mounts

2015-10-27 Thread Christian Brauner
On Tue, Oct 27, 2015 at 05:26:53PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > - When no explicit workdir is given we simply create a random workdir using > > mkdtemp(). > > - The temporary workdir is not removed when the container stops as it is