Re: [lxc-devel] [PATCH] c/r: remember to chown the cgroup path (correctly)

2016-01-14 Thread Tycho Andersen
On Wed, Jan 13, 2016 at 09:47:50PM +, Serge Hallyn wrote: > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > 1. remember to chown the cgroup path when migrating a container > > 2. when restoring the cgroup path, try to compute the euid for root vs. > >using geteuid(); geteuid

Re: [lxc-devel] [PATCH] c/r: remember to chown the cgroup path (correctly)

2016-01-14 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > On Wed, Jan 13, 2016 at 09:47:50PM +, Serge Hallyn wrote: > > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > > 1. remember to chown the cgroup path when migrating a container > > > 2. when restoring the cgroup path, try to

Re: [lxc-devel] [PATCH] .gitignore: add sparclinux make output

2016-01-14 Thread Tycho Andersen
On Wed, Jan 13, 2016 at 10:20:12PM +, Serge Hallyn wrote: > Quoting Wim Coekaerts (wim.coekae...@oracle.com): > > On 1/13/16 1:50 PM, Serge Hallyn wrote: > > >Quoting Tycho Andersen (tycho.ander...@canonical.com): > > >>Signed-off-by: Tycho Andersen > >

Re: [lxc-devel] [PATCH v2] safe_mount: Handle mounting proc and refactor

2016-01-14 Thread Bogdan Purcareata
On 14.01.2016 01:09, Serge Hallyn wrote: > Quoting Bogdan Purcareata (bogdan.purcare...@nxp.com): >> On 11.01.2016 20:59, Serge Hallyn wrote: >>> Quoting Bogdan Purcareata (bogdan.purcare...@nxp.com): The safe_mount primitive will mount the fs in the new container environment by using

[lxc-devel] [RFC 0/2] Feature: --start-frozen

2016-01-14 Thread Wolfgang Bumiller
Patch 1: This adds the possibility to start a container in a frozen state via a --start-frozen parameter added to lxc-start. I'm not sure the implementation is ideal. There's probably some reusable cgroup code somewhere, but as far as I could tell it is mostly meant for the monitor, so I don't

[lxc-devel] [RFC 1/2] lxc-start: added --start-frozen

2016-01-14 Thread Wolfgang Bumiller
Add the possibility to start a container in a frozen state. Signed-off-by: Wolfgang Bumiller --- doc/lxc-start.sgml.in | 12 src/lxc/arguments.h| 3 +++ src/lxc/conf.h | 1 + src/lxc/lxc_start.c| 7 +++ src/lxc/lxccontainer.c | 16

[lxc-devel] [RFC 2/2] cleanup: lxc_container::want_* comment descriptions

2016-01-14 Thread Wolfgang Bumiller
They change a value and return true on success rather than fetching the value as the comments previously suggested. Signed-off-by: Wolfgang Bumiller --- src/lxc/lxccontainer.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

Re: [lxc-devel] [PATCH] c/r: remember to chown the cgroup path (correctly)

2016-01-14 Thread Tycho Andersen
On Thu, Jan 14, 2016 at 09:28:07AM +, Serge Hallyn wrote: > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > On Wed, Jan 13, 2016 at 09:47:50PM +, Serge Hallyn wrote: > > > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > > > 1. remember to chown the cgroup path when

[lxc-devel] Swap Accounting :Query

2016-01-14 Thread Nehal J Wani
I am using the most recent version of lxcfs, commit: 17f9a5a9d647467e3858fa751e40cc7c022dd475 When I spawn a container with the settings... lxc.cgroup.memory.limit_in_bytes = 256M lxc.cgroup.memory.memsw.limit_in_bytes = 512M ... I find that inside the container, we have: [root@test ~]# free

[lxc-devel] [PATCH v2] Fix btrfs bus error on sparc on snapshot delete

2016-01-14 Thread Thomas Tanaka
The following patch fixes memory alignment and endianness issue while doing a snapshot deletion with btrfs as a backing store on platform such as sparc. The implementation is taken from btrfs-progs. Changes since v1: - include for bswap definition - include defined function name as a comment

Re: [lxc-devel] [PATCH v2] Fix btrfs bus error on sparc on snapshot delete

2016-01-14 Thread Serge Hallyn
Quoting Thomas Tanaka (thomas.tan...@oracle.com): > The following patch fixes memory alignment and endianness > issue while doing a snapshot deletion with btrfs as a > backing store on platform such as sparc. > > The implementation is taken from btrfs-progs. > > Changes since v1: > - include

Re: [lxc-devel] [PATCH] add lxc-copy to see_also.sgml.in

2016-01-14 Thread Serge Hallyn
Quoting Christian Brauner (christian.brau...@mailbox.org): > Signed-off-by: Christian Brauner Acked-by: Serge E. Hallyn > --- > doc/see_also.sgml.in | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/doc/see_also.sgml.in

[lxc-devel] [PATCH] add lxc-copy to see_also.sgml.in

2016-01-14 Thread Christian Brauner
Signed-off-by: Christian Brauner --- doc/see_also.sgml.in | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/see_also.sgml.in b/doc/see_also.sgml.in index 4954e8e..3b3ecd7 100644 --- a/doc/see_also.sgml.in +++ b/doc/see_also.sgml.in @@ -38,6 +38,11 @@

[lxc-devel] [lxc/lxc] 685062: avoid printing null string in error message

2016-01-14 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 685062d6ff3eccf1b43abecbab95c213c22428e0 https://github.com/lxc/lxc/commit/685062d6ff3eccf1b43abecbab95c213c22428e0 Author: Serge Hallyn Date: 2016-01-14 (Thu, 14 Jan 2016) Changed

Re: [lxc-devel] [PATCH] check for btrfs fs in should_default_to_snapshot

2016-01-14 Thread Serge Hallyn
Quoting Christian Brauner (christian.brau...@mailbox.org): > Check if we're really on a btrfs filesystem before we call btrfs_same_fs(). > Otherwise we will report misleading errors although everything went fine. > > Signed-off-by: Christian Brauner Acked-by:

[lxc-devel] [PATCH] Fix btrfs bus error on sparc on snapshot delete

2016-01-14 Thread Thomas Tanaka
The following patch fixes memory alignment and endianness issue while doing a snapshot deletion with btrfs as a backing store on platform such as sparc. The implementation is taken from btrfs-progs. Signed-off-by: Thomas Tanaka --- src/lxc/bdev/lxcbtrfs.c | 28

Re: [lxc-devel] [PATCH v2] safe_mount: Handle mounting proc and refactor

2016-01-14 Thread Serge Hallyn
Quoting Bogdan Purcareata (bogdan.purcare...@nxp.com): > On 14.01.2016 01:09, Serge Hallyn wrote: > > Quoting Bogdan Purcareata (bogdan.purcare...@nxp.com): > >> On 11.01.2016 20:59, Serge Hallyn wrote: > >>> Quoting Bogdan Purcareata (bogdan.purcare...@nxp.com): > The safe_mount primitive

Re: [lxc-devel] [PATCH] c/r: remember to chown the cgroup path (correctly)

2016-01-14 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > On Thu, Jan 14, 2016 at 09:28:07AM +, Serge Hallyn wrote: > > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > > On Wed, Jan 13, 2016 at 09:47:50PM +, Serge Hallyn wrote: > > > > Quoting Tycho Andersen

[lxc-devel] [PATCH] check for btrfs fs in should_default_to_snapshot

2016-01-14 Thread Christian Brauner
Check if we're really on a btrfs filesystem before we call btrfs_same_fs(). Otherwise we will report misleading errors although everything went fine. Signed-off-by: Christian Brauner --- src/lxc/bdev/lxcbtrfs.c | 2 +- src/lxc/bdev/lxcoverlay.c | 2 +-

Re: [lxc-devel] [PATCH] Fix btrfs bus error on sparc on snapshot delete

2016-01-14 Thread Serge Hallyn
Quoting Thomas Tanaka (thomas.tan...@oracle.com): > The following patch fixes memory alignment and endianness > issue while doing a snapshot deletion with btrfs as a > backing store on platform such as sparc. > > The implementation is taken from btrfs-progs. Hi, thanks, this looks nice. I'm