Re: [lxc-devel] Gentoo-ebuild for LXC 3.0.0 ./. Python/LUA-bindings

On Thu, Apr 05, 2018 at 10:26:39AM +, Jäkel, Guido wrote: > Hi all, > > did somebody already start to set up the Gentoo ebuild > app-emulation/lxc-3.0.0 ? I start with this and run into problems with the > bindings: I wonder about how to deal with the split into separate packages. No idea

Re: [lxc-devel] Small patch to lxc-checkpoint tool (running action scripts in CRIU)

On Sun, Mar 25, 2018 at 06:50:40PM +0300, Eytan Heidingsfeld wrote: > Hello, > I have a deployment where I would like to run a custom action script in > CRIU when restoring an LXC container, > > The criu.c source in lxc supports this but currently the command line > doesn't -- so I'm attaching a s

Re: [lxc-devel] Patch: rootfs pinning: make file hidden, don't delete it (but not encode pid)

On Thu, Mar 22, 2018 at 03:39:57PM +, Jäkel, Guido wrote: > Dear Serge and others > > I suggest the following patch: Guido, Could you please sign-off the patch otherwise we won't be able to even look at it. :) Thanks! Christian > > --- lxc/conf.c.20180315-160849 2018-03-15 16:08:49.28308

[lxc-devel] On The Way To LXC 3.0: Moving The Cgroup Pam Module Into The LXC Tree (Including A Detour About Fully Unprivileged Containers)

Hey everyone, Yet another blogpost about LXC 3.0 development. This time we'd like to tell you what happens to the pam_cgfs.so pam module that we used to ship with LXCFS. You can read the details here: https://brauner.github.io/2018/02/28/lxc-includes-cgroup-pam-module.html We're near the finish

[lxc-devel] On The Way To LXC 3.0: Splitting Out Templates And Language Bindings

Hey everyone, This is another update about the LXC 3.0 development. Instead of copying and pasting what I wrote on my blog here I'm going to be lazy and please ask you to read: https://brauner.github.io/2018/02/27/lxc-removes-legacy-template-build-system.html This should give you an idea what we

[lxc-devel] LXC 3.0: Removal of cgmanager And cgfs cgroup Drivers

Hey everyone, This is another update about the development of LXC 3.0. As of yesterday the cgmanager and cgfs cgroup drivers have been removed from the codebase. In the good long tradition of all LXC projects to try our hardest to never regress our users and to clearly communicate invasive changes

Re: [lxc-devel] Getting complex data (structs) from a container (net ns) in API

Hi Rafał, Sorry for the late reply. On Fri, Jan 19, 2018 at 04:22:03PM +0100, Rafał Miłecki wrote: > Hi, > > currently lxccontainer's API has two functions for getting net info: > char** (*get_interfaces)(struct lxc_container *c); > char** (*get_ips)(struct lxc_container *c, const char* interfac

[lxc-devel] LXC master: Legacy Config Items Have Been Removed

Hey everyone, We've been making good progress on the way to 3.0 for all affected projects under the LXC umbrella. One of the more invasive steps we have undertaken yesterday is to remove the support for all legacy configuration items from the LXC master branch. We have announced this back when LXC

Re: [lxc-devel] improving compatibility with RHEL 7.4 in templates/lxc-centos.in

On Wed, Feb 07, 2018 at 10:43:00AM +0100, Christian Brauner wrote: > Hey, > > On Wed, Feb 07, 2018 at 09:26:47AM +0100, Harald Dunkel wrote: > > Hi folks, > > > > attached you can find a patch for the lxc-centos template > > script, making it more compatible wit

Re: [lxc-devel] improving compatibility with RHEL 7.4 in templates/lxc-centos.in

Hey, On Wed, Feb 07, 2018 at 09:26:47AM +0100, Harald Dunkel wrote: > Hi folks, > > attached you can find a patch for the lxc-centos template > script, making it more compatible with RHEL 7.4. > > Issues fixed: > - lxc-centos died about a missing /run directory > - lxc-centos complained about so

[lxc-devel] lxc: issue cleanups

Hey everyone, We are currently in the process of cleaning up the lxc issue list on Github ( https://github.com/lxc/lxc/issues ). This may cause some issues to be closed that you still consider relevant. Please do not take this as a slight. We're mainly doing this because a bunch of those issues ha

Re: [lxc-devel] About PID in cgroup.procs

On Wed, Nov 29, 2017 at 09:31:08AM +, Tian, Xianting (NSB - CN/Hangzhou) wrote: > Hi, > Sorry to trouble you, lxc experts. I met one confusion as below, could > you spare one minute to help me? > I created a container by "lxc-create" on CentOS host(lxc tool version > is > lxc-1.0.1.tar.gz

Re: [lxc-devel] lxc-stop: umount issue?

On Sun, Dec 10, 2017 at 12:59:23PM +0100, Harald Dunkel wrote: > On 12/07/17 22:30, Serge E. Hallyn wrote: > > > > What filesystem are you using? > > ext4 on a drbd block device: > > /dev/drbd1 /data1 ext4 rw,noatime,stripe=256,data=ordered 0 0 What is the container's config file? liblxc itself

Re: [lxc-devel] Suggestions regarding (ultimately) LXC 2.1.0 lxc-update-config

On Wed, Oct 04, 2017 at 03:35:08PM -0400, Adrian Pepper wrote: > Does mentioning lxc.pivotdir really need to be a fatal error? Currently > it seems fatal to the degree that "lxc-ls -f" does not show the > container at all, not RUNNING and not STOPPED. As I said in my previous mail, we've merged a

Re: [lxc-devel] [lxc-users] Container startup hook arguments

On Wed, Oct 04, 2017 at 09:35:25AM -0500, Serge Hallyn wrote: > Quoting Kees Bos (cornelis@gmail.com): > > I'm not using it, but do expect the extra args: > > > > while [ {{ '${#@}' }} -gt 3 ] ; do > >    ... > >    shift > > done > > > > It might be that some users will need the last extra a

Re: [lxc-devel] [lxc-users] Suggestions regarding (ultimately) LXC 2.1.0 lxc-update-configy

On Wed, Oct 04, 2017 at 06:53:16PM -0500, Serge Hallyn wrote: > agreed to both, lxc-update-config should delete it, and it should be > (initially the only) member of a (new) group of keys to ignore, bc I sent a branch [1] that does: - removes lxc.kmsg and lxc.pivotdir from config files if deteced

Re: [lxc-devel] [PATCH] trivial fix for src/lxc/conf.c

Hi Michael, On Wed, Aug 23, 2017 at 02:00:47PM +0300, Michael Shigorin wrote: > Hello Christian, > here's a one-byte fix for one of your LXC commits. Thanks for the patch! Applied and added as part of my PR https://github.com/lxc/lxc/pull/1757 CCing lxc-devel. Thanks! Christian > > --

Re: [lxc-devel] lxc-create: file-based capabilities are lost

Merged the patch today. Thanks guys!___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel

Re: [lxc-devel] LXD image creation tool

Hi, We're certainly not opposed to moving the image bits to a separate package. Especially, if you'd write the patch. At least I don't see any reason not to do it. I'll forward this to Stéphane as well. If you want you can open this as a separate topic on discuss.linuxcontainers.org. It will have

Re: [lxc-devel] [PATCH] Allow containers to start in AppArmor namespaces

Hi Frédéric, Thanks for the patch. Just an fyi, we now prefer a Github/PR-based workflow so next time you send a patch you can also open a PR against or repo in case you have Github account. You don't need to do it for this patch. I've picked it from here and made a PR: https://github.com/lxc/lxc/

Re: [lxc-devel] lxc_copy arguments left out in stable tags from master

Hi Lars, If I'm not completely​ mistaken then I answered the same question by one of your colleagues yesterday. :) So here's the gist. As is said in the readme for the LXC repo we are following a strictly semantic versioning scheme. Since the last Major version bump to 2.0.0 we have only been bump

Re: [lxc-devel] update from LXC 1.1.5 to 2.0.7: command hangs

This is likely not lxc-attach's fault. It seems that timeout is sending SIGTTOU to the process it monitors. If you send this to a tty it will stop until it receives a continue signal. So this behaviour is, I'd argue, correct. Newer versions of lxc-attach allocate a tty whenever they can to prevent

Re: [lxc-devel] Networking issue

Hi, can you please open a bug on https://github.com/lxc/lxc ? Please specify your operating system version and how to reproduce. Thanks. :) Christian On Wed, Nov 09, 2016 at 01:33:55AM -0500, Saint Michael wrote: > It was working fine until a week ago. > I have two sites, it happened on both, so

Re: [lxc-devel] [lxc/master] tree-wide: replace readdir_r() with readdir()

On Wed, Aug 10, 2016 at 10:32:58AM -0500, Serge Hallyn wrote: > No. > > readdir is not thread-safe. assuming that glibc has made readdir thread-safe > and therefore deprecated readdir_r, then we have to work harder to be safe > backward-compatible. POSIX seems to require that multiple calls to r

Re: [lxc-devel] [PATCH v2] open_without_symlink: Don't SYSERROR on something else than ELOOP

Hi, I've applied your changes to a local branch of mine to have them tested by our Jenkins testsuite: https://github.com/lxc/lxc/pull/911 Once that passes I'll merge (Your authorship and signoff are of course preserved!). Best Christian On Wed, Mar 23, 2016 at 12:30:05PM +, Bogdan

Re: [lxc-devel] cgroup V2 and LXC

On Mon, Feb 15, 2016 at 07:48:05PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christian.brau...@mailbox.org): > > On Wed, Feb 10, 2016 at 05:45:48PM +, Serge Hallyn wrote: > > > Quoting Christian Brauner (christian.brau...@mailbox.org): > > > > On M

Re: [lxc-devel] cgroup V2 and LXC

On Wed, Feb 10, 2016 at 05:45:48PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christian.brau...@mailbox.org): > > On Mon, Feb 01, 2016 at 04:56:08AM +, Serge Hallyn wrote: > > > Quoting Kevin Wilson (wkev...@gmail.com): > > > > Hi, LXC developer

Re: [lxc-devel] cgroup V2 and LXC

On Mon, Feb 01, 2016 at 04:56:08AM +, Serge Hallyn wrote: > Quoting Kevin Wilson (wkev...@gmail.com): > > Hi, LXC developers, > > > > The latest kernel release (4.4) includes initial support to cgroup v2 > > with 2 controllers (memory and io). Also it seems that the PIDs > > controller works i

Re: [lxc-devel] PID of a process inside an lxc container

On Wed, Feb 03, 2016 at 04:49:04PM +0200, Kevin Wilson wrote: > Hi, > > When I create an lxc container and run a simple process (which all it > does is call pause()), > I see the pid of this process also in the host (Simply by running ps > aux | grep pause). > And of course I see it also inside th

Re: [lxc-devel] [PATCH] lxc-copy: cleanup

On Jan 29, 2016 19:00, "Serge Hallyn" wrote: > > Quoting Christian Brauner (christian.brau...@mailbox.org): > > Signed-off-by: Christian Brauner > > So on this free_mnts() thing. If you (as this patch makes it look > like you were risking) run it twice, you'

[lxc-devel] [PATCH] Remove wrong command line arg from help output

Signed-off-by: Christian Brauner --- Slipped my attention before unfortunately. --- src/lxc/lxc_ls.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/lxc/lxc_ls.c b/src/lxc/lxc_ls.c index b7034dc..aae2512 100644 --- a/src/lxc/lxc_ls.c +++ b/src/lxc/lxc_ls.c

[lxc-devel] [PATCH] lxc-copy: cleanup

Signed-off-by: Christian Brauner --- src/lxc/lxc_copy.c | 44 ++-- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/src/lxc/lxc_copy.c b/src/lxc/lxc_copy.c index 9812176..5919bf6 100644 --- a/src/lxc/lxc_copy.c +++ b/src/lxc/lxc_copy.c

[lxc-devel] [PATCH 2/3] Restore old behaviour [filter] behaviour

passing the regex. Signed-off-by: Christian Brauner --- src/lxc/arguments.h | 2 +- src/lxc/lxc_ls.c| 37 - 2 files changed, 21 insertions(+), 18 deletions(-) diff --git a/src/lxc/arguments.h b/src/lxc/arguments.h index a3d2932..46fecbf 100644 --- a/src

[lxc-devel] [PATCH 3/3] lxc-ls: tweak algorithm for ls_has_all_grps()

h 50-100 groups and regularly use lxc-ls with -g/--groups to only show containers that have 50 specified groups among their 50-100 groups we can revisit this issue and implement e.g. binary search or a ternary search tree. Signed-off-by: Christian Brauner --- src/lxc/arguments.h | 3 +--

[lxc-devel] [PATCH 1/3] lxc-ls: check for ENOMEM and tweaking

ble within ls_get() and not in main() while at the same time giving us an easy way to share lockpath amongst all non-fork()ing recursive calls to ls_get(). Signed-off-by: Christian Brauner --- src/lxc/lxc_ls.c | 106 +-- 1 file changed, 72

[lxc-devel] [PATCH 0/3 - Previously Acked-by Serge (cc-ing him nonetheless]

Christian Brauner (3): lxc-ls: check for ENOMEM and tweaking Restore old behaviour [filter] behaviour lxc-ls: tweak algorithm for ls_has_all_grps() src/lxc/arguments.h | 5 +- src/lxc/lxc_ls.c| 180 +--- 2 files changed, 115 insertions

Re: [lxc-devel] [PATCH] aufs: support multiple lower layers

On Tue, Jan 26, 2016 at 09:07:17PM +0100, Christian Brauner wrote: > On Tue, Jan 26, 2016 at 06:51:04PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > Do it in a safe way by using strstr() to check for the substring ":/"

Re: [lxc-devel] [PATCH] aufs: support multiple lower layers

On Tue, Jan 26, 2016 at 06:51:04PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > Do it in a safe way by using strstr() to check for the substring ":/" should > > ':' be part of a pathname. > > > > Signed-

[lxc-devel] [PATCH] update overlayfs and aufs in lxc.container.conf

Explain that multiple /lower layers can be used. Signed-off-by: Christian Brauner --- doc/lxc.container.conf.sgml.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/lxc.container.conf.sgml.in b/doc/lxc.container.conf.sgml.in index 18ad924..17a027a 100644 --- a/doc

[lxc-devel] [PATCH] aufs: support multiple lower layers

Do it in a safe way by using strstr() to check for the substring ":/" should ':' be part of a pathname. Signed-off-by: Christian Brauner --- src/lxc/bdev/lxcaufs.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/lxc/bdev/lxcaufs.c b/sr

[lxc-devel] [PATCH] lxc-ls: tweak algorithm for ls_has_all_grps()

h 50-100 groups and regularly use lxc-ls with -g/--groups to only show containers that have 50 specified groups among their 50-100 groups we can revisit this issue and implement e.g. binary search or a ternary search tree. Signed-off-by: Christian Brauner --- src/lxc/arguments.h | 3 +--

[lxc-devel] [PATCH] Adapt manpage for lxc-ls to new C implementation

- explain new numeric argument to --nesting - include common options as lxc-ls now uses the standard lxc parser - add history section and update authors Signed-off-by: Christian Brauner --- Changelog: 2016-01-20T0206: - Leave existing copyright statement untouched

[lxc-devel] [PATCH] lxc-ls: Restore old [filter] behaviour

passing the regex. Signed-off-by: Christian Brauner --- src/lxc/arguments.h | 2 +- src/lxc/lxc_ls.c| 14 -- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/lxc/arguments.h b/src/lxc/arguments.h index a3d2932..46fecbf 100644 --- a/src/lxc/arguments.h +++ b/src

[lxc-devel] [PATCH] lxc.rootfs: support multiple lower layers

Do it in a safe way by using strstr() to check for the substring ":/" should ':' be part of a pathname. This should be a safer implementation than the one originally suggested in #547. Signed-off-by: Christian Brauner --- src/lxc/bdev/lxcoverlay.c | 14 ++

Re: [lxc-devel] [PATCH] lxc-ls: remove unused argument + small fixes

On Tue, Jan 19, 2016 at 09:02:00PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > - remove unused argument from ls_get() > > - Fix ls_has_all_groups() but leave the inefficient basic algorithm > > untouched > > for now. (W

Re: [lxc-devel] [PATCH] Adapt manpage for lxc-ls to new C implementation

On Tue, Jan 19, 2016 at 05:26:59PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > - explain new -r,--regex flag > > - explain new numeric argument to --nesting > > - include common options as lxc-ls now uses the standard lxc par

[lxc-devel] [PATCH] lxc-ls: remove unused argument + small fixes

- remove unused argument from ls_get() - Fix ls_has_all_groups() but leave the inefficient basic algorithm untouched for now. (Will be fixed in a dedicated commit.) - insert missing ; Signed-off-by: Christian Brauner --- src/lxc/lxc_ls.c | 23 --- 1 file changed, 12

[lxc-devel] [PATCH] Adapt manpage for lxc-ls to new C implementation

- explain new -r,--regex flag - explain new numeric argument to --nesting - include common options as lxc-ls now uses the standard lxc parser - add history section and update authors Signed-off-by: Christian Brauner --- doc/lxc-ls.sgml.in | 65

[lxc-devel] [PATCH] Adapt manpage for lxc-ls to new C implementation

- explain new -r,--regex flag - explain new numeric argument to --nesting - include common options as lxc-ls now uses the standard lxc parser - add history section and update authors Signed-off-by: Christian Brauner --- doc/lxc-ls.sgml.in | 65

Re: [lxc-devel] [PATCH v2] lxc-ls: check for ENOMEM and tweaking

On Sat, Jan 16, 2016 at 12:50:01AM +, Serge Hallyn wrote: > Quoting Christian Brauner (christian.brau...@mailbox.org): > > If lxc_container_new() fails we check for ENOMEM and if so goto out. If > > ENOMEM > > is not set we will simply continue. The same goes fo

Re: [lxc-devel] [PATCH] lxc-ls: check for ENOMEM and tweaking

Ignore. On Sat, Jan 16, 2016 at 12:57:24AM +0100, Christian Brauner wrote: > If lxc_container_new() fails we check for ENOMEM and if so goto out. If ENOMEM > is not set we will simply continue. The same goes for the call to regcomp() > but > instead of checking for ENOMEM we need

[lxc-devel] [PATCH v2] lxc-ls: check for ENOMEM and tweaking

don't know if compilers will always optimize this let's move *some* variable declarations outside of the loop when it does not hinder readability Set ls_nesting to 0 initially. Otherwise users will always see nested containers printed. Signed-off-by: Christian Brauner --- Changelog:

[lxc-devel] [PATCH] lxc-ls: check for ENOMEM and tweaking

don't know if compilers will always optimize this let's move *some* variable declarations outside of the loop when it does not hinder readability Set ls_nesting to 0 initially. Otherwise users will always see nested containers printed. Signed-off-by: Christian Brauner --- src/lxc/lxc

Re: [lxc-devel] [PATCH] lxc-ls: check for ENOMEM and tweaking

On Fri, Jan 15, 2016 at 08:40:19PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christian.brau...@mailbox.org): > > If lxc_container_new() fails we check for ENOMEN and goto out if ENOMEM is > > not > > set we will simply continue. The same goes for the

[lxc-devel] [PATCH] lxc-ls: set ls_nesting to 0 initially

Otherwise users will always get nested containers listed. Signed-off-by: Christian Brauner --- src/lxc/lxc_ls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_ls.c b/src/lxc/lxc_ls.c index 7d46426..dd73f19 100644 --- a/src/lxc/lxc_ls.c +++ b/src/lxc/lxc_ls.c

[lxc-devel] [PATCH] lxc-ls: check for ENOMEM and tweaking

know if compilers will always optimize this let's move all variable declarations outside of the loop. They should still be fairly self explanatory. Signed-off-by: Christian Brauner --- src/lxc/lxc_ls.c | 57 1 file changed, 33 inserti

[lxc-devel] [PATCH] check for btrfs fs in should_default_to_snapshot

Check if we're really on a btrfs filesystem before we call btrfs_same_fs(). Otherwise we will report misleading errors although everything went fine. Signed-off-by: Christian Brauner --- src/lxc/bdev/lxcbtrfs.c | 2 +- src/lxc/bdev/lxcoverlay.c | 2 +- src/lxc/lxccontainer.c| 4 ++

[lxc-devel] [PATCH] add lxc-copy to see_also.sgml.in

Signed-off-by: Christian Brauner --- doc/see_also.sgml.in | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/see_also.sgml.in b/doc/see_also.sgml.in index 4954e8e..3b3ecd7 100644 --- a/doc/see_also.sgml.in +++ b/doc/see_also.sgml.in @@ -38,6 +38,11 @@ Foundation, Inc., 51 Franklin

[lxc-devel] [PATCH] lxc-ls: try to protect stack in recursive function

lot of containers your might run into trouble. Signed-off-by: Christian Brauner --- src/lxc/arguments.h | 2 +- src/lxc/lxc_ls.c| 37 ++--- 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/src/lxc/arguments.h b/src/lxc/arguments.h index 898a9ce

[lxc-devel] [PATCH] fix lockpath removal in Python lxc-ls

The lock path for lxc is not RUNTIME_PATH/lock/lxc but rather RUNTIME_PATH/lxc/lock Signed-off-by: Christian Brauner --- src/lxc/lxc-ls.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc-ls.in b/src/lxc/lxc-ls.in index dc2b2ba..b83ee73 100755

Re: [lxc-devel] On the road to LXC 2.0.0

On Wed, Dec 23, 2015 at 08:57:36AM -0700, Tycho Andersen wrote: > On Mon, Dec 21, 2015 at 05:12:12PM -0500, Stéphane Graber wrote: > > Hey everyone, > > > > So you may have noticed I just tagged LXC 2.0.0 beta1. > > > > The current plan is as follow: > > - LXC 2.0.0 beta2 next week (28th) > > -

[lxc-devel] [PATCH] Add concise explanations

- explain functions in list.h - let lxc_list_len() return size_t instead of int Signed-off-by: Christian Brauner --- I'm working on some stuff that employs struct lxc_list. I already previously found that list.h lacked some short documentation so here it is. Adding this documentation mig

[lxc-devel] [PATCH] Conditional compilation for ARM and PPC

Check if symbols SCMP_ARCH_ARM and SCMP_ARCH_PPC are defined. Signed-off-by: Christian Brauner --- src/lxc/seccomp.c | 4 1 file changed, 4 insertions(+) diff --git a/src/lxc/seccomp.c b/src/lxc/seccomp.c index c5f1885..5982cb4 100644 --- a/src/lxc/seccomp.c +++ b/src/lxc/seccomp.c

[lxc-devel] [PATCH] Conditional compilation for ARM and PPC

Before commit 29753076fddfed772511c67887bed1f0621b32cf libseccomp does not define the symbol SCMP_ARCH_PPC. Just for safety also add conditional compilation instructions for SCMP_ARCH_ARM. Christian Brauner (1): Conditional compilation for ARM and PPC src/lxc/seccomp.c | 4 1 file

Re: [lxc-devel] [PATCH] seccomp: support 32-bit arm on arm64, and 32-bit ppc on ppc64

On Wed, Dec 02, 2015 at 10:42:36PM +, Serge Hallyn wrote: > Generally we enforce that a [arch] seccomp section can only be used on [arch]. > However, on amd64 we allow [i386] sections for i386 containers, and there we > also take [all] sections and apply them for both 32- and 64-bit. > > Do th

[lxc-devel] [PATCH] Add manpage for lxc-copy

(A trivial fix for lxc-copy is included.) Signed-off-by: Christian Brauner --- configure.ac | 1 + doc/Makefile.am | 1 + doc/lxc-copy.sgml.in | 291 +++ src/lxc/lxc_copy.c | 2 +- 4 files changed, 294 insertions(+), 1

[lxc-devel] [PATCH] Add manpage for lxc-copy

(A trivial fix for lxc-copy is included.) Signed-off-by: Christian Brauner --- configure.ac | 1 + doc/Makefile.am | 1 + doc/lxc-copy.sgml.in | 291 +++ src/lxc/lxc_copy.c | 2 +- 4 files changed, 294 insertions(+), 1

[lxc-devel] [PATCH] Improve coding style and coding conventions

Local variables should not have the same name as global variables to avoid confusion. Signed-off-by: Christian Brauner --- src/lxc/lxc_copy.c | 81 +++--- 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/src/lxc/lxc_copy.c b/src/lxc

[lxc-devel] [PATCH v2] Do not pass global variable as pointer

Signed-off-by: Christian Brauner --- src/lxc/lxc_copy.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/lxc/lxc_copy.c b/src/lxc/lxc_copy.c index e5f52d2..be2e3ee 100644 --- a/src/lxc/lxc_copy.c +++ b/src/lxc/lxc_copy.c @@ -123,8 +123,7 @@ Options :\n

[lxc-devel] [PATCH 2/3] Fix mode when creating temporary directory

From: Christian Brauner When we create a random container directory with mkdtemp() we set the mode to 0770 otherwise do_lxcapi_clone() will complain about not being able to create the config. Signed-off-by: Christian Brauner --- src/lxc/lxc_copy.c | 2 ++ 1 file changed, 2 insertions(+) diff

[lxc-devel] [PATCH 1/3] Use correct return when clone fails

From: Christian Brauner When the clone failed we tried to destroy the container. This will lead to a segfault. Instead simply return -1. Also move the call to free_mnts() after the put label to free the user specified mounts even when we just goto put. Signed-off-by: Christian Brauner --- src

[lxc-devel] [PATCH 3/3] Do not pass global variable as pointer

Signed-off-by: Christian Brauner --- src/lxc/lxc_copy.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/lxc/lxc_copy.c b/src/lxc/lxc_copy.c index e5f52d2..791d7a2 100644 --- a/src/lxc/lxc_copy.c +++ b/src/lxc/lxc_copy.c @@ -123,8 +123,7 @@ Options :\n

Re: [lxc-devel] [PATCH v3] Add lxc-copy executable

On Mon, Nov 09, 2015 at 07:55:31PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > This is a complete reimplementation of lxc-clone and lxc-start-ephemeral. > > lxc-copy merges the functionalities of lxc-clone + lxc-start-ephemeral. >

[lxc-devel] [PATCH v3] Add lxc-copy executable

the code considerably shorter. Signed-off-by: Christian Brauner --- src/lxc/Makefile.am | 2 + src/lxc/arguments.h | 2 + src/lxc/lxc_copy.c | 744 3 files changed, 748 insertions(+) create mode 100644 src/lxc/lxc_copy.c diff --git a

[lxc-devel] [PATCH v3] Add lxc-copy executable

brauner/lxc/tree/lxccopy Serge, I wonder how many bugs you will find. :) Christian Brauner (1): Add lxc-copy executable src/lxc/Makefile.am | 2 + src/lxc/arguments.h | 2 + src/lxc/lxc_copy.c | 744 3 files changed, 748 inserti

Re: [lxc-devel] [PATCH v2] Add lxc-copy executable

On Thu, Nov 05, 2015 at 11:15:08PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > This is a complete reimplementation of lxc-clone and lxc-start-ephemeral. > > lxc-copy merges the functionalities of lxc-clone + lxc-start-ephemera

[lxc-devel] [PATCH v2] Add lxc-copy executable

e, I wonder how many bugs you will find. :) Christian Brauner (1): Add lxc-copy executable src/lxc/Makefile.am | 2 + src/lxc/arguments.h | 2 + src/lxc/lxc_copy.c | 744 3 files changed, 748 insertions(+) create mode 10

[lxc-devel] [PATCH v2] Add lxc-copy executable

use mkdtemp() to not just create the names but also directly create the corresponding directories. This will give us more safety and make the code considerably shorter. Signed-off-by: Christian Brauner --- src/lxc/Makefile.am | 2 + src/lxc/arguments.h | 2 + src/lxc/lxc_copy.c | 744

[lxc-devel] [PATCH v1] Add lxc-copy executable

use mkdtemp() to not just create the names but also directly create the corresponding directories. This will give us more safety and make the code considerably shorter. Signed-off-by: Christian Brauner --- src/lxc/Makefile.am | 2 + src/lxc/arguments.h | 2 + src/lxc/lxc_copy.c | 744

[lxc-devel] [PATCH v1] Add lxc-copy executable

. :) Christian Brauner (1): Add lxc-copy executable src/lxc/Makefile.am | 2 + src/lxc/arguments.h | 2 + src/lxc/lxc_copy.c | 744 3 files changed, 748 insertions(+) create mode 100644 src/lxc/lxc_copy.c -- 2.6.2

[lxc-devel] [PATCH v3] Fix calculations in clone_update_unexp_hooks()

(p >= lend) continue; This should deal better with invalid config files. (3) Insert some spaces between operators to increase readability. (4) Use gotos to simplify function and increase readability. Signed-off-by: Christian Brauner --- src/lxc/

[lxc-devel] [PATCH v2] Fix calculations in clone_update_unexp_hooks()

ility. Signed-off-by: Christian Brauner --- src/lxc/confile.c | 60 +++ 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/src/lxc/confile.c b/src/lxc/confile.c index d584964..0565973 100644 --- a/src/lxc/confile.c +++ b/src/lxc/confile

Re: [lxc-devel] [PATCH] Fix wrong calculations in clone_update_unexp_hooks()

On Mon, Nov 02, 2015 at 02:36:13PM +0100, Christian Brauner wrote: > (1) This commit fixes some long standing miscalculation when updating paths in > lxc.hooks.* entries. We now also update conf->unexpandend_alloced which > hasn't been done prior to this commit. Accord

[lxc-devel] [PATCH 2/2 v4] Update absolute paths for overlay and aufs mounts

will still refuse to create upperdir and workdir when the updated path is unclean. This happens easily when e.g. a user calls lxc-clone -o OLD -n NEW -P //home//chb///. Signed-off-by: Christian Brauner --- src/lxc/lxccontainer.c | 100 + 1 file c

[lxc-devel] [PATCH 0/2 v4] Update absolute paths for overlay and aufs mounts

confile.c. (3) Move various temporary variables inside the lxc_list_for_each(iterator, &lxc_conf->mount_list) {*/ do stuff */} per Serge's request. (4) Use uniform exit strategy when the function fails or succeeds. Christian Brauner (3): Add clone_update_unexp_ovl_paths()

[lxc-devel] [PATCH 1/2 v4] Add clone_update_unexp_ovl_paths() function

This functions updates absolute paths for overlay upper- and workdirs so users can simply clone and start new containers without worrying about absolute paths in lxc.mount.entry overlay entries. Signed-off-by: Christian Brauner --- src/lxc/confile.c | 96

Re: [lxc-devel] [PATCH 1/2 v3] Add clone_update_unexp_ovl_paths() function

On Mon, Nov 02, 2015 at 02:38:16PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > This functions updates absolute paths for overlay upper- and workdirs so > > users > > can simply clone and start new containers without wo

Re: [lxc-devel] [PATCH 1/2 v3] Add clone_update_unexp_ovl_paths() function

On Nov 2, 2015 6:43 PM, "Serge Hallyn" wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Mon, Nov 02, 2015 at 03:52:25PM +0100, Christian Brauner wrote: > > > On Mon, Nov 02, 2015 at 02:38:16PM +, Serge Hallyn wrote: &g

Re: [lxc-devel] [PATCH 1/2 v3] Add clone_update_unexp_ovl_paths() function

On Mon, Nov 02, 2015 at 03:52:25PM +0100, Christian Brauner wrote: > On Mon, Nov 02, 2015 at 02:38:16PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > This functions updates absolute paths for overlay upper- and workdirs so >

Re: [lxc-devel] [PATCH 2/2 v3] Update absolute paths for overlay and aufs mounts

On Mon, Nov 02, 2015 at 03:12:02PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > When using overlay and aufs mounts with lxc.mount.entry users have to > > specify > > absolute paths for upperdir and workdir which

Re: [lxc-devel] [PATCH 1/2 v3] Add clone_update_unexp_ovl_paths() function

On Mon, Nov 02, 2015 at 02:38:16PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > This functions updates absolute paths for overlay upper- and workdirs so > > users > > can simply clone and start new containers without wo

Re: [lxc-devel] [PATCH 1/2 v3] Add clone_update_unexp_ovl_paths() function

On Mon, Nov 02, 2015 at 02:38:16PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > This functions updates absolute paths for overlay upper- and workdirs so > > users > > can simply clone and start new containers without wo

[lxc-devel] [PATCH] Fix wrong calculations in clone_update_unexp_hooks()

ot; when using lxc-clone. (2) Also we use the stricter check: if (p >= lend) continue; This should deal better with invalid config files. (3) Insert some spaces between operators to increase readability. Signed-off-by: Christian Brauner --- s

[lxc-devel] [PATCH 0/2 v3] Update absolute paths for overlay and aufs mounts

unexpanded_config by using a separate function clone_update_unexp_ovl_dir() in confile.c. (3) Move various temporary variables inside the lxc_list_for_each(iterator, &lxc_conf->mount_list) {*/ do stuff */} per Serge's request. (4) Use uniform exit strategy when the function

[lxc-devel] [PATCH 2/2 v3] Update absolute paths for overlay and aufs mounts

will still refuse to create upperdir and workdir when the updated path is unclean. This happens easily when e.g. a user calls lxc-clone -o OLD -n NEW -P //home//chb///. Signed-off-by: Christian Brauner --- src/lxc/lxccontainer.c | 98 ++ 1 file

[lxc-devel] [PATCH 1/2 v3] Add clone_update_unexp_ovl_paths() function

This functions updates absolute paths for overlay upper- and workdirs so users can simply clone and start new containers without worrying about absolute paths in lxc.mount.entry overlay entries. Signed-off-by: Christian Brauner --- src/lxc/confile.c | 102

[lxc-devel] Fwd: Re: [PATCH 2/2 v2] Update absolute paths for overlay and aufs mounts

-- Forwarded message -- From: "Christian Brauner" Date: Oct 30, 2015 4:27 PM Subject: Re: [PATCH 2/2 v2] Update absolute paths for overlay and aufs mounts To: "Serge E. Hallyn" Cc: "lxc-dev" > > On Oct 30, 2015 4:22 PM, "Serge Hallyn&q

Re: [lxc-devel] [PATCH 1/2 v2] Add clone_update_unexp_ovl_dir() function

On Oct 30, 2015 4:08 PM, "Serge Hallyn" wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > This functions updates absolute paths for overlay upper- and workdirs so users > > can simply clone and start new containers without worrying

[lxc-devel] [PATCH 1/2 v2] Add clone_update_unexp_ovl_dir() function

This functions updates absolute paths for overlay upper- and workdirs so users can simply clone and start new containers without worrying about absolute paths in lxc.mount.entry overlay entries. Signed-off-by: Christian Brauner --- src/lxc/confile.c | 103

[lxc-devel] [PATCH 2/2 v2] Update absolute paths for overlay and aufs mounts

_dirs() and mount_entry_create_aufs_dirs() will still refuse to create upperdir and workdir when the updated path is unclean. This happens easily when e.g. a user calls lxc-clone -o OLD -n NEW -P //home//chb///. Signed-off-by: Christian Brauner --- src/lxc/lxcconta

<    1   2   3   4   5   6   >