Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-15 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Tue, Sep 15, 2015 at 12:57:26AM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > The easiest way to achieve this would be to #include lxccontainer.h in > > > utils.h > > > because we need

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Tue, Sep 15, 2015 at 12:57:26AM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Mon, Sep 14, 2015 at 08:51:08PM +, Serge Hallyn wrote: > > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > > On Mon, Sep 14, 2015 at 08:31:59PM +0

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Mon, Sep 14, 2015 at 10:54:34PM +, Serge Hallyn wrote: > > > Does it help if we simply define c->delete_with_snapshot_clones(), and > > > have > > > src/lxc/destroy.c use that?

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Mon, Sep 14, 2015 at 10:54:34PM +, Serge Hallyn wrote: > > Does it help if we simply define c->delete_with_snapshot_clones(), and have > > src/lxc/destroy.c use that? Then we can contain mod_all_rdeps to being a > > static functio

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Mon, Sep 14, 2015 at 10:54:34PM +, Serge Hallyn wrote: > Does it help if we simply define c->delete_with_snapshot_clones(), and have > src/lxc/destroy.c use that? Then we can contain mod_all_rdeps to being a > static function in src/lxc/lxccontainer.c If not, remind me where else we > woul

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Mon, Sep 14, 2015 at 08:51:08PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > On Mon, Sep 14, 2015 at 08:31:59PM +, Serge Hallyn wrote: > > > > Quoting Christian Brauner (christianv

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Mon, Sep 14, 2015 at 08:51:08PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Mon, Sep 14, 2015 at 08:31:59PM +, Serge Hallyn wrote: > > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > > On Mon, Sep 14, 2015 at 07:27:06PM +0

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Mon, Sep 14, 2015 at 08:31:59PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > On Mon, Sep 14, 2015 at 07:27:06PM +, Serge Hallyn wrote: > > > > Quoting Christian Brauner (christianv

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Mon, Sep 14, 2015 at 08:31:59PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Mon, Sep 14, 2015 at 07:27:06PM +, Serge Hallyn wrote: > > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > > On Mon, Sep 14, 2015 at 04:33:05PM +0

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Mon, Sep 14, 2015 at 07:27:06PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > On Mon, Sep 14, 2015 at 04:33:05PM +, Serge Hallyn wrote: > > > > Quoting Serge Hallyn (serge.hal...@ub

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Mon, Sep 14, 2015 at 07:27:06PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Mon, Sep 14, 2015 at 04:33:05PM +, Serge Hallyn wrote: > > > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > > > > Quoting Christian Brauner (christianvanbrau...@g

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Mon, Sep 14, 2015 at 07:27:06PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Mon, Sep 14, 2015 at 04:33:05PM +, Serge Hallyn wrote: > > > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > > > > Quoting Christian Brauner (christianvanbrau...@g

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Mon, Sep 14, 2015 at 04:33:05PM +, Serge Hallyn wrote: > > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > > On Mon, Sep 14, 2015 at 02:50:39PM +, Serge Hal

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Mon, Sep 14, 2015 at 04:33:05PM +, Serge Hallyn wrote: > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > On Mon, Sep 14, 2015 at 02:50:39PM +, Serge Hallyn wrote: > > > > Quoting Christian Brauner (christianvanbrau...@g

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Mon, Sep 14, 2015 at 02:50:39PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > When creating ephemeral containers that have the option lxc.ephemeral = 1 > > > set > > > in their config,

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Mon, Sep 14, 2015 at 02:50:39PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > When creating ephemeral containers that have the option lxc.ephemeral = 1 > > set > > in their config, they will be destroyed on shutdown. As they are simple > > overlay

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Mon, Sep 14, 2015 at 02:50:39PM +, Serge Hallyn wrote: > > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > > When creating ephemeral containers that have the op

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Mon, Sep 14, 2015 at 02:50:39PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > When creating ephemeral containers that have the option lxc.ephemeral = 1 > > > set > > > in their config,

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Mon, Sep 14, 2015 at 02:50:39PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > When creating ephemeral containers that have the option lxc.ephemeral = 1 > > set > > in their config, they will be destroyed on shutdown. As they are simple > > overlay

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Christian Brauner
On Mon, Sep 14, 2015 at 03:03:58PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > When creating ephemeral containers that have the option lxc.ephemeral = 1 > > set > > in their config, they will be destroyed on shutdown. As they are simple > > overlay

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > When creating ephemeral containers that have the option lxc.ephemeral = 1 set > in their config, they will be destroyed on shutdown. As they are simple > overlay > clones of an existing container they should be registered in the lxc_snap

Re: [lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-14 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > When creating ephemeral containers that have the option lxc.ephemeral = 1 set > in their config, they will be destroyed on shutdown. As they are simple > overlay > clones of an existing container they should be registered in the lxc_snap

[lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-10 Thread Christian Brauner
When creating ephemeral containers that have the option lxc.ephemeral = 1 set in their config, they will be destroyed on shutdown. As they are simple overlay clones of an existing container they should be registered in the lxc_snapshots file of the original container to stay consistent and adhere t

[lxc-devel] [PATCH] Add remove_snapshots_entry() (rebased - v2)

2015-09-10 Thread Christian Brauner
When creating ephemeral containers that have the option lxc.ephemeral = 1 set in their config, they will be destroyed on shutdown. As they are simple overlay clones of an existing container they should be registered in the lxc_snapshots file of the original container to stay consistent and adhere t

[lxc-devel] [PATCH] Add remove_snapshots_entry()

2015-09-10 Thread Christian Brauner
When creating ephemeral containers that have the option lxc.ephemeral = 1 set in their config, they will be destroyed on shutdown. As they are simple overlay clones of an existing container they should be registered in the lxc_snapshots file of the original container to stay consistent and adhere t

[lxc-devel] [PATCH] Add remove_snapshots_entry()

2015-09-10 Thread Christian Brauner
When creating ephemeral containers that have the option lxc.ephemeral = 1 set in their config, they will be destroyed on shutdown. As they are simple overlay clones of an existing container they should be registered in the lxc_snapshots file of the original container to stay consistent and adhere t