Re: [lxc-devel] [PATCH v2] Cleanup parts of lxc-destroy

2015-09-30 Thread Serge Hallyn
The same anti-goto was originally pounded into me, then I did some kernel coding and saw how nice it can be compared to alternatives :) fwiw, the plus side of the goto in this case is to commonize the work to be done before the next loop (in this case just a 'counter++'). The minus side is that "

Re: [lxc-devel] [PATCH v2] Cleanup parts of lxc-destroy

2015-09-30 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > A bit of pedantry usually doesn't hurt. The code should be easier to follow > now > and avoids some repetitions. > > Signed-off-by: Christian Brauner Note I still don't really feel the first hunk is an improvement in readability, but

Re: [lxc-devel] [PATCH v2] Cleanup parts of lxc-destroy

2015-09-30 Thread Christian Brauner
Sorry, my teachers pounded a violent hatred for gotos for non-cleanup purposes into me. Thanks. :) On Wed, Sep 30, 2015 at 04:13:12PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > A bit of pedantry usually doesn't hurt. The code should be easier to fol

[lxc-devel] [PATCH v2] Cleanup parts of lxc-destroy

2015-09-29 Thread Christian Brauner
A bit of pedantry usually doesn't hurt. The code should be easier to follow now and avoids some repetitions. Signed-off-by: Christian Brauner --- src/lxc/lxc_destroy.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/lxc/lxc_destroy.c b/src/lx