The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/2525

This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.

=== Description (from pull-request) ===
Dereference before null check

Signed-off-by: 2xsec <dh48.je...@samsung.com>
From 6926e3b80ede8f19d02ad58fc160b5b4b6aff58e Mon Sep 17 00:00:00 2001
From: 2xsec <dh48.je...@samsung.com>
Date: Tue, 14 Aug 2018 13:29:50 +0900
Subject: [PATCH] coverity: #1438392

Dereference before null check

Signed-off-by: 2xsec <dh48.je...@samsung.com>
---
 src/lxc/pam/pam_cgfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/lxc/pam/pam_cgfs.c b/src/lxc/pam/pam_cgfs.c
index 6d1d468d9..2975b6456 100644
--- a/src/lxc/pam/pam_cgfs.c
+++ b/src/lxc/pam/pam_cgfs.c
@@ -1897,8 +1897,7 @@ static bool cg_filter_and_set_cpus(char *path, bool 
am_initialized)
 copy_parent:
        *lastslash = oldv;
 
-       if (fpath)
-               free(fpath);
+       free(fpath);
 
        fpath = must_make_path(path, "cpuset.cpus", NULL);
        ret = write_to_file(fpath, cpulist, strlen(cpulist), false);
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel

Reply via email to