Re: [lxc-devel] lxc-clone rewrite

2015-09-06 Thread Christian Brauner
These commits enable a container to be destroyed on shutdown by setting lxc.ephemeral = 1 in its configuration file. This will allow us a consistent implementation of lxc-copy = lxc-clone + lxc-start-ephemeral without having to resort to hacks. Small changes: lxc_delete_string_in_array() has

Re: [lxc-devel] lxc-clone rewrite

2015-09-04 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Mon, Aug 31, 2015 at 09:53:03PM +0200, Christian Brauner wrote: > > On Mon Aug 31, 2015 at 04:08:33PM +, Serge Hallyn wrote: > > > Quoting Stéphane Graber (stgraber at ubuntu.com): > > > > On Mon, Aug 31, 2015 at 01:43:07PM +,

Re: [lxc-devel] lxc-clone rewrite

2015-09-04 Thread Stéphane Graber
On Fri, Sep 04, 2015 at 04:21:42PM +0200, Christian Brauner wrote: > On Fri, Sep 04, 2015 at 02:04:29PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > On Mon, Aug 31, 2015 at 09:53:03PM +0200, Christian Brauner wrote: > > > > On Mon Aug 31, 2015 at

Re: [lxc-devel] lxc-clone rewrite

2015-09-04 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > diff --git a/src/lxc/conf.h b/src/lxc/conf.h > index dc5328a..6e75713 100644 > --- a/src/lxc/conf.h > +++ b/src/lxc/conf.h > @@ -370,6 +370,9 @@ struct lxc_conf { >* should run under when using lxc-execute */ > uid_t

Re: [lxc-devel] lxc-clone rewrite

2015-09-04 Thread Stéphane Graber
On Fri, Sep 04, 2015 at 07:42:50PM +0200, Christian Brauner wrote: > On Fri, Sep 04, 2015 at 01:11:14PM -0400, Stéphane Graber wrote: > > On Fri, Sep 04, 2015 at 04:21:42PM +0200, Christian Brauner wrote: > > > On Fri, Sep 04, 2015 at 02:04:29PM +, Serge Hallyn wrote: > > > > Quoting Christian

Re: [lxc-devel] lxc-clone rewrite

2015-09-04 Thread Christian Brauner
On Mon, Aug 31, 2015 at 09:53:03PM +0200, Christian Brauner wrote: > On Mon Aug 31, 2015 at 04:08:33PM +, Serge Hallyn wrote: > > Quoting Stéphane Graber (stgraber at ubuntu.com): > > > On Mon, Aug 31, 2015 at 01:43:07PM +, Serge Hallyn wrote: > > > > Quoting Christian Brauner

Re: [lxc-devel] lxc-clone rewrite

2015-08-31 Thread Christian Brauner
On Fri, Aug 28, 2015 at 12:46:17AM +0200, Christian Brauner wrote: > On Thu, Aug 27, 2015 at 03:41:03PM -0400, Stéphane Graber wrote: > > On Sun, Aug 16, 2015 at 04:46:31PM +, Serge Hallyn wrote: > > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > Hey, > > > > > > I'll

Re: [lxc-devel] lxc-clone rewrite

2015-08-31 Thread Stéphane Graber
On Mon, Aug 31, 2015 at 01:43:07PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > On Fri, Aug 28, 2015 at 12:46:17AM +0200, Christian Brauner wrote: > > > On Thu, Aug 27, 2015 at 03:41:03PM -0400, Stéphane Graber wrote: > > > > On Sun, Aug 16, 2015 at

Re: [lxc-devel] lxc-clone rewrite

2015-08-31 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Mon, Aug 31, 2015 at 01:43:07PM +, Serge Hallyn wrote: > > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > > On Fri, Aug 28, 2015 at 12:46:17AM +0200, Christian Brauner wrote: > > > > On Thu, Aug 27, 2015 at 03:41:03PM -0400,

Re: [lxc-devel] lxc-clone rewrite

2015-08-31 Thread Christian Brauner
On Mon Aug 31, 2015 at 04:08:33PM +, Serge Hallyn wrote: > Quoting Stéphane Graber (stgraber at ubuntu.com): > > On Mon, Aug 31, 2015 at 01:43:07PM +, Serge Hallyn wrote: > > > Quoting Christian Brauner (christianvanbrauner at gmail.com): > > > > On Fri, Aug 28, 2015 at 12:46:17AM +0200,

Re: [lxc-devel] lxc-clone rewrite

2015-08-31 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): > On Fri, Aug 28, 2015 at 12:46:17AM +0200, Christian Brauner wrote: > > On Thu, Aug 27, 2015 at 03:41:03PM -0400, Stéphane Graber wrote: > > > On Sun, Aug 16, 2015 at 04:46:31PM +, Serge Hallyn wrote: > > > > Quoting Christian Brauner

Re: [lxc-devel] lxc-clone rewrite

2015-08-27 Thread Christian Brauner
On Thu, Aug 27, 2015 at 03:41:03PM -0400, Stéphane Graber wrote: On Sun, Aug 16, 2015 at 04:46:31PM +, Serge Hallyn wrote: Quoting Christian Brauner (christianvanbrau...@gmail.com): Integrating lxc-clone with the standard lxc parser is not possible unless it is allowed to change

Re: [lxc-devel] lxc-clone rewrite

2015-08-16 Thread Serge Hallyn
Quoting Christian Brauner (christianvanbrau...@gmail.com): Integrating lxc-clone with the standard lxc parser is not possible unless it is allowed to change command line options. lxc-clone uses -n, -P and -o in a way that is inconsistent with the standard lxc common options defined in

[lxc-devel] lxc-clone rewrite

2015-08-14 Thread Christian Brauner
Integrating lxc-clone with the standard lxc parser is not possible unless it is allowed to change command line options. lxc-clone uses -n, -P and -o in a way that is inconsistent with the standard lxc common options defined in LXC_COMMON_OPTIONS in arguments.h and the parser in arguments.c. Since