Re: [lxc-devel] [PATCH] Use pthread_atfork() to unlock mutexes after fork()

2014-01-02 Thread Stéphane Graber
On Wed, Jan 01, 2014 at 11:37:32PM -0600, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): This patch caused a build failure on Android: arm-linux-androideabi-gcc --sysroot=/tmp/android-build-scripts/android-ndk-r9b/platforms/android-9/arch-arm/ -DHAVE_CONFIG_H -I.

Re: [lxc-devel] [PATCH] Use pthread_atfork() to unlock mutexes after fork()

2014-01-02 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): On Wed, Jan 01, 2014 at 11:37:32PM -0600, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): This patch caused a build failure on Android: arm-linux-androideabi-gcc

Re: [lxc-devel] [PATCH] remove the return value of attach_ns.

2014-01-02 Thread Serge Hallyn
Quoting Rami Rosen (ramir...@gmail.com): This method removes the return value of the attach_ns() method as it is not needed and not used. Signed-off-by: Rami Rosen ramir...@gmail.com I think it'd be better to fail on error at the callers - if we failed to switch namespaces and proceed in

Re: [lxc-devel] [PATCH] remove static_lock()/static_unlock() and start to use thread local storage (v2)

2014-01-02 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): Hi, What about reverting the revert and then do something like following? The question is whether we want to consider use of threads on android unsupported for now or not. If so, then we can do what you suggest, as well as ignore the missing

[lxc-devel] [lxc/lxc] 74a392: Mark functions as static and arguments/arrays as c...

2014-01-02 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 74a3920a972e837263436bd67a73eabd42754124 https://github.com/lxc/lxc/commit/74a3920a972e837263436bd67a73eabd42754124 Author: Andrey Mazo m...@telum.ru Date: 2014-01-02 (Thu, 02 Jan 2014) Changed paths: M

Re: [lxc-devel] [PATCH 2/3] Mark functions as static and arguments/arrays as const where possible

2014-01-02 Thread Serge Hallyn
Quoting Andrey Mazo (m...@telum.ru): Mark most of functions that are used within only one file as static. After 95ee490bbdb97ab2b4f1dfa63a0a26e0dd1c2f17 it's easy to prove they are not in public API. Several arrays and structs are also marked static. This prevents them from being exported

Re: [lxc-devel] [PATCH] Bring static and const to tests too

2014-01-02 Thread Serge Hallyn
Quoting Andrey Mazo (m...@telum.ru): Signed-off-by: Andrey Mazo m...@telum.ru Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/tests/attach.c | 2 +- src/tests/concurrent.c | 4 ++-- src/tests/list.c| 2 +- src/tests/locktests.c | 2 +- src/tests/may_control.c |

Re: [lxc-devel] Variable expansions in default config.

2014-01-02 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): Hey all, I'm in the middle of some cleanup and fix-ups in the Fedora and CentOS templates including hardening the root password and some static MAC address code and generally reconciling the two templates into some semblance of coherency.

Re: [lxc-devel] [PATCH] Additional logic for dealing with container shutdown / reboot

2014-01-02 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): Additional logic for dealing with container shutdown / reboot Fix a problem with CentOS containers and legacy Fedora (16) containers not shutting down or rebooting properly. Copy /etc/init.d/halt to /etc/init.d/lxc-halt, deleting everything

[lxc-devel] [Errored] lxc/lxc#9 (master - 64b1be2)

2014-01-02 Thread Travis CI
Build Update for lxc/lxc - Build: #9 Status: Errored Duration: 10 minutes and 27 seconds Commit: 64b1be2 (master) Author: Serge Hallyn Message: Revert Use pthread_atfork() to unlock mutexes after fork() This reverts commit

Re: [lxc-devel] [RFC] [PATCH] Multiple fixes for the ArchLinux template

2014-01-02 Thread Serge Hallyn
Quoting Leonid Isaev (lis...@umail.iu.edu): Multiple fixes for the ArchLinux template: 1. Add some packages from base group to the pkg install list. 2. Better comment and clean up the default container config, namely: (i) remove duplicate and conflicting entries, (ii) constrain list of

Re: [lxc-devel] [PATCH 1/2] change lxc-autostart shutdown to behave like lxc-stop

2014-01-02 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): It is desirable to have a mode where a soft shutdown is requested, but then do a hard shutdown if after some time period the container has not shut down. This the default behaviour of lxc-stop, but is not currently possible with lxc-autostart.

Re: [lxc-devel] [Errored] caglar10ur/lxc-upstream#8 (master - 9a97d4e)

2014-01-02 Thread S . Çağlar Onur
Hi Stéphane, On Wed, Jan 1, 2014 at 5:14 PM, S.Çağlar Onur cag...@10ur.org wrote: Hey Stéphane, On Wed, Jan 1, 2014 at 4:47 PM, Stéphane Graber stgra...@ubuntu.com wrote: Caglar, any chance you can drop that travis job so we don't get notified twice of every failure? Ah of course, I

Re: [lxc-devel] [PATCH 1/2] change lxc-autostart shutdown to behave like lxc-stop

2014-01-02 Thread Dwight Engen
On Thu, 2 Jan 2014 10:59:56 -0600 Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Dwight Engen (dwight.en...@oracle.com): It is desirable to have a mode where a soft shutdown is requested, but then do a hard shutdown if after some time period the container has not shut down. This the

[lxc-devel] [PATCH 1/1] snapshot: enforce keeping same backing store type (v2)

2014-01-02 Thread Serge Hallyn
Stéphane noticed that lxc-snapshot of a dir-backed container created an overlayfs container. The expectation is that the user can continue to modify the original container and later make a new snapshot, but this doesn't work with the existing behavior - the overlayfs clone will end up with the

Re: [lxc-devel] [PATCH 1/2] change lxc-autostart shutdown to behave like lxc-stop

2014-01-02 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): On Thu, 2 Jan 2014 10:59:56 -0600 Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Dwight Engen (dwight.en...@oracle.com): It is desirable to have a mode where a soft shutdown is requested, but then do a hard shutdown if after some

Re: [lxc-devel] lxc systemd unit file

2014-01-02 Thread Michael H. Warfield
Dwight, On Tue, 2013-12-31 at 16:31 -0500, Dwight Engen wrote: Hi Mike, When looking through the sytemd unit file you made with commit 87ff951e as I was doing the sysv init script, I was a bit confused since there is no lxc-startup in libexec nor in the sources, at least not that I could

Re: [lxc-devel] [PATCH 1/2] change lxc-autostart shutdown to behave like lxc-stop

2014-01-02 Thread Michael H. Warfield
On Thu, 2014-01-02 at 13:04 -0600, Serge Hallyn wrote: Quoting Dwight Engen (dwight.en...@oracle.com): On Thu, 2 Jan 2014 10:59:56 -0600 Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Dwight Engen (dwight.en...@oracle.com): It is desirable to have a mode where a soft shutdown