The following pull request was submitted through Github.
It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/2363
This e-mail was sent by the LXC bot, direct replies will not reach the author
unless they happen to be subscribed to this list.
=== Description (from pull-request) ===
Hello,
Function 'va_end' was not called before conf.534 inside function 'run_script'.
Function 'va_start' was called at conf.c:528.
Signed-off-by: Donghwa Jeong <dh48.je...@samsung.com>
From 7b5a2435a2c7ba0cc6bf5a28680bd2e2efea4890 Mon Sep 17 00:00:00 2001
From: Donghwa Jeong <dh48.je...@samsung.com>
Date: Tue, 29 May 2018 22:01:27 +0900
Subject: [PATCH] conf: va_end was not called.
Signed-off-by: Donghwa Jeong <dh48.je...@samsung.com>
---
src/lxc/conf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/lxc/conf.c b/src/lxc/conf.c
index d7984bd0f..4d98074e5 100644
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -530,8 +530,10 @@ int run_script(const char *name, const char *section,
const char *script, ...)
int len = size - ret;
int rc;
rc = snprintf(buffer + ret, len, " %s", p);
- if (rc < 0 || rc >= len)
+ if (rc < 0 || rc >= len) {
+ va_end(ap);
return -1;
+ }
ret += rc;
}
va_end(ap);
_______________________________________________
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel
