Re: [lxc-devel] [PATCH 4/4] lxc-ubuntu: Fix mixed indent

2012-11-29 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Replace all remaining tabs by 8 spaces, to properly indent by 4 spaces. Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- templates/lxc-ubuntu | 18 +- 1 file changed, 9

Re: [lxc-devel] [PATCH 1/4] lxc-ubuntu: Always create the needed locales

2012-11-29 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Move some old code from the trim() function into the main configure_ubuntu function so that we always create a locale in the container. Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com ---

Re: [lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

2012-11-29 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): In addition to creating the current locale in the container, also try to scan the host and extra the list of langpacks installed there, then pass that list to debootstrap as additional packages to install. On distros that don't have dpkg, only

Re: [lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

2012-11-29 Thread Stéphane Graber
On 11/29/2012 09:49 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): In addition to creating the current locale in the container, also try to scan the host and extra the list of langpacks installed there, then pass that list to debootstrap as additional packages to

[lxc-devel] [PATCH] Fix busybox template to not have extra aa_profile hunk

2012-11-29 Thread Dwight Engen
Both 69d66f1e and f02ce27d added the aa_profile = unconfined hunk, but only the first was needed, maybe a merge error? The second one causes the template to get an error on the EOF line. This essentially reverts f02ce27d. Signed-off-by: Dwight Engen dwight.en...@oracle.com ---

Re: [lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

2012-11-29 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): On 11/29/2012 09:49 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): In addition to creating the current locale in the container, also try to scan the host and extra the list of langpacks installed there, then pass that

Re: [lxc-devel] [PATCH] Fix busybox template to not have extra aa_profile hunk

2012-11-29 Thread Stéphane Graber
On 11/29/2012 10:13 AM, Dwight Engen wrote: Both 69d66f1e and f02ce27d added the aa_profile = unconfined hunk, but only the first was needed, maybe a merge error? The second one causes the template to get an error on the EOF line. This essentially reverts f02ce27d. Signed-off-by: Dwight

Re: [lxc-devel] [PATCH 3/4] lxc-ubuntu: Rename from lxc-ubuntu.in

2012-11-29 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): On 11/29/2012 09:52 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): lxc-ubuntu no longer uses any build time variables, therefore it can now be simply copied to the target without any autoconf magic. Signed-off-by:

Re: [lxc-devel] [PATCH] lxc-ubuntu: Fix wrong variable name

2012-11-29 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): $LANGPACK_LIST was renamed to $langpacks but not all the code was updated. Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- templates/lxc-ubuntu | 2 +- 1 file changed, 1 insertion(+),

Re: [lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

2012-11-29 Thread Stéphane Graber
On 11/29/2012 10:18 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On 11/29/2012 09:49 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): In addition to creating the current locale in the container, also try to scan the host and extra the list of

Re: [lxc-devel] [PATCH] Fix build with --enable-tests on Fedora

2012-11-29 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): When using --enable-tests on Fedora, the linker complains with: undefined reference to symbol sem_getvalue, which nm shows to be in libpthread not librt. Build tested on Fedora, Oracle Linux, and Ubuntu. Signed-off-by: Dwight Engen

Re: [lxc-devel] [PATCH] Fix build with --enable-tests on Fedora

2012-11-29 Thread Stéphane Graber
On 11/29/2012 10:24 AM, Serge Hallyn wrote: Quoting Dwight Engen (dwight.en...@oracle.com): When using --enable-tests on Fedora, the linker complains with: undefined reference to symbol sem_getvalue, which nm shows to be in libpthread not librt. Build tested on Fedora, Oracle Linux, and

Re: [lxc-devel] [PATCH] Fix build with --enable-tests on Fedora

2012-11-29 Thread Dwight Engen
On Thu, 29 Nov 2012 09:24:23 -0600 Serge Hallyn serge.hal...@canonical.com wrote: Quoting Dwight Engen (dwight.en...@oracle.com): When using --enable-tests on Fedora, the linker complains with: undefined reference to symbol sem_getvalue, which nm shows to be in libpthread not librt. Build

Re: [lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

2012-11-29 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): On 11/29/2012 10:18 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On 11/29/2012 09:49 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): In addition to creating the current locale in the container,

[lxc-devel] [PATCH 1/1] Description: run MAKEDEV console when doing lxc.autodev

2012-11-29 Thread Serge Hallyn
mounted-dev.conf won't be running that in container's userspace as it previously would have, so make sure that all the devices it would have created (other than ones which lxc later finagles) get created. To achieve this, we have to first mount /dev, then run MAKEDEV, then run setup_autodev to

Re: [lxc-devel] [PATCH 1/1] Description: run MAKEDEV console when doing lxc.autodev

2012-11-29 Thread Stéphane Graber
On 11/29/2012 11:50 AM, Serge Hallyn wrote: mounted-dev.conf won't be running that in container's userspace as it previously would have, so make sure that all the devices it would have created (other than ones which lxc later finagles) get created. To achieve this, we have to first mount /dev,

Re: [lxc-devel] [PATCH 1/1] Description: run MAKEDEV console when doing lxc.autodev

2012-11-29 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): On 11/29/2012 11:50 AM, Serge Hallyn wrote: mounted-dev.conf won't be running that in container's userspace as it previously would have, so make sure that all the devices it would have created (other than ones which lxc later finagles) get

Re: [lxc-devel] [PATCH] Include lxc-ubuntu when doing make dist

2012-11-29 Thread Stéphane Graber
On 11/29/2012 01:27 PM, Dwight Engen wrote: Removing templates/lxc-ubuntu from configure.ac makes it so that it is not included in the tarball that make dist builds (and therefore also breaks the rpm build). Signed-off-by: Dwight Engen dwight.en...@oracle.com --- templates/Makefile.am | 2

Re: [lxc-devel] [PATCH] Include lxc-ubuntu when doing make dist

2012-11-29 Thread Dwight Engen
On Thu, 29 Nov 2012 13:31:41 -0500 Stéphane Graber stgra...@ubuntu.com wrote: On 11/29/2012 01:27 PM, Dwight Engen wrote: Removing templates/lxc-ubuntu from configure.ac makes it so that it is not included in the tarball that make dist builds (and therefore also breaks the rpm build).

[lxc-devel] API wishlist

2012-11-29 Thread Stéphane Graber
So, I've been thinking a bit about what functions we're currently missing in the API which would make the bindings and scripts much easier. So far, I've been thinking of: - get_cgroup_item(cgroup, key) - set_cgroup_item(cgroup, key, value) - attach(namespaces, command) Attach to the

Re: [lxc-devel] API wishlist

2012-11-29 Thread Stéphane Graber
On 11/29/2012 02:42 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): So, I've been thinking a bit about what functions we're currently missing in the API which would make the bindings and scripts much easier. So far, I've been thinking of: - get_cgroup_item(cgroup,

[lxc-devel] [PATCH] make install should create $LXCPATH directory

2012-11-29 Thread Dwight Engen
The $LXCPATH (default /var/lib/lxc) directory was not being created by make install, so unless it gets created by some other means (packaging tools), commands such as lxc-create will fail. Signed-off-by: Dwight Engen dwight.en...@oracle.com --- Makefile.am | 3 +++ lxc.spec.in | 1 + 2 files

[lxc-devel] [PATCH] lxc-create: Store template information in config

2012-11-29 Thread Stéphane Graber
Change lxc-create to add the name of the template and any parameters to the container's configuration. This makes it easier to debug and figure out exactly how a container was built. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-create.in | 9 - 1 file changed, 8