Re: [lxc-devel] API errors

2013-10-04 Thread Serge Hallyn
Quoting Serge Hallyn ([email protected]): > Quoting S.Çağlar Onur ([email protected]): > > Hi, > > > > src/lxc/lxccontainer.h contains two public field named error_string and > > error_num. If I'm not missing anything no one seems to be using them. > > > > What was the intention? Should API c

[lxc-devel] [lxc/lxc] 3157e6: fix errors when using docbook2man

2013-10-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 3157e673952bb857caf98666983eb5c0aec831a9 https://github.com/lxc/lxc/commit/3157e673952bb857caf98666983eb5c0aec831a9 Author: Dwight Engen Date: 2013-10-04 (Fri, 04 Oct 2013) Changed paths: M doc/lxc.conf.s

Re: [lxc-devel] [PATCH] fix errors when using docbook2man

2013-10-04 Thread Serge Hallyn
Quoting Dwight Engen ([email protected]): > docbook2man picks up some errors that docbook2x does not, fixing them > isn't harmful to docbook2x. The only real change is adding and > tags. > > Signed-off-by: Dwight Engen Acked-by: Serge E. Hallyn > --- > doc/lxc.conf.sgml.in | 156 > ++

Re: [lxc-devel] [PATCH] always include the ja manpage sources in make dist

2013-10-04 Thread Serge Hallyn
Quoting Dwight Engen ([email protected]): > These need to be in the dist tarball even if the host packaging system > doesn't have docbook2x, otherwise configure will fail to find them. Also, > the build system may have docbook2x, even if the packaging system does not. > > Signed-off-by: Dwig

[lxc-devel] [lxc/lxc] 0655a6: trivial: remove trailing whitespce from lxc-fedora

2013-10-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 0655a606dad52725eedd8af18a15f246627091f9 https://github.com/lxc/lxc/commit/0655a606dad52725eedd8af18a15f246627091f9 Author: Serge Hallyn Date: 2013-10-04 (Fri, 04 Oct 2013) Changed paths: M templates/lxc-

Re: [lxc-devel] [PATCH] oracle template: add openssh-clients to enable scp in/out of container

2013-10-04 Thread Serge Hallyn
Quoting Dwight Engen ([email protected]): > Signed-off-by: Dwight Engen Acked-by: Serge E. Hallyn > --- > templates/lxc-oracle.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in > index c0fcd30..deed9b3 100644 >

Re: [lxc-devel] [PATCH 1/1] templates/lxc-fedora Network startup w/o Network Manager

2013-10-04 Thread Serge Hallyn
Quoting Michael H. Warfield ([email protected]): > This patches the Fedora template to insure that the legacy network > startup scripts are enabled when NetworkManager has not been installed > in the container (default). > > It also fixes a login problem with pam_loginuid.so in a container. > http

Re: [lxc-devel] API errors

2013-10-04 Thread Serge Hallyn
Quoting S.Çağlar Onur ([email protected]): > Hi, > > src/lxc/lxccontainer.h contains two public field named error_string and > error_num. If I'm not missing anything no one seems to be using them. > > What was the intention? Should API calls set those and stop using macros > like ERROR and SYSERROR

[lxc-devel] API errors

2013-10-04 Thread S . Çağlar Onur
Hi, src/lxc/lxccontainer.h contains two public field named error_string and error_num. If I'm not missing anything no one seems to be using them. What was the intention? Should API calls set those and stop using macros like ERROR and SYSERROR? Cheers, -- S.Çağlar Onur -

[lxc-devel] [PATCH] fix errors when using docbook2man

2013-10-04 Thread Dwight Engen
docbook2man picks up some errors that docbook2x does not, fixing them isn't harmful to docbook2x. The only real change is adding and tags. Signed-off-by: Dwight Engen --- doc/lxc.conf.sgml.in | 156 +-- 1 file changed, 88 insertions(+), 68 deleti

[lxc-devel] [PATCH] always include the ja manpage sources in make dist

2013-10-04 Thread Dwight Engen
These need to be in the dist tarball even if the host packaging system doesn't have docbook2x, otherwise configure will fail to find them. Also, the build system may have docbook2x, even if the packaging system does not. Signed-off-by: Dwight Engen --- doc/Makefile.am | 3 +-- 1 file changed, 1

[lxc-devel] [PATCH] oracle template: add openssh-clients to enable scp in/out of container

2013-10-04 Thread Dwight Engen
Signed-off-by: Dwight Engen --- templates/lxc-oracle.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in index c0fcd30..deed9b3 100644 --- a/templates/lxc-oracle.in +++ b/templates/lxc-oracle.in @@ -516,7 +516,7 @@ container_roo

[lxc-devel] [PATCH 1/1] templates/lxc-fedora Network startup w/o Network Manager

2013-10-04 Thread Michael H. Warfield
This patches the Fedora template to insure that the legacy network startup scripts are enabled when NetworkManager has not been installed in the container (default). It also fixes a login problem with pam_loginuid.so in a container. https://bugzilla.redhat.com/show_bug.cgi?id=966807 Signed-off-by

Re: [lxc-devel] [PATCH 1/1] lxc/conf.c Heuristic determination of autodev condition...

2013-10-04 Thread Serge Hallyn
Quoting Michael H. Warfield ([email protected]): > My second takeaway from the Linux Plumbers conference was to do an > automatic heuristic determination when we should enable autodev > (mounting of something on /dev/ in the container at startup for things > like systemd). If autodev is not enable

Re: [lxc-devel] [PATCH 1/1] templates/lxc-fedora Rework for distro independence.

2013-10-04 Thread Serge Hallyn
Quoting Michael H. Warfield ([email protected]): > > Yum also isn't finding any mirrors, but > > that may be a problem local to me. > > I think that's because the network isn't starting for some reason. I'm > looking into that one now. > > That one looks to be because we have not installed Netwo

Re: [lxc-devel] [PATCH 1/1] templates/lxc-fedora Rework for distro independence.

2013-10-04 Thread Serge Hallyn
Quoting Michael H. Warfield ([email protected]): > Hey Serge, > > On Wed, 2013-10-02 at 23:39 -0500, Serge Hallyn wrote: > > Quoting Michael H. Warfield ([email protected]): > > > +mount -o loop ../LiveOS/squashfs.img squashfs > > > Heh, this is unfortunate - since I test things inside conta

[lxc-devel] [lxc/lxc] fe5c5e: lxc-fedora: remove 4:0 and 4:1 from devices whitel...

2013-10-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: fe5c5ea69323ef9558648645e08d54edd866adf6 https://github.com/lxc/lxc/commit/fe5c5ea69323ef9558648645e08d54edd866adf6 Author: Serge Hallyn Date: 2013-10-04 (Fri, 04 Oct 2013) Changed paths: M templates/lxc-

Re: [lxc-devel] [PATCH 1/1] templates/lxc-fedora Rework for distro independence.

2013-10-04 Thread Michael H. Warfield
Hey Serge, On Wed, 2013-10-02 at 23:39 -0500, Serge Hallyn wrote: > Quoting Michael H. Warfield ([email protected]): > > +mount -o loop ../LiveOS/squashfs.img squashfs > Heh, this is unfortunate - since I test things inside containers, now I > have to face the loop device in containers issue

Re: [lxc-devel] [PATCH] call lxc_container_put when appropriate

2013-10-04 Thread Dwight Engen
On Fri, 4 Oct 2013 08:43:06 -0500 Serge Hallyn wrote: > Quoting S.Çağlar Onur ([email protected]): > > Signed-off-by: S.Çağlar Onur > > I'm torn on that. It's "correct", so doing so shows users what > they should do. OTOH these are programs, not libraries, and will > immediately be exiting, so

[lxc-devel] [lxc/lxc] 2ef89d: lxc-ubuntu: Remove trim option

2013-10-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 2ef89d565c9c8dd79f99ef0d085b924b2ac92951 https://github.com/lxc/lxc/commit/2ef89d565c9c8dd79f99ef0d085b924b2ac92951 Author: Stéphane Graber Date: 2013-10-04 (Fri, 04 Oct 2013) Changed paths: M templates/l

Re: [lxc-devel] [PATCH] call lxc_container_put when appropriate

2013-10-04 Thread Serge Hallyn
Quoting S.Çağlar Onur ([email protected]): > Signed-off-by: S.Çağlar Onur I'm torn on that. It's "correct", so doing so shows users what they should do. OTOH these are programs, not libraries, and will immediately be exiting, so it's not actually necessary. Setting a good example is worthwhile t

Re: [lxc-devel] [PATCH] lxc-ubuntu: Remove trim option

2013-10-04 Thread Serge Hallyn
Quoting Stéphane Graber ([email protected]): > Container trimming is a bad idea in general, Ubuntu since 12.04 allows > standard systems to run in containers and we've got separate code to > deal with 10.04, so let's just drop trim. > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn