Re: [lxc-devel] [PATCH] make sure to check c-lxc_conf is not NULL before dereferencing it.

2013-11-04 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): Signed-off-by: S.Çağlar Onur cag...@10ur.org Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/lxc/lxccontainer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index

[lxc-devel] [lxc/lxc] 497a29: make sure to check c-lxc_conf is not NULL before ...

2013-11-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 497a2995687a56a1f12a69311d8bacbb645e0d97 https://github.com/lxc/lxc/commit/497a2995687a56a1f12a69311d8bacbb645e0d97 Author: S.Çağlar Onur cag...@10ur.org Date: 2013-11-04 (Mon, 04 Nov 2013) Changed paths:

Re: [lxc-devel] [PATCH 1/3] add [gs]et_cgroup_item to lua api

2013-11-04 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@gmail.com): fix up api test to run and add test for new [gs]et_cgroup_item Signed-off-by: Dwight Engen dwight.en...@oracle.com For the set, Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/lua-lxc/core.c | 35

[lxc-devel] [lxc/lxc] 80ee22: add [gs]et_cgroup_item to lua api

2013-11-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 80ee22284b4172f9ff1d55c62e4a0ef01a4be92e https://github.com/lxc/lxc/commit/80ee22284b4172f9ff1d55c62e4a0ef01a4be92e Author: Dwight Engen dwight.en...@gmail.com Date: 2013-11-04 (Mon, 04 Nov 2013) Changed

Re: [lxc-devel] [PATCH] allow setting/getting lxc.loglevel and lxc.logfile via set_config_item/get_config_item API calls

2013-11-04 Thread S . Çağlar Onur
Hi Serge, On Mon, Nov 4, 2013 at 7:23 AM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): Signed-off-by: S.Çağlar Onur cag...@10ur.org A bit more description would have been appreciated :) But I think I see. Yeah, you are right. I was working on

[lxc-devel] [PATCH RFC] create_run_template: tell the template what caller's uid was mapped to

2013-11-04 Thread Serge Hallyn
This is still RFC at the conceptual level. Problem: when creating containers unprivileged, we run the template in a new user ns. For instance if I have lxc.id_map = u 0 10 1 lxc.id_map = g 0 10 1 in my lxc.conf and do lxc-create -f lxc.conf -P ~/lxcbase -t ubuntu-cloud -n

[lxc-devel] [PATCH] fix leak when a veth.pair name is specified

2013-11-04 Thread Dwight Engen
Signed-off-by: Dwight Engen dwight.en...@oracle.com --- src/lxc/conf.c| 2 ++ src/lxc/confile.c | 14 +- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 2a47e77..0d1eccd 100644 --- a/src/lxc/conf.c +++ b/src/lxc/conf.c @@

[lxc-devel] [PATCH 1/1] resolve lxcpath and rcfile arguments

2013-11-04 Thread Serge Hallyn
So we don't always have to give full paths. realpath(x,NULL) mallocs memory, but these paths shouldn't get called from the API so not freeing should be ok. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com --- src/lxc/arguments.c | 9 - src/lxc/lxc_execute.c | 10 +++---

Re: [lxc-devel] [PATCH] lua: add cmd_get_config_item to API

2013-11-04 Thread Stéphane Graber
On Mon, Nov 04, 2013 at 05:35:07PM -0500, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com I first got pretty confused between get_config_item and cmd_get_config_item but once I got my brain to parse this all properly, it looks fine :) Acked-by: Stéphane Graber

Re: [lxc-devel] [PATCH 2/2] add statistics to lxc-info

2013-11-04 Thread Stéphane Graber
On Mon, Nov 04, 2013 at 05:35:19PM -0500, Dwight Engen wrote: - added list_all_containers() which returns both defined and active containers. - allow lxc-info to show more than one container, using regex for the name Wouldn't it be better to have list_all_containers be similar to

Re: [lxc-devel] [PATCH 1/1] resolve lxcpath and rcfile arguments

2013-11-04 Thread Stéphane Graber
On Mon, Nov 04, 2013 at 02:44:44PM -0600, Serge Hallyn wrote: So we don't always have to give full paths. realpath(x,NULL) mallocs memory, but these paths shouldn't get called from the API so not freeing should be ok. What's the reason behind this change? Am I reading this right that this