Re: [lxc-devel] [PATCH 1/1] api_start: refuse to run undaemonized if multithreaded

2013-11-08 Thread Stéphane Graber
On Thu, Nov 07, 2013 at 10:20:33PM -0600, Serge Hallyn wrote: lxc-start is not safe (and doesn't actually make sense) if the task is nto single-threaded. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxccontainer.c | 37

[lxc-devel] [lxc/lxc] 2d834a: api_start: refuse to run undaemonized if multithre...

2013-11-08 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 2d834aa8074b3e8f7341ad9feff7a7c5b695a3b3 https://github.com/lxc/lxc/commit/2d834aa8074b3e8f7341ad9feff7a7c5b695a3b3 Author: Serge Hallyn serge.hal...@ubuntu.com Date: 2013-11-08 (Fri, 08 Nov 2013) Changed

Re: [lxc-devel] CLONE_PARENT after setns(CLONE_NEWPID)

2013-11-08 Thread Oleg Nesterov
On 11/06, Eric W. Biederman wrote: --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1174,7 +1174,7 @@ static struct task_struct *copy_process(unsigned long clone_flags, * do not allow it to share a thread group or signal handlers or * parent with the forking task. */

[lxc-devel] [PATCH] add modes argument to lxc-test-concurrent

2013-11-08 Thread Dwight Engen
- This allows testing independently the modes with/without threading Signed-off-by: Dwight Engen dwight.en...@oracle.com --- src/tests/concurrent.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/src/tests/concurrent.c

[lxc-devel] [lxc/lxc] 03f064: wait_on_damonized-start: wait only on the pid we w...

2013-11-08 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 03f064ff7447816c89fff24de9b0a5076614dfd3 https://github.com/lxc/lxc/commit/03f064ff7447816c89fff24de9b0a5076614dfd3 Author: Serge Hallyn serge.hal...@ubuntu.com Date: 2013-11-08 (Fri, 08 Nov 2013) Changed

[lxc-devel] [PATCH] replace redundant creat() with open()

2013-11-08 Thread S . Çağlar Onur
creat() is equivalent to open() with flags equal to O_CREAT|O_WRONLY|O_TRUNC Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/bdev.c | 2 +- src/lxc/conf.c | 6 +++--- src/lxc/lxc_start.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lxc/bdev.c

Re: [lxc-devel] [PATCH] add modes argument to lxc-test-concurrent

2013-11-08 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): - This allows testing independently the modes with/without threading Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/tests/concurrent.c | 34 +- 1

Re: [lxc-devel] [PATCH] replace redundant creat() with open()

2013-11-08 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): creat() is equivalent to open() with flags equal to O_CREAT|O_WRONLY|O_TRUNC Hi, I'm confused - what is redundant in the use of creat()? If there is an improvement here then I don't understand what it is. Otherwise I'd argue creat() is more concise and

[lxc-devel] [lxc/lxc] 293ec7: add modes argument to lxc-test-concurrent

2013-11-08 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 293ec758831aa307d834aa6dc1bee36bc604e674 https://github.com/lxc/lxc/commit/293ec758831aa307d834aa6dc1bee36bc604e674 Author: Dwight Engen dwight.en...@oracle.com Date: 2013-11-08 (Fri, 08 Nov 2013) Changed

Re: [lxc-devel] [PATCH] replace redundant creat() with open()

2013-11-08 Thread S . Çağlar Onur
Hey Serge, On Fri, Nov 8, 2013 at 4:06 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): creat() is equivalent to open() with flags equal to O_CREAT|O_WRONLY|O_TRUNC Hi, I'm confused - what is redundant in the use of creat()? If there is an