Re: [lxc-devel] [PATCH] setup_netdev: re-read ifindex in LXC_NET_PHYS case

2013-11-14 Thread Serge Hallyn
Quoting Bogdan Purcareata (bogdan.purcare...@freescale.com): When moving an interface from the host netns to a container's, the ifindex might not remain the same. This happens when the index of the host interface is already assigned to another interface in the new netns. For

[lxc-devel] [lxc/lxc] b466dc: setup_netdev: re-read ifindex in LXC_NET_PHYS case

2013-11-14 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: b466dc337caba11688820e9ef79c5dc20de904cc https://github.com/lxc/lxc/commit/b466dc337caba11688820e9ef79c5dc20de904cc Author: Bogdan Purcareata bogdan.purcare...@freescale.com Date: 2013-11-14 (Thu, 14 Nov 2013)

Re: [lxc-devel] [PATCH] setup_netdev: re-read ifindex in LXC_NET_PHYS case

2013-11-14 Thread Bogdan Purcareata
-Original Message- From: Serge Hallyn [mailto:serge.hal...@ubuntu.com] Sent: Thursday, November 14, 2013 5:24 PM To: Purcareata Bogdan-B43198 Cc: lxc-devel@lists.sourceforge.net Subject: Re: [lxc-devel] [PATCH] setup_netdev: re-read ifindex in LXC_NET_PHYS case Quoting Bogdan

Re: [lxc-devel] [PATCH] gather all locking related code into src/lxc/lxclock.c

2013-11-14 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): Signed-off-by: S.Çağlar Onur cag...@10ur.org Thanks. Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/lxc/lxclock.c | 74 +-- src/lxc/lxclock.h | 3 +++ src/lxc/utils.c | 57

[lxc-devel] [lxc/lxc] 41f683: gather all locking related code into src/lxc/lxclo...

2013-11-14 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 41f683579c0625e22a838ffa6d4297c09b5837e2 https://github.com/lxc/lxc/commit/41f683579c0625e22a838ffa6d4297c09b5837e2 Author: S.Çağlar Onur cag...@10ur.org Date: 2013-11-14 (Thu, 14 Nov 2013) Changed paths:

[lxc-devel] [PATCH 1/1] lxc-start: if we pass in a config file, then don't use any loaded config

2013-11-14 Thread Serge Hallyn
To do this, add a c-clear_config() helper to the api. (this fixes the bug https://bugs.launchpad.net/bugs/1251352) Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com --- src/lxc/lxc_start.c| 1 + src/lxc/lxccontainer.c | 16 +++- src/lxc/lxccontainer.h | 2 ++ 3 files

Re: [lxc-devel] [PATCH 1/1] lxc-start: if we pass in a config file, then don't use any loaded config

2013-11-14 Thread Stéphane Graber
On Thu, Nov 14, 2013 at 12:48:41PM -0600, Serge Hallyn wrote: To do this, add a c-clear_config() helper to the api. (this fixes the bug https://bugs.launchpad.net/bugs/1251352) Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com ---

[lxc-devel] [lxc/lxc] 4df7f0: lxc-start: if we pass in a config file, then don't...

2013-11-14 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 4df7f012b9994ea54b1ad68176d8d45a57fa02f3 https://github.com/lxc/lxc/commit/4df7f012b9994ea54b1ad68176d8d45a57fa02f3 Author: Serge Hallyn serge.hal...@ubuntu.com Date: 2013-11-14 (Thu, 14 Nov 2013) Changed

[lxc-devel] [PATCH] fix memory leaks reported by cppcheck in src/lxc/bdev.c

2013-11-14 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/bdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index c7e5e5e..6acd29a 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -962,8 +962,10 @@ static int lvm_snapshot(const char

[lxc-devel] [PATCH] add missing paranthesis

2013-11-14 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/lsm/apparmor.c | 1 + src/lxc/lxccontainer.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lxc/lsm/apparmor.c b/src/lxc/lsm/apparmor.c index aaf8056..a8d36c1 100644 --- a/src/lxc/lsm/apparmor.c +++

Re: [lxc-devel] [PATCH] add missing paranthesis

2013-11-14 Thread S . Çağlar Onur
Please don't apply this as it contains an unrelated chunk in it. Correct one will hit the list in a minute. On Thu, Nov 14, 2013 at 11:21 PM, S.Çağlar Onur cag...@10ur.org wrote: Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/lsm/apparmor.c | 1 + src/lxc/lxccontainer.c | 4 ++--

[lxc-devel] [PATCH] add missing paranthesis (v2)

2013-11-14 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/lxccontainer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index 3cabf0d..11e70cb 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -2958,9

[lxc-devel] [PATCH] free previously allocated memory if realloc fails in src/lxc/lsm/apparmor.c

2013-11-14 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/lsm/apparmor.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lxc/lsm/apparmor.c b/src/lxc/lsm/apparmor.c index aaf8056..f7f2ff9 100644 --- a/src/lxc/lsm/apparmor.c +++ b/src/lxc/lsm/apparmor.c @@ -68,7