[lxc-devel] [PATCH 02/17] Replace all calls to rindex by strrchr

2013-08-16 Thread Stéphane Graber
The two functions are identical but strrchr also works on Bionic. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/bdev.c | 12 ++-- src/lxc/cgroup.c | 4 ++-- src/lxc/lxccontainer.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git

[lxc-devel] [PATCH 00/17] Android/Bionic compatibility changes

2013-08-16 Thread Stéphane Graber
LXC recently regressed with regard to Android/Bionic buildability, the following commits try to address that. With those changes, LXC now builds with an up to date NDK using android-9. Stéphane Graber (17): Add a local implementation of ifaddrs.h Replace all calls to rindex by strrchr

Re: [lxc-devel] [PATCH 05/17] Android now uses a sane clone() definition

2013-08-16 Thread Stéphane Graber
On Fri, Aug 16, 2013 at 10:26:29AM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): The current Android NDK provides a clone() defintion that's identical to Does this mean this will break older androids? Or is that not how it works? Maybe, I'm not really sure

Re: [lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-16 Thread Stéphane Graber
On Fri, Aug 16, 2013 at 10:36:58AM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): initstate/random doesn't work on bionic, srand/rand works on everything, so let's use that. Is rand_r available on bionic? rand() isn't thread-safe. Unfortunately no, I actually

Re: [lxc-devel] [PATCH] cgroup.c: remove spurious ERROR messages

2013-08-16 Thread Stéphane Graber
On Fri, Aug 16, 2013 at 10:56:58AM -0500, Serge Hallyn wrote: Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/cgroup.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/lxc/cgroup.c b/src/lxc

[lxc-devel] Preparation for LXC 1.0 alpha-1

2013-08-12 Thread Stéphane Graber
on fixing any known bug/regressions and keep their feature changes for after alpha-1. On my side, I noticed that LXC no longer builds on Android/Bionic so I'll try to get that fixed by alpha-1 so LXC can be built with the latest Android NDK. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com

[lxc-devel] [PATCH] Replace mktemp() by a new mkifname()

2013-08-09 Thread Stéphane Graber
for existing network interfaces. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c | 60 +++--- 1 file changed, 57 insertions(+), 3 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 53c05e6..a2f76d3 100644 --- a/src/lxc

Re: [lxc-devel] [PATCH RFC] add lxc-user-nic

2013-08-09 Thread Stéphane Graber
troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer

Re: [lxc-devel] [PATCH] lxclock: use XDG_RUNTIME_DIR for lock if appropriate (v2)

2013-07-23 Thread Stéphane Graber
Graber stephane.gra...@canonical.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxclock.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxclock.c b/src/lxc/lxclock.c index 31bedd8..43e76fa 100644 --- a/src/lxc

Re: [lxc-devel] [PATCH] define lxc-usernsexec

2013-07-23 Thread Stéphane Graber
in a user namespace where 10 on the host is mapped to root in the namespace, and the shell is running as (privileged) root. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com I'm assuming this is a copy of the code you had in the separate package, if so: Acked-by: Stéphane Graber stgra

Re: [lxc-devel] [RFC 0/8] Unprivileged container creation and use

2013-07-23 Thread Stéphane Graber
to ban the lxc.network option allowing you to change the host interface name or use that as a suffix for lxc-uid-whatever the user set in their config. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

Re: [lxc-devel] [PATCH 3/8] container creation: support unpriv container creation in user namespaces

2013-07-23 Thread Stéphane Graber
On Mon, Jul 22, 2013 at 10:02:46AM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Fri, Jul 19, 2013 at 02:26:50PM +, Serge Hallyn wrote: From: Serge Hallyn serge.hal...@ubuntu.com 1. lxcapi_create: don't try to unshare and mount for dir backed

Re: [lxc-devel] [PATCH 3/8] container creation: support unpriv container creation in user namespaces

2013-07-23 Thread Stéphane Graber
attempts at unprivileged container creation if those are not available. (And I'll switch to use XDG_RUNTIME_DIR if geteuid() != 0) thanks, -serge Perfect, thanks! -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

Re: [lxc-devel] [PATCH 1/8] templates: require running as root

2013-07-21 Thread Stéphane Graber
. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-alpine.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/templates/lxc-alpine.in b/templates/lxc-alpine.in index be2a535..ce7226f 100644 --- a/templates/lxc-alpine.in

Re: [lxc-devel] [PATCH 5/8] send current cgroup to lxc_cgroup_create()

2013-07-21 Thread Stéphane Graber
On Fri, Jul 19, 2013 at 02:26:52PM +, Serge Hallyn wrote: From: Serge Hallyn serge.hal...@ubuntu.com This is needed if we're going to have unprivileged users create containers inside cgroups which they own. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber

Re: [lxc-devel] [PATCH 7/8] cgroup: don't set devices cgroup if not in init_user_ns

2013-07-21 Thread Stéphane Graber
___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

Re: [lxc-devel] The containers mini-summit at Linux Plumbers 2013 is now accepting talk proposals

2013-07-21 Thread Stéphane Graber
). -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from

Re: [lxc-devel] [PATCH 2/8] lxc-create: support unpriv users

2013-07-21 Thread Stéphane Graber
will need much more work. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc_create.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/lxc/lxc_create.c b/src/lxc/lxc_create.c index

Re: [lxc-devel] [RFC 0/8] Unprivileged container creation and use

2013-07-21 Thread Stéphane Graber
@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- See everything from the browser

Re: [lxc-devel] [PATCH 4/8] ubuntu-cloud: changes to support unprivileged use

2013-07-21 Thread Stéphane Graber
handed a tarball. fake device creation Unprivileged users can't create devices, so bind mount null, tty, urandom and console from the host. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Looks fine with just one small change needed (see below): Acked-by: Stéphane Graber stgra

Re: [lxc-devel] [PATCH 6/8] A few changes for unprivileged lxc-start

2013-07-21 Thread Stéphane Graber
() function altogether as it is unused now. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Happy to see that code go! Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/caps.c | 38 -- src/lxc/caps.h | 4 src/lxc/lxc_start.c

Re: [lxc-devel] [PATCH 8/8] fix chowning of tty and console uids

2013-07-21 Thread Stéphane Graber
-- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application

Re: [lxc-devel] [PATCH 1/1] ubuntu templates: add some kernel filesystems to container fstab

2013-07-17 Thread Stéphane Graber
to trick mountall (it won't bother mount anything that's already a mountpoint) but that's probably a bad idea at least for fuse which we may actually need, at least on non-userns. Anyway: Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-ubuntu-cloud.in | 3 +++ templates/lxc

[lxc-devel] The containers mini-summit at Linux Plumbers 2013 is now accepting talk proposals

2013-07-15 Thread Stéphane Graber
higher chances of getting scheduled. Long discussion topics may be added to the wiki so we can remember to talk about this outside the mini-conference. Looking forward to seeing you at Plumbers! -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

Re: [lxc-devel] [PATCH 1/1] lxc_create: prepend pretty header to config file

2013-07-12 Thread Stéphane Graber
void* expected_buf); +extern int sha1sum_file(char *fnam, unsigned char *md_value); #endif -- 1.7.9.5 -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

Re: [lxc-devel] [PATCH 1/1] lxc_create: prepend pretty header to config file

2013-07-12 Thread Stéphane Graber
On Fri, Jul 12, 2013 at 04:49:33PM +0100, Daniel P. Berrange wrote: On Fri, Jul 12, 2013 at 10:27:14AM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Thu, Jul 11, 2013 at 11:51:25PM -0500, Serge Hallyn wrote: Define a sha1sum_file() function in utils.c

Re: [lxc-devel] 0.9.x versions before 1.0

2013-07-11 Thread Stéphane Graber
On Thu, Jul 11, 2013 at 09:22:47AM -0500, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): To add to the you broke my lxc-create list, the new version also dropped the fancy header I introduced a while back (showing the template name, the arguments passed

Re: [lxc-devel] 0.9.x versions before 1.0

2013-07-10 Thread Stéphane Graber
to the template: -a amd64 -r precise # Template script checksum (SHA-1): b1f15036868c53cca0698f1efcadd88dfefaee9b -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature -- See

Re: [lxc-devel] [PATCH 2/2] oracle template: use clonehostname hook script

2013-07-09 Thread Stéphane Graber
On Tue, Jul 09, 2013 at 02:44:36PM -0400, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com Please don't push until we push the final version of 1/2. --- templates/lxc-oracle.in | 1 + 1 file changed, 1 insertion

Re: [lxc-devel] 0.9.x versions before 1.0

2013-07-09 Thread Stéphane Graber
-picking work may be quite big. As for 1.0, I've been pretty busy with non-LXC things lately but still hope to get an alpha-1 out by end of July or early August, Ubuntu 13.10 will likely be using that (or alpha-2) as it's release version with 1.0 being aimed at 14.04 LTS next year. -- Stéphane Graber

[lxc-devel] [PATCH] python: Re-introduce timeout in get_ips

2013-07-08 Thread Stéphane Graber
It turns out that most API users want some kind of timeout option for get_ips, so instead of re-implementing it in every single client software, let's just have it as a python overlay upstream. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-start-ephemeral.in | 8

[lxc-devel] [PATCH] lxc-start-ephemeral: Fix console() and add storage option

2013-07-08 Thread Stéphane Graber
for the container (but still have it ephemeral). Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-start-ephemeral.in | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc-start-ephemeral.in b/src/lxc/lxc-start-ephemeral.in index 904f5ac

Re: [lxc-devel] [PATCH] Make get_ips timeout poll configurable

2013-07-08 Thread Stéphane Graber
for this which would be used by get_ips when timeout isn't set and by lxc-start-ephemeral as a way to override the default timeout of 10s. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: Digital signature

Re: [lxc-devel] [PATCH] lxc_stop: return success if api_shutdown succeeded

2013-06-10 Thread Stéphane Graber
On Mon, Jun 10, 2013 at 11:52:44AM -0500, Serge Hallyn wrote: I originally forgot to set ret = 0 if it succeeded, meaning that a simple 'lxc-stop -n container1' returns failure even though the stop succeeded. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber

Re: [lxc-devel] Container autostart proposal V2

2013-05-31 Thread Stéphane Graber
On 05/31/2013 02:08 AM, Harald Dunkel wrote: Hi Stéphane, On 05/30/13 17:39, Stéphane Graber wrote: If we were to use groups for everything, we'd end up having to reserve disabled, autostart, last-state. And then make those 3 conflict so that a container couldn't be in more than one

Re: [lxc-devel] [PATCH] lxccontainer: update locking comment

2013-05-31 Thread Stéphane Graber
disklock, not memlock, since the values are set through the cgroup fs on the running container. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Looks good. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxccontainer.c | 56 +++--- 1

Re: [lxc-devel] [PATCH 1/2] configure/makefile: rename default_conf to distro_conf

2013-05-31 Thread Stéphane Graber
Hopefully that'll make things a bit less confusing :) Acked-by: Stéphane Graber stgra...@ubuntu.com --- config/Makefile.am | 4 ++-- configure.ac | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/config/Makefile.am b/config/Makefile.am index 47f2750..81d7709

Re: [lxc-devel] [PATCH 1/1] api locking: take process lock around open/close

2013-05-31 Thread Stéphane Graber
config); -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Get 100% visibility into Java/.NET code with AppDynamics Lite It's a free troubleshooting tool

Re: [lxc-devel] [PATCH 2/2] Define LXC_DEFAULT_CONFIG

2013-05-31 Thread Stéphane Graber
On 05/31/2013 11:35 AM, Serge Hallyn wrote: And use it in place of the various ways we were deducing /etc/lxc/default.conf. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 1 + src/lxc/Makefile.am

Re: [lxc-devel] Container autostart proposal V2

2013-05-30 Thread Stéphane Graber
wait of lxc.start.delay before starting the next container (parallelizing would make the whole priority/delay idea completely pointless obviously). Many thanx Harri -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] Container autostart proposal V2

2013-05-30 Thread Stéphane Graber
On 05/30/2013 11:28 AM, Harald Dunkel wrote: Hi Stéphane, On 05/30/13 15:33, Stéphane Graber wrote: That's already covered by my proposal and I believe covered in the use cases listed within it. lxc-stop -g any That'll stop all containers that are in the any group. any is documented

Re: [lxc-devel] suggestion for an autostart flag

2013-05-29 Thread Stéphane Graber
and clear, _and_ it is part of the filesystem providing the LXC config file. Just a suggestion, of course. Regards Harri Please look at the discussions we've had over the past couple of days, I believe your problem is already covered by the proposed implementation. -- Stéphane Graber

[lxc-devel] Container autostart proposal V2

2013-05-28 Thread Stéphane Graber
behaves in the exact same way as lxc-start but stopping/shutting down/rebooting the container instead. - lxc-config -n p1 lxc.utsname = returns p1 - lxc.config lxc.autostart.enabled = returns true -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP

Re: [lxc-devel] Container autostart proposal V2

2013-05-28 Thread Stéphane Graber
On 05/28/2013 04:53 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Hey everyone, Thanks for the feedback on my previous autostart proposal. Here's a detailed bullet-point list of what should be done to implement autostarting containers in upstream LXC. Changes

Re: [lxc-devel] Container autostart proposal V2

2013-05-28 Thread Stéphane Graber
On 05/28/2013 04:37 PM, Michael H. Warfield wrote: On Tue, 2013-05-28 at 15:58 -0400, Stéphane Graber wrote: Hey everyone, Thanks for the feedback on my previous autostart proposal. Here's a detailed bullet-point list of what should be done to implement autostarting containers

[lxc-devel] Container autostart proposal

2013-05-27 Thread Stéphane Graber
a lot less pain and much easier for the distros already supporting autostart to migrate to, I think there's a pretty big benefit in getting 2) as it's more flexible, allows for delayed start and supports unprivileged containers. Thoughts? -- Stéphane Graber Ubuntu developer http://www.ubuntu.com

Re: [lxc-devel] Container autostart proposal

2013-05-27 Thread Stéphane Graber
On 05/27/2013 03:07 PM, Stéphane Graber wrote: Hello, One feature that distros have been hacking together on their side for a while is container autostart. For 1.0 I'd like us to agree on an upstream implementation of this so distros no longer need to carry patches in lxc-destroy/lxc-list

Re: [lxc-devel] [PATCH] lxc-create: zfs: consistently use zfsroot, not zfs_root

2013-05-17 Thread Stéphane Graber
On 05/17/2013 12:26 PM, Serge Hallyn wrote: (I've applied this to staging, as without it lxc-create -B zfs failed if using a custom zfsroot) Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Makes sense. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-create.in | 14

Re: [lxc-devel] create api

2013-05-14 Thread Stéphane Graber
? Correct, at least that was my plan. -serge -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- AlienVault Unified Security Management (USM) platform delivers

Re: [lxc-devel] patches to implement -P for the lxc-* scripts

2013-05-03 Thread Stéphane Graber
be great if Daniel could update the website to reflect that as I believe he's the only one who can. The in-tree contribution documentation points to the right place though. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] add zfs support to lxc-create and lxc-destroy

2013-04-26 Thread Stéphane Graber
+elif [ `verify_zfs $rootdev` = zfs ]; then +zfs destroy $(zfs list | grep $rootdev | awk '{ print $1 }') elif [ -h $rootdev -o -d $rootdev ]; then if which btrfs /dev/null 21 btrfs subvolume list $rootdev /dev/null 21; then -- Stéphane Graber Ubuntu

Re: [lxc-devel] lxc_monitord - monitor exiting

2013-04-26 Thread Stéphane Graber
as long as there is a container. Am I wrong? I believe the monitor will get spawned the first time something needs it (lxc-monitor/lxc-wait) and exit 30s after the last client disconnects. It'll then be respawned the next time lxc-monitor or lxc-wait is started again that container. -- Stéphane

[lxc-devel] [PATCH] configure: support for the docbook2man utility to build the documentation

2013-04-25 Thread Stéphane Graber
Simons sim...@cryp.to Reported-by: Christian Bühler christ...@cbuehler.de Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7dc82cf..9b58bab 100644 --- a/configure.ac +++ b

Re: [lxc-devel] [PATCH] python: Fix convert_tuple_to_char_pointer_array

2013-04-24 Thread Stéphane Graber
PM, Stéphane Graber stgra...@ubuntu.com mailto:stgra...@ubuntu.com wrote: This finally fixes a few issues with the magic convert_tuple_to_char_pointer_array function. This now clearly copies the char* from the python object so we don't end up keeping reference to those

[lxc-devel] [PATCH] python: Make the code compatibly with 3.2

2013-04-24 Thread Stéphane Graber
The previous change used some 3.3-specific functions. We still support 3.2 so revert to 3.2-compatible calls. Reported-by: S.Çağlar Onur cag...@10ur.org Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/python-lxc/lxc.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions

Re: [lxc-devel] [PATCH 1/2] Support starting containers concurrently

2013-04-24 Thread Stéphane Graber
On 04/24/2013 10:35 PM, S.Çağlar Onur wrote: Just wanted to remind that we still need this on top of Dwight's awesome work so that start work reliably. Looks good to me. Acked-by: Stéphane Graber stgra...@ubuntu.com On Tue, Apr 23, 2013 at 5:24 PM, S.Çağlar Onur cag...@10ur.org mailto:cag

Re: [lxc-devel] [PATCH 1/1] lxc-create: cleanup whenever exiting with error

2013-04-24 Thread Stéphane Graber
+lvcreate -L $fssize -n $lvname $vgname || cleanup udevadm settle -mkfs -t $fstype $rootdev || exit 1 +mkfs -t $fstype $rootdev || cleanup mount -t $fstype $rootdev $rootfs fi -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP

Re: [lxc-devel] [PATCH 1/1] lxc-create: cleanup whenever exiting with error

2013-04-24 Thread Stéphane Graber
On 04/25/2013 01:46 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On 04/24/2013 10:16 PM, Serge Hallyn wrote: Otherwise we leave bad containers sitting around and further confuse things on retries. Reported-by: Mukanyiligira Didacienne siyana...@gmail.com Signed-off

Re: [lxc-devel] [PATCH 2/2] Support stopping containers concurrently

2013-04-23 Thread Stéphane Graber
this or start to allocate them via calloc? -serge Cheers, -- S.Çağlar Onur cag...@10ur.org mailto:cag...@10ur.org -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

[lxc-devel] [PATCH] python: Fix convert_tuple_to_char_pointer_array

2013-04-23 Thread Stéphane Graber
This finally fixes a few issues with the magic convert_tuple_to_char_pointer_array function. This now clearly copies the char* from the python object so we don't end up keeping reference to those. Also add the few required free calls to free the content of the array. Signed-off-by: Stéphane

Re: [lxc-devel] [PATCH 2/2] Support stopping containers concurrently

2013-04-23 Thread Stéphane Graber
, Serge Hallyn serge.hal...@ubuntu.com mailto:serge.hal...@ubuntu.com wrote: Quoting Stéphane Graber (stgra...@ubuntu.com mailto:stgra...@ubuntu.com): On 04/23/2013 05:29 AM, S.Çağlar Onur wrote: Hey Stéphane, On Wed, Apr 17, 2013 at 6:06 PM, Serge Hallyn

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-21 Thread Stéphane Graber
. -serge I'm not a big user of lxc-clone (yet) but I think as we redesign that part of the code, consistency across backend should be a primary goal even if that causes some slight changes in behaviour from previous implementations. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com

[lxc-devel] [PATCH] ubuntu: Various fixes

2013-04-21 Thread Stéphane Graber
- Drop disabled entries from allowed devices list - Improve generated config layout a bit - Drop redundant uname call - Re-generate the SSH host keys on container creation Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-ubuntu-cloud.in | 14 +- templates/lxc

Re: [lxc-devel] [PATCH 1/2] Revert utils: reimplement/fix mkdir_p()

2013-04-19 Thread Stéphane Graber
On 04/19/2013 12:04 AM, richard -rw- weinberger wrote: On Thu, Apr 18, 2013 at 8:08 PM, Stéphane Graber stgra...@ubuntu.com wrote: He only acked the second patch which made it extremely late to the mailing-list (Serge got it early as he was directly CCed on it). 3. If you encounter problems

[lxc-devel] [PATCH 2/2] Revert start: Detect early failure of the new child

2013-04-18 Thread Stéphane Graber
This reverts commit 5a5c35c3a01afec515e688c8366e6f893985518d. This commit was preventing startup of containers using lxc hooks and shutdown of all other containers, requiring the use of a good old kill -9 to get rid of lxc-start after a container shutdown. Signed-off-by: Stéphane Graber stgra

[lxc-devel] [PATCH 1/2] Revert utils: reimplement/fix mkdir_p()

2013-04-18 Thread Stéphane Graber
This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. This commit was preventing container startup on my machine, making them all fail with various No such file or directory errors. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/utils.c | 48

Re: [lxc-devel] [PATCH 2/2] Revert start: Detect early failure of the new child

2013-04-18 Thread Stéphane Graber
On 04/18/2013 10:32 AM, Stéphane Graber wrote: This reverts commit 5a5c35c3a01afec515e688c8366e6f893985518d. This commit was preventing startup of containers using lxc hooks and shutdown of all other containers, requiring the use of a good old kill -9 to get rid of lxc-start after

Re: [lxc-devel] [PATCH 1/2] Revert utils: reimplement/fix mkdir_p()

2013-04-18 Thread Stéphane Graber
On 04/18/2013 10:32 AM, Stéphane Graber wrote: This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. This commit was preventing container startup on my machine, making them all fail with various No such file or directory errors. Signed-off-by: Stéphane Graber stgra...@ubuntu.com

[lxc-devel] [PATCH] python: Lots of fixes in C extension

2013-04-18 Thread Stéphane Graber
Fixes a lot of issues found by a code review done by Barry Warsaw. Those include: - Wrong signature for getters - Various memory leaks - Various optimizations - More consistent return values - Proper exception handling Reported-by: Barry Warsaw ba...@ubuntu.com Signed-off-by: Stéphane

Re: [lxc-devel] [PATCH 1/2] Revert utils: reimplement/fix mkdir_p()

2013-04-18 Thread Stéphane Graber
On 04/18/2013 10:34 AM, Stéphane Graber wrote: On 04/18/2013 10:32 AM, Stéphane Graber wrote: This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. This commit was preventing container startup on my machine, making them all fail with various No such file or directory errors. Signed

Re: [lxc-devel] git tree and man pages

2013-04-18 Thread Stéphane Graber
files, anything else is a compiled file which gets discarded at build time. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Precog is a next-generation

Re: [lxc-devel] git tree and man pages

2013-04-18 Thread Stéphane Graber
, 2013 at 2:45 PM, Stéphane Graber stgra...@ubuntu.com wrote: On 04/18/2013 01:34 PM, David Shwatrz wrote: Hi, lxc-developers, I had performed git clone git://lxc.git.sourceforge.net/gitroot/lxc/lxc and under doc I don't see any man pages. for a lxc tar gz I downloaded, they are under doc

Re: [lxc-devel] [PATCH 1/2] Revert utils: reimplement/fix mkdir_p()

2013-04-18 Thread Stéphane Graber
On 04/18/2013 07:14 PM, richard -rw- weinberger wrote: On Thu, Apr 18, 2013 at 10:48 AM, Stéphane Graber stgra...@ubuntu.com wrote: On 04/18/2013 10:34 AM, Stéphane Graber wrote: On 04/18/2013 10:32 AM, Stéphane Graber wrote: This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6

Re: [lxc-devel] [PATCH 2/2] Revert start: Detect early failure of the new child

2013-04-18 Thread Stéphane Graber
-rw- weinberger richard.weinber...@gmail.com mailto:richard.weinber...@gmail.com wrote: On Thu, Apr 18, 2013 at 10:32 AM, Stéphane Graber stgra...@ubuntu.com mailto:stgra...@ubuntu.com wrote: This reverts commit 5a5c35c3a01afec515e688c8366e6f893985518d. This commit

[lxc-devel] [PATCH] python: Various fixes to the python scripts

2013-04-18 Thread Stéphane Graber
when in set_config_item (or setting any previously unset variable would fail). Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-start-ephemeral.in | 4 +++- src/python-lxc/lxc/__init__.py | 5 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc-start

Re: [lxc-devel] [PATCH] quiet gcc 4.4.7 warning about saveptr use before initialization

2013-04-16 Thread Stéphane Graber
-by: Dwight Engen dwight.en...@oracle.com Ah good, I was actually about to propose the same fix as coverity detected it as an error. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc

Re: [lxc-devel] [PATCH RFC] Fix up struct lxc_container locking

2013-04-11 Thread Stéphane Graber
-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com Pushing to staging. --- src/lxc/lxccontainer.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index

Re: [lxc-devel] [PATCH] Use container specific domain socket name

2013-04-10 Thread Stéphane Graber
to DBus. The current obvious multi-casty thing on the Linux desktop is DBus and while we could theoretically use it as a replacement for our current unix socket, I don't really think we want to bring it as a dependency for LXC. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com

[lxc-devel] LXC 0.9 release, staging branch re-opened for 1.0

2013-04-08 Thread Stéphane Graber
exciting 1.0. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Minimize network downtime and maximize team effectiveness. Reduce network management

Re: [lxc-devel] [PATCH] templates: abort if name is not specified

2013-04-01 Thread Stéphane Graber
as hooks for lxc-create or the create() API function, not to be called directly by the user. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Own the Future

Re: [lxc-devel] [PATCH 1/1] lxc-create: require absolute path for non-standard templates

2013-04-01 Thread Stéphane Graber
On 03/31/2013 06:00 PM, Serge Hallyn wrote: Otherwise, as an example, if doing 'lxc-create -t debian' while there is a 'debian' directory, lxc-create will fail to do the right thing. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com

[lxc-devel] Staging branch now frozen for release

2013-04-01 Thread Stéphane Graber
). Very rough draft of the 1.0 roadmap is at: https://wiki.ubuntu.com/LXC/1.0-roadmap Plan for Plumbers is at: http://wiki.linuxplumbersconf.org/2013:containers -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] API shouldn't be calling create for already defined containers or destroy for non defined ones.

2013-03-31 Thread Stéphane Graber
false; pid = fork(); -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Own the Future-Intel(R) Level Up Game Demo Contest 2013 Rise

[lxc-devel] [PATCH] lxc-start-ephemeral: Implement -n to match manpage

2013-03-27 Thread Stéphane Graber
The -n/--name option of lxc-start-ephemeral was never implemented even though it was documented in the manpage. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-start-ephemeral.in | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc-start

Re: [lxc-devel] [PATCH] EXTRA_DIST: Fix missing files with make dist

2013-03-27 Thread Stéphane Graber
On 03/27/2013 11:28 AM, Dwight Engen wrote: On Tue, 26 Mar 2013 13:09:20 -0400 Stéphane Graber stgra...@ubuntu.com wrote: On 03/26/2013 01:03 PM, Stéphane Graber wrote: I recently noticed that the generated tarballs with make dist were incomplete unless the configure script was run

Re: [lxc-devel] [PATCH] lxc-clone: support 'permanent ephemeral' containers

2013-03-27 Thread Stéphane Graber
serge.hal...@ubuntu.com Looks good. Acked-by: Stéphane Graber stgra...@ubuntu.com And pushed to staging. --- src/lxc/lxc-clone.in | 17 + 1 file changed, 17 insertions(+) diff --git a/src/lxc/lxc-clone.in b/src/lxc/lxc-clone.in index 291db30..4c8acb4 100755 --- a/src

[lxc-devel] Reminder, LXC 0.9 to be released next week

2013-03-27 Thread Stéphane Graber
on Monday 1st of April (not a joke!). I'll accept bugfixes as late as Sunday (US eastern), after that, it'll have to wait for 1.0 to open and then be backported for 0.9.1. Thanks -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

[lxc-devel] [PATCH] EXTRA_DIST: Fix missing files with make dist

2013-03-26 Thread Stéphane Graber
I recently noticed that the generated tarballs with make dist were incomplete unless the configure script was run on a machine with all possible build dependencies. That's wrong as you clearly don't need those dependencies to generate the tarball. This change fixes that. Signed-off-by: Stéphane

Re: [lxc-devel] [PATCH] EXTRA_DIST: Fix missing files with make dist

2013-03-26 Thread Stéphane Graber
On 03/26/2013 01:03 PM, Stéphane Graber wrote: I recently noticed that the generated tarballs with make dist were incomplete unless the configure script was run on a machine with all possible build dependencies. That's wrong as you clearly don't need those dependencies to generate

[lxc-devel] [PATCH] Fix 'make clean'

2013-03-26 Thread Stéphane Graber
This is mostly to make debuild happy as it doesn't tolerate any leftover file when building twice in a row. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- doc/Makefile.am| 2 +- src/python-lxc/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-21 Thread Stéphane Graber
@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Everyone hates slow websites. So

[lxc-devel] 0.9 final release, plans for 1.0 and Linux Plumbers 2013

2013-03-19 Thread Stéphane Graber
there for some face to face discussions. Thanks! -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Everyone hates slow websites. So do we. Make your web apps

Re: [lxc-devel] [PATCH 2/2] Properly handle timeout case in lxc-shutdown

2013-03-19 Thread Stéphane Graber
@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Everyone hates slow

Re: [lxc-devel] [PATCH 1/2] Properly cleanup network devices if pinning root filesystem didn't work

2013-03-19 Thread Stéphane Graber
___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH 2/2] Fix for ia64: Use __clone2 for ia64 in lxc/start.c

2013-03-19 Thread Stéphane Graber
-- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite

Re: [lxc-devel] [PATCH 1/1] lxc_id_mapping: don't try to write mappings if there are none

2013-03-13 Thread Stéphane Graber
Looks good to me. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 85e1c61..af75690 100644 --- a/src/lxc/conf.c +++ b/src/lxc/conf.c @@ -2479,17

[lxc-devel] Last call for rc1

2013-03-13 Thread Stéphane Graber
know ASAP and I'll try to get that included. Thanks -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Everyone hates slow websites. So do we. Make your

[lxc-devel] 0.9~rc1 pull request to be sent out on Wednesday

2013-03-11 Thread Stéphane Graber
be a very good time to send them :) -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester

[lxc-devel] [PATCH 2/3] API: export lxc_get_version()

2013-03-11 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/Makefile.am| 6 -- src/lxc/lxc.h | 5 - src/lxc/lxccontainer.c | 6 ++ src/lxc/lxccontainer.h | 1 + src/lxc/version.h | 31 +++ 5 files changed, 42 insertions(+), 7

[lxc-devel] [PATCH 1/3] python: Don't hardcode LXCPATH in python module

2013-03-11 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- .gitignore| 1 - configure.ac | 1 - src/python-lxc/lxc.c | 14 +- src/python-lxc/lxc/__init__.py| 470 + src/python-lxc/lxc/__init__.py.in

<    1   2   3   4   5   6   >