Re: [lxc-devel] [PATCH] fix console deadlocks

2013-09-20 Thread Dwight Engen
On Fri, 20 Sep 2013 14:48:40 -0500 Serge Hallyn wrote: > These might be a bit controversial. The process lock was held > for some long periods of time for tweaking consoles. These > can deadlock with some of lock holds I introduced recently. I > would argue that if two threads are fighting ov

Re: [lxc-devel] [PATCH] fix console deadlocks

2013-09-20 Thread Stéphane Graber
On Fri, Sep 20, 2013 at 02:48:40PM -0500, Serge Hallyn wrote: > These might be a bit controversial. The process lock was held > for some long periods of time for tweaking consoles. These > can deadlock with some of lock holds I introduced recently. I > would argue that if two threads are fighti

Re: [lxc-devel] [PATCH] fix console deadlocks

2013-09-20 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Fri, 20 Sep 2013 15:26:47 -0500 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > On Fri, 20 Sep 2013 14:48:40 -0500 > > > Serge Hallyn wrote: > > > > > > > These might be a bit controversial. The process lock

Re: [lxc-devel] [PATCH] fix console deadlocks

2013-09-20 Thread Dwight Engen
On Fri, 20 Sep 2013 15:26:47 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > On Fri, 20 Sep 2013 14:48:40 -0500 > > Serge Hallyn wrote: > > > > > These might be a bit controversial. The process lock was held > > > for some long periods of time for tweaking conso

Re: [lxc-devel] [PATCH] fix console deadlocks

2013-09-20 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Fri, 20 Sep 2013 14:48:40 -0500 > Serge Hallyn wrote: > > > These might be a bit controversial. The process lock was held > > for some long periods of time for tweaking consoles. These > > can deadlock with some of lock holds I introduced re

[lxc-devel] [PATCH] fix console deadlocks

2013-09-20 Thread Serge Hallyn
These might be a bit controversial. The process lock was held for some long periods of time for tweaking consoles. These can deadlock with some of lock holds I introduced recently. I would argue that if two threads are fighting over the console, you're gonna have trouble anyway, and the process