Re: [lxc-devel] [PATCH] utils: reimplement/fix mkdir_p()

2013-04-18 Thread Richard Weinberger
Am 17.04.2013 22:49, schrieb Serge Hallyn: > Quoting Richard Weinberger (rich...@nod.at): >> Am 17.04.2013 18:00, schrieb Serge Hallyn: >>> Quoting Richard Weinberger (rich...@nod.at): Reimplement mkdir_p() such that it: ...handles relativ paths correctly. (currently it crashes)

Re: [lxc-devel] [PATCH] utils: reimplement/fix mkdir_p()

2013-04-17 Thread Serge Hallyn
Quoting Richard Weinberger (rich...@nod.at): > Reimplement mkdir_p() such that it: > ...handles relativ paths correctly. (currently it crashes) > ...does not rely on dirname(). > ...is not recursive. > ...is shorter. ;-) > > Signed-off-by: Richard Weinberger Thanks, this looks great. Acked-

Re: [lxc-devel] [PATCH] utils: reimplement/fix mkdir_p()

2013-04-17 Thread Richard Weinberger
Am 17.04.2013 18:00, schrieb Serge Hallyn: > Quoting Richard Weinberger (rich...@nod.at): >> Reimplement mkdir_p() such that it: >> ...handles relativ paths correctly. (currently it crashes) >> ...does not rely on dirname(). >> ...is not recursive. >> ...is shorter. ;-) > > Looks good, than

Re: [lxc-devel] [PATCH] utils: reimplement/fix mkdir_p()

2013-04-17 Thread Serge Hallyn
Quoting Richard Weinberger (rich...@nod.at): > Am 17.04.2013 18:00, schrieb Serge Hallyn: > >Quoting Richard Weinberger (rich...@nod.at): > >>Reimplement mkdir_p() such that it: > >> ...handles relativ paths correctly. (currently it crashes) > >> ...does not rely on dirname(). > >> ...is not rec

Re: [lxc-devel] [PATCH] utils: reimplement/fix mkdir_p()

2013-04-17 Thread Serge Hallyn
Quoting Richard Weinberger (rich...@nod.at): > Reimplement mkdir_p() such that it: > ...handles relativ paths correctly. (currently it crashes) > ...does not rely on dirname(). > ...is not recursive. > ...is shorter. ;-) Looks good, thanks. Yeah I prefer non-recursive. Three comments though,