[lxc-devel] [PATCH] add lxc.network.veth.script configuration hook

2010-10-07 Thread Stefan Tomanek
This commit adds an lxc.network.veth.script configuration option to specify a script to be executed after creating or configuring the pair of veth devices. The name of the host sided device is passed as first argument, so the script can be used to configures routes or firewall rules related to the

Re: [lxc-devel] [PATCH] add lxc.network.veth.script configuration hook

2010-10-07 Thread Daniel Lezcano
On 10/07/2010 09:30 AM, Stefan Tomanek wrote: > This commit adds an lxc.network.veth.script configuration option to > specify a script to be executed after creating or configuring the pair > of veth devices. The name of the host sided device is passed as first > argument, so the script can be used

Re: [lxc-devel] [PATCH] add lxc.network.veth.script configuration hook

2010-10-07 Thread Stefan Tomanek
Dies schrieb Daniel Lezcano (daniel.lezc...@free.fr): > I suggest you add a lxc.network.script section where it will be > called from each instanciate_* OK, that's what an earlier version of the patch did, so I partially reverted :-) > The script should receive always the two parameters: > >

Re: [lxc-devel] [PATCH] add lxc.network.veth.script configuration hook

2010-10-07 Thread Stefan Tomanek
> I suggest you add a lxc.network.script section where it will be > called from each instanciate_* I thought about that, but I think that name is to generic - it might be useful to provide several different locations to call a script. In my case, the obvious location is the instanciation function,

Re: [lxc-devel] [PATCH] add lxc.network.veth.script configuration hook

2010-10-07 Thread Daniel Lezcano
On 10/07/2010 12:32 PM, Stefan Tomanek wrote: > Dies schrieb Daniel Lezcano (daniel.lezc...@free.fr): > >> I suggest you add a lxc.network.script section where it will be >> called from each instanciate_* > > OK, that's what an earlier version of the patch did, so I partially > reverted :-) > >> Th

Re: [lxc-devel] [PATCH] add lxc.network.veth.script configuration hook

2010-10-07 Thread Daniel Lezcano
On 10/07/2010 01:19 PM, Stefan Tomanek wrote: >> I suggest you add a lxc.network.script section where it will be >> called from each instanciate_* >> > I thought about that, but I think that name is to generic - it might be > useful to provide several different locations to call a script. In

Re: [lxc-devel] [PATCH] add lxc.network.veth.script configuration hook

2010-10-07 Thread Stefan Tomanek
Dies schrieb Daniel Lezcano (daniel.lezc...@free.fr): > * lxc.network.script.pre: > > IMO, it does not make sense because that means it is the host itself > which should be modified, so that fall under the host network > configuration umbrella => administrator job :P I cannot think of a fit

Re: [lxc-devel] [PATCH] add lxc.network.veth.script configuration hook

2010-10-07 Thread Daniel Lezcano
On 10/07/2010 03:06 PM, Stefan Tomanek wrote: > Dies schrieb Daniel Lezcano (daniel.lezc...@free.fr): > > >>* lxc.network.script.pre: >> >> IMO, it does not make sense because that means it is the host itself >> which should be modified, so that fall under the host network >> configuration