[lxc-devel] [PATCH] define MS_SHARED if needed

2012-12-25 Thread Natanael Copa
Fixes build on uClibc. Signed-off-by: Natanael Copa --- src/lxc/conf.c | 4 1 file changed, 4 insertions(+) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 96940b3..c82e759 100644 --- a/src/lxc/conf.c +++ b/src/lxc/conf.c @@ -87,6 +87,10 @@ lxc_log_define(lxc_conf, lxc); #define MNT_DE

Re: [lxc-devel] [PATCH] Fix compile warning on uninitialized return value

2012-12-25 Thread Stéphane Graber
On 12/21/2012 04:34 PM, Kyle Russell wrote: > Hi, > > Please consider the following patch for your next release. > > cgroup's mount_has_subsystem returns the first subsystem > found or NULL if no subsystem was found; however, the return > value is never initialized, so it's not guaranteed to retu

Re: [lxc-devel] [PATCH] templates: initial support for Alpine Linux

2012-12-25 Thread Stéphane Graber
On 12/24/2012 05:18 PM, Natanael Copa wrote: > Requires apk-tools (http://git.alpinelinux.org/cgit/apk-tools) > > Signed-off-by: Natanael Copa I didn't look at it too closely but the usual files have been updated and I assume the template has been properly tested. Acked and applied. > --- > .

Re: [lxc-devel] [PATCH] define MS_SHARED if needed

2012-12-25 Thread Stéphane Graber
On 12/25/2012 10:53 AM, Natanael Copa wrote: > Fixes build on uClibc. > > Signed-off-by: Natanael Copa Looks good, Acked and applied. > --- > src/lxc/conf.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/lxc/conf.c b/src/lxc/conf.c > index 96940b3..c82e759 100644 > --- a/src

[lxc-devel] [PATCH] lxc-checkconfig: fix colors when using dash

2012-12-25 Thread Natanael Copa
The \e did not work as expected on dash. Replace with proper posix \033 Signed-off-by: Natanael Copa --- src/lxc/lxc-checkconfig.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lxc/lxc-checkconfig.in b/src/lxc/lxc-checkconfig.in index 13dbf3b..472755f 100644 --

[lxc-devel] [PATCH 3/4] lxc-clone: use posix shell instead of bash

2012-12-25 Thread Natanael Copa
- avoid getopt --longoptions - use 'which' instead of 'type' to detect existance of tools - use 'grep -q -w' instead of bash substring variable expansion ${line:0:18} Signed-off-by: Natanael Copa --- src/lxc/lxc-clone.in | 56 +--- 1 file changed

[lxc-devel] [PATCH 1/4] lxc-destroy: use posix shell instead of bash

2012-12-25 Thread Natanael Copa
- avoid use getopt --longoptions Signed-off-by: Natanael Copa --- src/lxc/lxc-destroy.in | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/src/lxc/lxc-destroy.in b/src/lxc/lxc-destroy.in index 1527495..0c27e4a 100644 --- a/src/lxc/lxc

[lxc-devel] [PATCH 4/4] lxc-netstat: use posix shell instead of bash

2012-12-25 Thread Natanael Copa
- use case .. in instead of comparison with globs - avoid 'local' Signed-off-by: Natanael Copa --- src/lxc/lxc-netstat.in | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/lxc/lxc-netstat.in b/src/lxc/lxc-netstat.in index df18620..87bd3eb 100644 --- a/src/lxc/

[lxc-devel] [PATCH 2/4] legacy/lxc-ls: use posix shell instead of bash

2012-12-25 Thread Natanael Copa
- use case .. in instead of comparison with globs - avoid 'local' While here, also avoid 'find ... -printf' which is not supported on busybox Signed-off-by: Natanael Copa --- src/lxc/legacy/lxc-ls.in | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/lxc/leg

Re: [lxc-devel] [PATCH] lxc-checkconfig: fix colors when using dash

2012-12-25 Thread Stéphane Graber
On 12/25/2012 04:50 PM, Natanael Copa wrote: > The \e did not work as expected on dash. Replace with proper posix \033 > > Signed-off-by: Natanael Copa Acked-by: Stéphane Graber Pushed to staging. Thanks. > --- > src/lxc/lxc-checkconfig.in | 8 > 1 file changed, 4 insertions(+), 4

Re: [lxc-devel] [PATCH 1/4] lxc-destroy: use posix shell instead of bash

2012-12-25 Thread Stéphane Graber
On 12/25/2012 05:08 PM, Natanael Copa wrote: > - avoid use getopt --longoptions > > Signed-off-by: Natanael Copa Acked-by: Stéphane Graber Pushed to staging. Thanks. > --- > src/lxc/lxc-destroy.in | 41 + > 1 file changed, 25 insertions(+), 16 deletion

Re: [lxc-devel] [PATCH 2/4] legacy/lxc-ls: use posix shell instead of bash

2012-12-25 Thread Stéphane Graber
On 12/25/2012 05:08 PM, Natanael Copa wrote: > - use case .. in instead of comparison with globs > - avoid 'local' > > While here, also avoid 'find ... -printf' which is not supported on busybox > > Signed-off-by: Natanael Copa Acked-by: Stéphane Graber Pushed to staging. Thanks. I also fixe

Re: [lxc-devel] [PATCH 3/4] lxc-clone: use posix shell instead of bash

2012-12-25 Thread Stéphane Graber
On 12/25/2012 05:08 PM, Natanael Copa wrote: > - avoid getopt --longoptions > - use 'which' instead of 'type' to detect existance of tools > - use 'grep -q -w' instead of bash substring variable expansion > ${line:0:18} > > Signed-off-by: Natanael Copa Acked-by: Stéphane Graber Pushed to sta

Re: [lxc-devel] [PATCH 4/4] lxc-netstat: use posix shell instead of bash

2012-12-25 Thread Stéphane Graber
On 12/25/2012 05:08 PM, Natanael Copa wrote: > - use case .. in instead of comparison with globs > - avoid 'local' > > Signed-off-by: Natanael Copa Acked-by: Stéphane Graber Pushed to staging. Thanks. > --- > src/lxc/lxc-netstat.in | 13 + > 1 file changed, 5 insertions(+), 8 del

Re: [lxc-devel] [PATCH 2/4] legacy/lxc-ls: use posix shell instead of bash

2012-12-25 Thread Natanael Copa
On Tue, 25 Dec 2012 17:36:12 +0100 Stéphane Graber wrote: > On 12/25/2012 05:08 PM, Natanael Copa wrote: > > Signed-off-by: Natanael Copa ... > Pushed to staging. Thanks. > > I also fixed a minor indent problem in that commit (the last esac was > space indented instead of tab indented). Sorry