Re: [lxc-devel] [PATCH] lxc-create: Store template information in config

2012-11-30 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Change lxc-create to add the name of the template and any parameters to the container's configuration. This makes it easier to debug and figure out exactly how a container was built. Signed-off-by: Stéphane Graber stgra...@ubuntu.com ---

[lxc-devel] [PATCH] Fix compile error when building with -Wp, -D_FORTIFY_SOURCE=2

2012-11-30 Thread Dwight Engen
Fedora by default builds with this flag, and complains about not checking the return from fchdir. There isn't much we can do if we can't change back to the original directory, so just log an error message. Signed-off-by: Dwight Engen dwight.en...@oracle.com --- src/lxc/conf.c | 3 ++- 1 file

[lxc-devel] [PATCH v2] make install should create $LXCPATH, cache directories

2012-11-30 Thread Dwight Engen
The $LXCPATH (default /var/lib/lxc) directory was not being created by make install, so unless it gets created by some other means (packaging tools), commands such as lxc-create will fail. Also ensure the cache directory (default /var/cache/lxc, used by some templates) gets created. ---

[lxc-devel] [PATCH] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-11-30 Thread Dwight Engen
Signed-off-by: Dwight Engen dwight.en...@oracle.com --- src/lxc/Makefile.am | 3 ++- src/lxc/conf.c| 2 +- src/lxc/lxccontainer.c| 2 +- src/tests/Makefile.am | 3 ++- src/tests/containertests.c| 2 +- src/tests/saveconfig.c| 2 +-

Re: [lxc-devel] [PATCH] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-11-30 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/lxc/Makefile.am | 3 ++- src/lxc/conf.c| 2 +- src/lxc/lxccontainer.c| 2 +-

Re: [lxc-devel] [PATCH] Fix compile error when building with -Wp, -D_FORTIFY_SOURCE=2

2012-11-30 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): Fedora by default builds with this flag, and complains about not checking the return from fchdir. There isn't much we can do if we can't change back to the original directory, so just log an error message. Signed-off-by: Dwight Engen

Re: [lxc-devel] [PATCH] Fix compile error when building with -Wp, -D_FORTIFY_SOURCE=2

2012-11-30 Thread Dwight Engen
On Fri, 30 Nov 2012 09:29:56 -0600 Serge Hallyn serge.hal...@canonical.com wrote: Quoting Dwight Engen (dwight.en...@oracle.com): Fedora by default builds with this flag, and complains about not checking the return from fchdir. There isn't much we can do if we can't change back to the

[lxc-devel] [PATCH] Create busybox commands as symlinks instead of hardlinks

2012-11-30 Thread Dwight Engen
I was getting a Too many links error when creating a busybox container on a btrfs file system. This change has the template create the links as symlinks instead. It also generates the list of commands to be symlinked from busybox itself instead of a hardcoded list in the template. Also set the

Re: [lxc-devel] [PATCH] lxc-create: Store template information in config

2012-11-30 Thread Stéphane Graber
On 11/30/2012 08:56 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Change lxc-create to add the name of the template and any parameters to the container's configuration. This makes it easier to debug and figure out exactly how a container was built. Signed-off-by:

Re: [lxc-devel] [PATCH] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-11-30 Thread Stéphane Graber
On 11/30/2012 09:50 AM, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com It looks like you're mixing LOCALSTATEDIR /lib/lxc and LXCPATH quite a bit. Shouldn't we use LXCPATH whenever possible? --- src/lxc/Makefile.am | 3 ++- src/lxc/conf.c|

Re: [lxc-devel] [PATCH] Create busybox commands as symlinks instead of hardlinks

2012-11-30 Thread Stéphane Graber
On 11/30/2012 11:49 AM, Dwight Engen wrote: I was getting a Too many links error when creating a busybox container on a btrfs file system. This change has the template create the links as symlinks instead. It also generates the list of commands to be symlinked from busybox itself instead of a

Re: [lxc-devel] [PATCH] Create busybox commands as symlinks instead of hardlinks

2012-11-30 Thread Natanael Copa
On Fri, 30 Nov 2012 11:49:25 -0500 Dwight Engen dwight.en...@oracle.com wrote: +# it would be nice to just use chroot $rootfs busybox --install -s /bin +# but that only works right in a chroot with busybox = 1.19.0 I think it should work with busybox before 1.19 if you make sure

Re: [lxc-devel] [PATCHv2] lxc-create: Store template information in config

2012-11-30 Thread Natanael Copa
On Fri, 30 Nov 2012 17:01:59 -0500 Stéphane Graber stgra...@ubuntu.com wrote: Change lxc-create to add the name of the template, checksum and any parameters to the container's configuration. This makes it easier to debug and figure out exactly how a container was built. Signed-off-by:

Re: [lxc-devel] [PATCHv2] lxc-create: Store template information in config

2012-11-30 Thread Stéphane Graber
On 11/30/2012 05:23 PM, Natanael Copa wrote: On Fri, 30 Nov 2012 17:01:59 -0500 Stéphane Graber stgra...@ubuntu.com wrote: Change lxc-create to add the name of the template, checksum and any parameters to the container's configuration. This makes it easier to debug and figure out exactly