Re: [lxc-devel] [PATCH 0/7] Last minute signal stuff (now in separate mails)
On 06/06/2010 11:07 PM, Ferenc Wagner wrote: Hi, The first part is some tinkering to make lxc compile under Debian Lenny. The dangerous part is the signal forwarding and the process group business I was playing with recently. It contains Greg's idea about setting the foreground process group and also inverts the signal selection logic. Which means it's only slightly tested in its present form, but I wanted to get this out of the door ASAP, so you can get an idea what I'm up to. I'll continue testing it tomorrow and will followup with the results. Regards, Feri. Ferenc Wagner (7): conditional use of new capabilities uint32_t is defined in stdint.h .gitignore new components start child in its own process group, and put it into the foreground lxc-start isn't in the foreground anymore, so TTY signals don't reach it forward signals to the container init generalize the name of the signal handler .gitignore |3 ++ src/lxc/conf.c |4 +++ src/lxc/start.c | 59 ++ src/lxc/utils.h | 27 - 4 files changed, 44 insertions(+), 49 deletions(-) Hi Ferenc, I will takes the fixes not related to the signal forwarding: - [PATCH 1/7] conditional use of new capabilities - [PATCH 2/7] uint32_t is defined in stdint.h - [PATCH 3/7] .gitignore new components Thanks a lot. -- Daniel -- ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
Re: [lxc-devel] [PATCH 0/7] Last minute signal stuff (now in separate mails)
Daniel Lezcano daniel.lezc...@free.fr writes: On 06/06/2010 11:07 PM, Ferenc Wagner wrote: The first part is some tinkering to make lxc compile under Debian Lenny. The dangerous part is the signal forwarding and the process group business I was playing with recently. It contains Greg's idea about setting the foreground process group and also inverts the signal selection logic. Which means it's only slightly tested in its present form, but I wanted to get this out of the door ASAP, so you can get an idea what I'm up to. I'll continue testing it tomorrow and will followup with the results. Ferenc Wagner (7): conditional use of new capabilities uint32_t is defined in stdint.h .gitignore new components start child in its own process group, and put it into the foreground lxc-start isn't in the foreground anymore, so TTY signals don't reach it forward signals to the container init generalize the name of the signal handler I will take the fixes not related to the signal forwarding: - [PATCH 1/7] conditional use of new capabilities - [PATCH 2/7] uint32_t is defined in stdint.h - [PATCH 3/7] .gitignore new components Ok, that's the uncontroversial part. Patch 4 has a whitespace error, and patch 5 lost an #endif, so I'll resend them anyway. I wonder how the latter didn't surface on my home machine... But there's another failure I get on my work machine (with my original patchset with the above errors corrected): gcc -I../../src -g -O2 -g -Wall -O2 -Wall -Wl,-E -Wl,-rpath -Wl,/usr/lib/lxc -o lxc-attach lxc_attach.o liblxc.so liblxc.so: undefined reference to `lxc_sync_init' liblxc.so: undefined reference to `lxc_sync_fini_parent' liblxc.so: undefined reference to `lxc_sync_barrier_parent' liblxc.so: undefined reference to `lxc_sync_fini_child' liblxc.so: undefined reference to `lxc_sync_wake_parent' liblxc.so: undefined reference to `lxc_sync_wait_child' liblxc.so: undefined reference to `lxc_sync_fini' liblxc.so: undefined reference to `lxc_sync_barrier_child' collect2: ld returned 1 exit status Have you got an idea what may be wrong here? I'll continue investigation after lunch. -- Thanks, Feri. -- ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
Re: [lxc-devel] [PATCH 0/7] Last minute signal stuff (now in separate mails)
On 06/07/2010 12:37 PM, Ferenc Wagner wrote: Daniel Lezcanodaniel.lezc...@free.fr writes: On 06/06/2010 11:07 PM, Ferenc Wagner wrote: The first part is some tinkering to make lxc compile under Debian Lenny. The dangerous part is the signal forwarding and the process group business I was playing with recently. It contains Greg's idea about setting the foreground process group and also inverts the signal selection logic. Which means it's only slightly tested in its present form, but I wanted to get this out of the door ASAP, so you can get an idea what I'm up to. I'll continue testing it tomorrow and will followup with the results. Ferenc Wagner (7): conditional use of new capabilities uint32_t is defined in stdint.h .gitignore new components start child in its own process group, and put it into the foreground lxc-start isn't in the foreground anymore, so TTY signals don't reach it forward signals to the container init generalize the name of the signal handler I will take the fixes not related to the signal forwarding: - [PATCH 1/7] conditional use of new capabilities - [PATCH 2/7] uint32_t is defined in stdint.h - [PATCH 3/7] .gitignore new components Ok, that's the uncontroversial part. Patch 4 has a whitespace error, and patch 5 lost an #endif, so I'll resend them anyway. I wonder how the latter didn't surface on my home machine... But there's another failure I get on my work machine (with my original patchset with the above errors corrected): gcc -I../../src -g -O2 -g -Wall -O2 -Wall -Wl,-E -Wl,-rpath -Wl,/usr/lib/lxc -o lxc-attach lxc_attach.o liblxc.so liblxc.so: undefined reference to `lxc_sync_init' liblxc.so: undefined reference to `lxc_sync_fini_parent' liblxc.so: undefined reference to `lxc_sync_barrier_parent' liblxc.so: undefined reference to `lxc_sync_fini_child' liblxc.so: undefined reference to `lxc_sync_wake_parent' liblxc.so: undefined reference to `lxc_sync_wait_child' liblxc.so: undefined reference to `lxc_sync_fini' liblxc.so: undefined reference to `lxc_sync_barrier_child' collect2: ld returned 1 exit status Have you got an idea what may be wrong here? I'll continue investigation after lunch. Do you have a compilation warning ? -- ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
Re: [lxc-devel] [PATCH 0/7] Last minute signal stuff (now in separate mails)
On 06/07/2010 03:27 PM, Ferenc Wagner wrote: Daniel Lezcanodaniel.lezc...@free.fr writes: On 06/07/2010 12:37 PM, Ferenc Wagner wrote: there's another failure I get on my work machine (with my original patchset with the above errors corrected): gcc -I../../src -g -O2 -g -Wall -O2 -Wall -Wl,-E -Wl,-rpath -Wl,/usr/lib/lxc -o lxc-attach lxc_attach.o liblxc.so liblxc.so: undefined reference to `lxc_sync_init' liblxc.so: undefined reference to `lxc_sync_fini_parent' liblxc.so: undefined reference to `lxc_sync_barrier_parent' liblxc.so: undefined reference to `lxc_sync_fini_child' liblxc.so: undefined reference to `lxc_sync_wake_parent' liblxc.so: undefined reference to `lxc_sync_wait_child' liblxc.so: undefined reference to `lxc_sync_fini' liblxc.so: undefined reference to `lxc_sync_barrier_child' collect2: ld returned 1 exit status Have you got an idea what may be wrong here? I'll continue investigation after lunch. Do you have a compilation warning ? No real compilation warning, only this: make[2]: Entering directory `/build/wferi-lxc_0.6.6~gitf814275a-1-i386-T7QsnO/lxc-0.6.6~gitf814275a/src' cd .. /bin/sh /build/wferi-lxc_0.6.6~gitf814275a-1-i386-T7QsnO/lxc-0.6.6~gitf814275a/config/missing --run autoheader /build/wferi-lxc_0.6.6~gitf814275a-1-i386-T7QsnO/lxc-0.6.6~gitf814275a/config/missing: line 54: autoheader: command not found WARNING: `autoheader' is missing on your system. You should only need it if you modified `acconfig.h' or `configure.ac'. You might want to install the `Autoconf' and `GNU m4' packages. Grab them from any GNU archive site. touch: cannot touch `[src/config.h].in': No such file or directory rm -f stamp-h1 touch config.h.in It's probably some unfortunate interaction with the Debian build system. If I rerun autogen.sh on the build system (the source is prepared on another system with a different automake version), the build succeeds. This didn't cause problems before. Now I switched to treating the git checkout as the original source, and the problem disappeared. Looks like it's nothing to worry about, after all. ok. -- ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
