Le 2 déc. 2010 à 15:11, Pavel Sanda a écrit :
ugh. instead of hardcoding such hacks we should go for date inside
insetinfo...
Yes, or have date use a fancy python script.
We should really have a strict policy for new hardcoding, i.e. make it forbidden
by default.
JMarc
We should really have a strict policy for new hardcoding, i.e. make it
forbidden
by default.
Yes, you mean we can clear up half of the src/insets/*.cpp code if we
use layouts and generalisation more.
Vincent
Le 2 déc. 2010 à 15:29, Vincent van Ravesteijn a écrit :
We should really have a strict policy for new hardcoding, i.e. make it forbidden
by default.
Yes, you mean we can clear up half of the src/insets/*.cpp code if we
use layouts and generalisation more.
Agreed, but this is not what I
Author: rgheck
Date: Thu Dec 2 16:14:44 2010
New Revision: 36657
URL: http://www.lyx.org/trac/changeset/36657
Log:
Fix crash reported by keytest.
Modified:
lyx-devel/trunk/src/insets/InsetText.cpp
Modified: lyx-devel/trunk/src/insets/InsetText.cpp
Author: switt
Date: Thu Dec 2 17:50:12 2010
New Revision: 36659
URL: http://www.lyx.org/trac/changeset/36659
Log:
detect end of paragraph and use it as word separator to correct the word count
in tables - thanks, JMarc
Modified:
lyx-devel/trunk/src/buffer_funcs.cpp
Modified:
Author: vfr
Date: Thu Dec 2 19:00:33 2010
New Revision: 36660
URL: http://www.lyx.org/trac/changeset/36660
Log:
Fix bug #7130: Painting problem with closed Phantom Inset. The label is now
updated when the type is changed, and the arrows are correctly painted.
Modified:
- /// Call then when existing things like footnotes.
+ /// Call this when existing things like footnotes.
void restoreLastLayout() { layout_stack_.pop_back(); }
exiting ?
Besides, why are counter_stack_ and layout_stack_ deque's ?
/// Used to keep track of active counters.
Author: uwestoehr
Date: Thu Dec 2 21:56:33 2010
New Revision: 36664
URL: http://www.lyx.org/trac/changeset/36664
Log:
PersonalWordList:
- add missing SVN EOL-style
- update SCons
Modified:
lyx-devel/trunk/development/scons/scons_manifest.py
lyx-devel/trunk/src/PersonalWordList.cpp
Author: rgheck
Date: Thu Dec 2 22:05:45 2010
New Revision: 3
URL: http://www.lyx.org/trac/changeset/3
Log:
Typo.
Modified:
lyx-devel/trunk/src/Counters.h
Modified: lyx-devel/trunk/src/Counters.h
==
---
Author: rgheck
Date: Thu Dec 2 22:11:08 2010
New Revision: 36667
URL: http://www.lyx.org/trac/changeset/36667
Log:
Save a header: We don't really need a vector here.
Modified:
lyx-devel/trunk/src/Counters.cpp
lyx-devel/trunk/src/Counters.h
Modified: lyx-devel/trunk/src/Counters.cpp
I read somewhere that stacks are best implemented as deques. Don't ask me
why now,
but I think they are slightly cheaper. (I'm sure Andre would have a view
about this.)
Some googling gives me:
The C++ Standard, in section 23.1.1, offers some advice on which
containers to prefer. It says:
See also output_xhtml.h:
typedef std::dequehtml::StartTag TagDeque;
///
typedef std::vectorhtml::StartTag TagStack;
/// holds start tags until we know there is content in them.
TagDeque pending_tags_;
/// remembers the history, so we can make sure
Author: vfr
Date: Fri Dec 3 01:47:42 2010
New Revision: 36671
URL: http://www.lyx.org/trac/changeset/36671
Log:
branch: Fix bug #6315: counters in insets that don't produce output have ghost
values.
see r36603.
Modified:
lyx-devel/branches/BRANCH_1_6_X/src/Counters.cpp
Author: vfr
Date: Fri Dec 3 03:42:25 2010
New Revision: 36672
URL: http://www.lyx.org/trac/changeset/36672
Log:
Compile fix for r36670.
Modified:
lyx-devel/trunk/src/output_xhtml.cpp
Modified: lyx-devel/trunk/src/output_xhtml.cpp
Author: vfr
Date: Fri Dec 3 03:44:16 2010
New Revision: 36673
URL: http://www.lyx.org/trac/changeset/36673
Log:
Fix bug #2100: No display equations allowed in a non-fixed width tabular cell.
Modified:
lyx-devel/trunk/src/insets/InsetTabular.cpp
lyx-devel/trunk/src/mathed/InsetMathHull.cpp
Author: vfr
Date: Fri Dec 3 03:55:52 2010
New Revision: 36674
URL: http://www.lyx.org/trac/changeset/36674
Log:
Fix bug #6709: Inserting a numbered equation to a display equation toggles the
display style.
Modified:
lyx-devel/trunk/lib/ui/stdmenus.inc
Modified:
Le 2 déc. 2010 à 15:11, Pavel Sanda a écrit :
> ugh. instead of hardcoding such hacks we should go for date inside
> insetinfo...
Yes, or have date use a fancy python script.
We should really have a strict policy for new hardcoding, i.e. make it forbidden
by default.
JMarc
> We should really have a strict policy for new hardcoding, i.e. make it
> forbidden
> by default.
>
Yes, you mean we can clear up half of the src/insets/*.cpp code if we
use layouts and generalisation more.
Vincent
Le 2 déc. 2010 à 15:29, Vincent van Ravesteijn a écrit :
We should really have a strict policy for new hardcoding, i.e. make it forbidden
>> by default.
>>
>
> Yes, you mean we can clear up half of the src/insets/*.cpp code if we
> use layouts and generalisation more.
Agreed, but this is not
Author: rgheck
Date: Thu Dec 2 16:14:44 2010
New Revision: 36657
URL: http://www.lyx.org/trac/changeset/36657
Log:
Fix crash reported by keytest.
Modified:
lyx-devel/trunk/src/insets/InsetText.cpp
Modified: lyx-devel/trunk/src/insets/InsetText.cpp
Author: switt
Date: Thu Dec 2 17:50:12 2010
New Revision: 36659
URL: http://www.lyx.org/trac/changeset/36659
Log:
detect end of paragraph and use it as word separator to correct the word count
in tables - thanks, JMarc
Modified:
lyx-devel/trunk/src/buffer_funcs.cpp
Modified:
Author: vfr
Date: Thu Dec 2 19:00:33 2010
New Revision: 36660
URL: http://www.lyx.org/trac/changeset/36660
Log:
Fix bug #7130: Painting problem with closed Phantom Inset. The label is now
updated when the type is changed, and the arrows are correctly painted.
Modified:
> - /// Call then when existing things like footnotes.
> + /// Call this when existing things like footnotes.
> void restoreLastLayout() { layout_stack_.pop_back(); }
exiting ?
Besides, why are counter_stack_ and layout_stack_ deque's ?
>/// Used to keep track of active
Author: uwestoehr
Date: Thu Dec 2 21:56:33 2010
New Revision: 36664
URL: http://www.lyx.org/trac/changeset/36664
Log:
PersonalWordList:
- add missing SVN EOL-style
- update SCons
Modified:
lyx-devel/trunk/development/scons/scons_manifest.py
lyx-devel/trunk/src/PersonalWordList.cpp
Author: rgheck
Date: Thu Dec 2 22:05:45 2010
New Revision: 3
URL: http://www.lyx.org/trac/changeset/3
Log:
Typo.
Modified:
lyx-devel/trunk/src/Counters.h
Modified: lyx-devel/trunk/src/Counters.h
==
---
Author: rgheck
Date: Thu Dec 2 22:11:08 2010
New Revision: 36667
URL: http://www.lyx.org/trac/changeset/36667
Log:
Save a header: We don't really need a vector here.
Modified:
lyx-devel/trunk/src/Counters.cpp
lyx-devel/trunk/src/Counters.h
Modified: lyx-devel/trunk/src/Counters.cpp
> I read somewhere that stacks are best implemented as deques. Don't ask me
> why now,
> but I think they are slightly cheaper. (I'm sure Andre would have a view
> about this.)
Some googling gives me:
The C++ Standard, in section 23.1.1, offers some advice on which
containers to prefer. It says:
See also output_xhtml.h:
typedef std::deque TagDeque;
///
typedef std::vector TagStack;
/// holds start tags until we know there is content in them.
TagDeque pending_tags_;
/// remembers the history, so we can make sure we nest properly.
Author: vfr
Date: Fri Dec 3 01:47:42 2010
New Revision: 36671
URL: http://www.lyx.org/trac/changeset/36671
Log:
branch: Fix bug #6315: counters in insets that don't produce output have ghost
values.
see r36603.
Modified:
lyx-devel/branches/BRANCH_1_6_X/src/Counters.cpp
Author: vfr
Date: Fri Dec 3 03:42:25 2010
New Revision: 36672
URL: http://www.lyx.org/trac/changeset/36672
Log:
Compile fix for r36670.
Modified:
lyx-devel/trunk/src/output_xhtml.cpp
Modified: lyx-devel/trunk/src/output_xhtml.cpp
Author: vfr
Date: Fri Dec 3 03:44:16 2010
New Revision: 36673
URL: http://www.lyx.org/trac/changeset/36673
Log:
Fix bug #2100: No display equations allowed in a non-fixed width tabular cell.
Modified:
lyx-devel/trunk/src/insets/InsetTabular.cpp
lyx-devel/trunk/src/mathed/InsetMathHull.cpp
Author: vfr
Date: Fri Dec 3 03:55:52 2010
New Revision: 36674
URL: http://www.lyx.org/trac/changeset/36674
Log:
Fix bug #6709: Inserting a numbered equation to a display equation toggles the
display style.
Modified:
lyx-devel/trunk/lib/ui/stdmenus.inc
Modified:
32 matches
Mail list logo
