hmpf

2002-03-13 Thread Michael Koziarski
I think I do this more than anyone else -- | Michael Koziarski |"Conventional wisdom is often | | Data Engineer, Linux user | long on convention and short | | & Objectivist.

[PATCH] Fix GNOME compilation Part 1

2002-03-13 Thread Michael Koziarski
Hey guys, I've just spent some time getting the gtkmm frontend to compile again. I don't quite know how to work the build system so I've split the task into two. The attached patch fixes the compilation problems, please review and apply. However, linking still fails, John Levon tells me I n

Re: [Devel] Bug list update again

2002-03-13 Thread Allan Rae
On Wed, 13 Mar 2002, Herbert Voss wrote: > Jean-Marc Lasgouttes wrote: > > > To express things differently, I am not sure that showing everything > > wysiwyg is a panacea. For example, I would hate to see equation > > > numbers in mathed showed as just numbers instead of labels. But may is > > it

lyx-1.1.6fix4 bug: can't use cite.sty

2002-03-13 Thread Ulrich Günther
I am trying to use cite.sty in lyx. Unfortunately thje packages lsiterd in the latex preamble of lyx are inserted after everything else. If cite shows up after babel is is ignored! Any ideas how to fix this? Ulrich

Re: Tooltips revamp

2002-03-13 Thread Allan Rae
On 11 Mar 2002, Jean-Marc Lasgouttes wrote: > > "Allan" == Allan Rae <[EMAIL PROTECTED]> writes: > > >> Oops not so easy. I'll need another static signal in Dialogs.h > >> static bool SigC::Signal0 Dialogs::tooltipsEnabled; > > Allan> Why? The tooltips should have a lyxrc entry and you can to

[광고] lyx-devel님 안녕하십니까?

2002-03-13 Thread 플러스마케팅
Title: emailsale [lyx-devel´ÔÀÇ ¸ÞÀÏÁÖ¼Ò´Â ÀÌ À¥ÆäÀÌÁö¿¡¼­ º¸°í ¹ß¼ÛÇß½À´Ï´Ù. Ç÷¯½º ³ëºí·¹½º(www.Plusnoblesse.com) ¿¡¼­´Â ¸íÇ° °¡°ÝÀÎÇÏ µî À¯¿ëÇÑ Á¤º¸¸¦ Á¦°øÇÒ ¿¹Á¤À̳ª ¼ö½ÅÀ» ¿øÄ¡ ¾ÊÀ¸½Ã¸é ´Ù½Ã ¿î¿µÀÚÀÇ

Re: Lyx

2002-03-13 Thread Allan Rae
On Thu, 14 Mar 2002, Marianne Doyle wrote: > Dear Dr Rae, I'm still only a mister :( but I'm working on it! > Ian Mortimer from the physics dept said you may be able to help me with a > lyx problem. > > Is there any way to overcome the problem of not being able to use the > number key pad insi

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 09:37:33PM -0400, Garst R. Reese wrote: > I am a complete moron. hey we can form a club ! You have to say so in your signature too though, or you can't join :) john -- I am a complete moron for forgetting about endianness. May I be forever marked as such.

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 09:24:25PM -0400, Garst R. Reese wrote: > Well, apply leaves it up and in the way and it's easier to close than > switch views. > Maybe this is not a problem with more pixels. Or you could just press alt-tab or whatever your WM does to switch window stacking order... reg

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 08:36:20PM -0400, Garst R. Reese wrote: > You mean from Layout->Character I presume. When I do that the dialog > remains up and I have to close it. You have to close it ?? Why ? > But yes, I see the problem also. The OK thanks > toggle on the icon gets out of step with

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Thu, Mar 14, 2002 at 01:12:53AM +0100, Lars Gullik Bjønnes wrote: > | hmm are you sure that the icon becomes selected when you click apply > | from the dialog ? > > Dialog? You said nothing about using a dialog... Well apart from the two or three times I mentioned using it, including the ste

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, Mar 14, 2002 at 12:50:29AM +0100, Lars Gullik Bjønnes wrote: > >> cursor in front of 1: icon on > | hmm are you sure that the icon becomes selected when you click apply | from the dialog ? Dialog? You said nothing about using a dialog... | If you

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Thu, Mar 14, 2002 at 12:50:29AM +0100, Lars Gullik Bjønnes wrote: > cursor in front of 1: icon on hmm are you sure that the icon becomes selected when you click apply from the dialog ? If you're moving the cursor with arrow keys then the problem won't be seen. Another problem (UserGuide as

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, Mar 14, 2002 at 12:35:58AM +0100, Lars Gullik Bjønnes wrote: > >> Either I do not understand what you mean, or I don't have the problem. > | Actually this might be on older bug, it happens on an older 1.2 build | ... > | start new doc. > | type som

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Thu, Mar 14, 2002 at 12:35:58AM +0100, Lars Gullik Bjønnes wrote: > Either I do not understand what you mean, or I don't have the problem. Actually this might be on older bug, it happens on an older 1.2 build ... start new doc. type some text. change character dialog to italic and apply (

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, Mar 14, 2002 at 12:21:09AM +0100, Lars Gullik Bjønnes wrote: > >> If I just move the cursor over some '!' text, the toolbar button gets >> "pressed". > | Yes this works OK for me, but just typing after changes doesn't i.e. | the icons don't represe

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Thu, Mar 14, 2002 at 12:21:09AM +0100, Lars Gullik Bjønnes wrote: > If I just move the cursor over some '!' text, the toolbar button gets > "pressed". Yes this works OK for me, but just typing after changes doesn't i.e. the icons don't represent what the next char will look like john -- I

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, Mar 14, 2002 at 12:00:12AM +0100, Lars Gullik Bjønnes wrote: > >> This should fix this and the rest of them, please test. > | It fixes the problems Ive mentioned, but there is another: the '!' icon | is broken. > | Apply Italic font change via the

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, Mar 14, 2002 at 12:00:12AM +0100, Lars Gullik Bjønnes wrote: > >> This should fix this and the rest of them, please test. > | It fixes the problems Ive mentioned, but there is another: the '!' icon | is broken. > | Apply Italic font change via the

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Thu, Mar 14, 2002 at 12:08:35AM +0100, Lars Gullik Bjønnes wrote: > >> btw. My name is not Lar... > | Ha ! And my name isn't Levon. So I suppose we are equal Then I'd like to know your name ;-) Or are you afraid that we will gain access to the Powers

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Thu, Mar 14, 2002 at 12:00:12AM +0100, Lars Gullik Bjønnes wrote: > This should fix this and the rest of them, please test. It fixes the problems Ive mentioned, but there is another: the '!' icon is broken. Apply Italic font change via the dialog to the current cursor position, and it change

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Thu, Mar 14, 2002 at 12:08:35AM +0100, Lars Gullik Bjønnes wrote: > btw. My name is not Lar... Ha ! And my name isn't Levon. So I suppose we are equal > (on a side note: Is that a name anywhere?) My English skills are inversely proportional to the speed of my internet connection ... For so

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 11:54:53PM +0100, Lars Gullik Bjønnes wrote: > This fix should be applied to all places where I did this change then. OK, I'll let you do that because I don't know how :) Currently you the first characeter of a word is not getting set to a font change either. Oh and you

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread Lars Gullik Bjønnes
btw. My name is not Lar... (on a side note: Is that a name anywhere?) -- Lgb

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | Load Intro.lyx and look at the "You tell LyX what you're doing". > | A fencepost error, but they accumulate in the saved version. > | The fix is attached. I don't know/care if it's right. This should fix this and the rest of them, please test. Index: src

Re: [PATCH] Lar's optimisation font patch broken

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | Load Intro.lyx and look at the "You tell LyX what you're doing". > | A fencepost error, but they accumulate in the saved version. > | The fix is attached. I don't know/care if it's right. > | thanks | john > | -- | I am a complete moron for forgetting abo

[PATCH] Lar's optimisation font patch broken

2002-03-13 Thread John Levon
Load Intro.lyx and look at the "You tell LyX what you're doing". A fencepost error, but they accumulate in the saved version. The fix is attached. I don't know/care if it's right. thanks john -- I am a complete moron for forgetting about endianness. May I be forever marked as such. Index:

Re: Keyboard handling

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 09:44:55PM +, John Levon wrote: > stupid question, but how do normal keypresses like 'a' end up so that a lookup() in the kbmap returns LFUN_INSERT ??? thanks john -- I am a complete moron for forgetting about endianness. May I be forever marked as such.

Keyboard handling

2002-03-13 Thread John Levon
ouch ! Klyx punts the issue by not using Qt's key event structure. I think we need a buffer view slot : where LKeySym is our own enum/class for all the "special" keys like F1, Up, PageDown etc. The reason I don't want to use X key events in the Qt frontend is mainly so we can use se

Re: C++ question

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 6:08 pm, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | If I have a map some_map, can I create a vector of the keys also, > | vector ref_vec? I can create a vector ptr_vec. > > > | I'm thinking of my Bibtex data base of course. > > You c

Re: C++ question

2002-03-13 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | If I have a map some_map, can I create a vector of the keys also, | vector ref_vec? I can create a vector ptr_vec. > | I'm thinking of my Bibtex data base of course. You cannot "reset" an reference; string a("Hello There!"); string & b = a; string c(

C++ question

2002-03-13 Thread Angus Leeming
If I have a map some_map, can I create a vector of the keys also, vector ref_vec? I can create a vector ptr_vec. I'm thinking of my Bibtex data base of course. /** All Bibliography keys derive from this base class, and need only define * code() to be instantiated. */ class BibKey { public:

Re: [patch] (html)URL - inset

2002-03-13 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Also it would be nice if the patch did not try to remove double LF | btween methods and change tab-indentation to 4char indentation :) But | this is secondary. Not to me. -- Lgb

Re: [patch] (html)URL - inset

2002-03-13 Thread Jean-Marc Lasgouttes
> "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes: Back to this one... Believe it or not, I would like to resolve it before 1.2.0. Herbert> Jean-Marc Lasgouttes wrote: >> To rephrase myself: could this html check button produce code using >> hyperref \href instead of html.sty version? W

Re: guii patch

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 05:07:15PM +0100, Lars Gullik Bjønnes wrote: > I have said this before, and I am sure you have seen it, but you have > probaly not understood the implications: > > We are using xforms wrong. > > We are not calling xforms functions as a result some events all the

Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 05:13:56PM +0100, Lars Gullik Bjønnes wrote: > Especially not for stuff that is main tasks for the next development > round. hmm. This would mean you would have to accept patches that are not perfect. I've tried to look for ways to do the Andre thing of small gradual cha

Re: Compilation error

2002-03-13 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Wednesday 13 March 2002 3:36 pm, Dekel Tsur wrote: >> Once again, my compiler (egcs 1.1.2) refuses to compile lyx: >> >> g++ -DHAVE_CONFIG_H -I. -I. -I../../../src -I../../../images -I../../../src/ >> -I../../../src/frontends/ -I../../../src/fronten

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | So perhaps we should make a branch now yes. Especially as I appear to | have exhausted my supply of 1.2 bugfixes... > | I expect the branch will last 6 months or so before the interfaces are | good enough to hit the main tree but I suppose that depends on

Re: [Devel] Bug list update again

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 4:11 pm, Herbert Voss wrote: > Jean-Marc Lasgouttes wrote: > > >>"Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes: > >> > > > > Herbert> why should they get an empty button?? I thought you tried > > Herbert> it?? > > > > I tried it. I sent an example file.

Re: Compilation error

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 3:36 pm, Dekel Tsur wrote: > Once again, my compiler (egcs 1.1.2) refuses to compile lyx: > > g++ -DHAVE_CONFIG_H -I. -I. -I../../../src -I../../../images -I../../../src/ > -I../../../src/frontends/ -I../../../src/frontends/controllers -I../../.. > -I../../.. -I../../..

Re: guii patch

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Mar 13, 2002 at 02:44:55PM +, Angus Leeming wrote: > >> > I'm not sure of the point of this - are you planning on writing a pure >> > Xlib frontend ? >> >> Not me. But that't not the point. xforms in xforms, qt2 in qt2 and X11 in >> X11. It c

Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 03:59:11PM +, Angus Leeming wrote: > Sure it is. This stuff _should_ go in a branch. Then we can hack away > happily. Yeah but I don't want to spend ages merging. You had enough trouble with that during MVC branch, from the sounds of it. Of course the branch will h

Re: Painter diff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 3:41 pm, John Levon wrote: > On Wed, Mar 13, 2002 at 02:50:41PM +, Angus Leeming wrote: > > > Along the same lines, can you try my BufferView_pimpl.C patch in your tree > > "proposed cursor patch try 2". Presumably those fl_set_cursor calls should > > become cal

Re: guii patch

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 02:44:55PM +, Angus Leeming wrote: > > I'm not sure of the point of this - are you planning on writing a pure > > Xlib frontend ? > > Not me. But that't not the point. xforms in xforms, qt2 in qt2 and X11 in > X11. It costs us nothing and leads to improved clarity.

Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 02:50:41PM +, Angus Leeming wrote: > Along the same lines, can you try my BufferView_pimpl.C patch in your tree > "proposed cursor patch try 2". Presumably those fl_set_cursor calls should > become calls to a new WorkArea method? I suspect so, but I'm not sure what

Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 03:47:33PM +0100, Lars Gullik Bjønnes wrote: > Yup. OK -- I am a complete moron for forgetting about endianness. May I be forever marked as such.

Compilation error

2002-03-13 Thread Dekel Tsur
Once again, my compiler (egcs 1.1.2) refuses to compile lyx: g++ -DHAVE_CONFIG_H -I. -I. -I../../../src -I../../../images -I../../../src/ -I../../../src/frontends/ -I../../../src/frontends/controllers -I../../.. -I../../.. -I../../../boost -isystem /usr/X11R6/include -O -fno-rtti -fno-exceptions

Re: Painter diff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 2:42 pm, John Levon wrote: > On Wed, Mar 13, 2002 at 01:25:14PM +0100, Lars Gullik Bjønnes wrote: > > > These are the changes I have in my tree now: > > > > Index: PainterBase.C > > I can't help but think that you committed this thoroughly > cosmetic patch just to mak

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | I can't help but think that you committed this thoroughly | cosmetic patch just to make my life harder. Yup. -- Lgb

Re: guii patch

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 2:37 pm, John Levon wrote: > I'm not sure of the point of this - are you planning on writing a pure > Xlib frontend ? Not me. But that't not the point. xforms in xforms, qt2 in qt2 and X11 in X11. It costs us nothing and leads to improved clarity. > > 1.3 is going to

Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 01:25:14PM +0100, Lars Gullik Bjønnes wrote: > These are the changes I have in my tree now: > > Index: PainterBase.C I can't help but think that you committed this thoroughly cosmetic patch just to make my life harder. john -- I am a complete moron for forgetting abou

Re: guii patch

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 01:34:49PM +, Angus Leeming wrote: > One tiny thing on the #include front: you don't need WorkArea.h in > BufferView_pimpl.h anymore. indeed ! > As Asger says, it's hard to see what is changed and what is just moved into > frontends. Am I right in saying that you'v

Re: [Devel] Bug list update again

2002-03-13 Thread Herbert Voss
Jean-Marc Lasgouttes wrote: > To express things differently, I am not sure that showing everything > wysiwyg is a panacea. For example, I would hate to see equation > numbers in mathed showed as just numbers instead of labels. But may is > it just because I am used to give meaningful names to my

Re: makefile patch

2002-03-13 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: >> Lars> | Lars> Ok, does this patch taste better? >> Lars> | Definitely. We have to be sure though that it work

Re: [Devel] Bug list update again

2002-03-13 Thread Jean-Marc Lasgouttes
> "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes: Herbert> again: the patch makes some people happy who like more Herbert> wysiwyg. And the argument of JMarc that a cryptic key is more Herbert> useful than the real output, is not an argument! that is all! Hmm, this is the kind of argum

Re: makefile patch

2002-03-13 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Ok, does this patch taste better? > | Definitely. We have to be sure though that it works for `reasonable' | non-GNU makes. But we'll find out soon enough... > | A small nit

Re: [Devel] Bug list update again

2002-03-13 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Wednesday 13 March 2002 1:19 pm, Herbert Voss wrote: >> again: the patch makes some people happy who like more wysiwyg. >> And the argument of JMarc that a cryptic key is more >> useful than the real output, is not an argument! >> that is all! When y

Re: makefile patch

2002-03-13 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Ok, does this patch taste better? Definitely. We have to be sure though that it works for `reasonable' non-GNU makes. But we'll find out soon enough... A small nit: I do not like the name include.am. I'd rather have something

Re: [Devel] Bug list update again

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 1:19 pm, Herbert Voss wrote: > again: the patch makes some people happy who like more wysiwyg. > And the argument of JMarc that a cryptic key is more > useful than the real output, is not an argument! > that is all! When you rewrite the citation stuff, you can > delete w

Re: makefile patch

2002-03-13 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> This is a think I have been planning to do with the makefiles | Lars> for a long time. I am sure there are details that can be | Lars> imporved, but this should make sure th

Re: guii patch

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 12:55 pm, John Levon wrote: > On Wed, Mar 13, 2002 at 12:38:17AM +, John Levon wrote: > > > http://www.movement.uklinux.net/q1.diff.gz > > q1.diff.bz2 Thank you. One tiny thing on the #include front: you don't need WorkArea.h in BufferView_pimpl.h anymore. As A

Re: [Devel] Bug list update again

2002-03-13 Thread Herbert Voss
On Wed, 13 Mar 2002, Angus Leeming wrote: > On Wednesday 13 March 2002 12:40 pm, Jean-Marc Lasgouttes wrote: > > > "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes: > > > > >> - Citation labels should reflect their content, i.e. if only the > > >> year is chosen in the citation dialog, th

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Yes. In this case I think that the helper function isn't a help. I have yet another patch for you too look at, the thing missing now is to get rid of the XChar2b stuff. We want to use wchar_t in interfaces. (and if wchar_t is not supported, then we sho

q1.diff.bz2

2002-03-13 Thread Asger K. Alstrup Nielsen
Hi, I read the patch quickly, and it looks fine to me. Of course, a ChangeLog would be nice, because it is practically impossible to see what changes you have done to files that were moved. Greets, Asger

Re: [Devel] Bug list update again

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 12:40 pm, Jean-Marc Lasgouttes wrote: > > "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes: > > >> - Citation labels should reflect their content, i.e. if only the > >> year is chosen in the citation dialog, then the label should show > >> the year afterwards. (

Re: Painter diff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 12:55 pm, Lars Gullik Bjønnes wrote: > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > > | Angus Leeming <[EMAIL PROTECTED]> writes: > > > | | On Wednesday 13 March 2002 12:25 pm, Lars Gullik Bjønnes wrote: > >> > >>> Index: Painter.h > >>> ===

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Angus Leeming <[EMAIL PROTECTED]> writes: > | | On Wednesday 13 March 2002 12:25 pm, Lars Gullik Bjønnes wrote: >> >>> Index: Painter.h >>> === >>> private: >>> + /// For the figin

Re: guii patch

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 12:38:17AM +, John Levon wrote: > http://www.movement.uklinux.net/q1.diff.gz q1.diff.bz2 john

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Wednesday 13 March 2002 12:25 pm, Lars Gullik Bjønnes wrote: > >> Index: Painter.h >> === >> private: >> +/// For the figinset >> +PainterBase & pixmap(int x, int y, int w, int

Re: configure question

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 12:28 pm, Jean-Marc Lasgouttes wrote: > Angus> Having just updated my tree, JMarc's change to configure.in > Angus> triggered an automatic rerun of configure. In the past this has > Angus> failed to run correctly, because configure has insisted on > Angus> using g++ rath

Re: math-macro-arg does not work

2002-03-13 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Tue, Mar 12, 2002 at 02:39:11PM +0100, Jean-Marc Lasgouttes Andre> wrote: >> I get a message `a truly unknown func' with math-macro-arg, whereas >> math-macro works well. Andre> I guess this has not found much testing lately si

Re: Painter diff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 12:25 pm, Lars Gullik Bjønnes wrote: > Index: Painter.h > === > private: > + /// For the figinset > + PainterBase & pixmap(int x, int y, int w, int h, Pixmap bitmap); > + Errr, why? Helper fu

Re: configure question

2002-03-13 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Having just updated my tree, JMarc's change to configure.in Angus> triggered an automatic rerun of configure. In the past this has Angus> failed to run correctly, because configure has insisted on Angus> using g++ rather than deccx

Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
These are the changes I have in my tree now: Index: PainterBase.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/PainterBase.C,v retrieving revision 1.10 diff -u -p -r1.10 PainterBase.C --- PainterBase.C 30 Jul 2001 11:55:

Re: makefile patch

2002-03-13 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> I just saw that we used "foreign 1.4" in a couple of files, I'll | Lars> be happy with just "foreign" > | OK. > | Lars> It makes things easier, and although we get some clut

Re: small stuff

2002-03-13 Thread Andre Poenitz
On Wed, Mar 13, 2002 at 12:07:46PM +, Angus Leeming wrote: > > Uh... I just see we need Pixmap defined... > > We do not to #include for that, do we? > > it's just a long int isn't it? Here at least. Depends on architecture after reading X11/X.h. I would not simply use a 'long'... Andre' -

Re: small stuff

2002-03-13 Thread Andre Poenitz
On Wed, Mar 13, 2002 at 01:05:13PM +0100, Lars Gullik Bjønnes wrote: > I am stil for the getPixmap solution, but leave the includes as is. > Then it should work right? No, if we have Pixmap getPixmap() we need a full definition for Pixmap (which is a typedef to some XID, so it can't even be sen

Re: makefile patch

2002-03-13 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I just saw that we used "foreign 1.4" in a couple of files, I'll Lars> be happy with just "foreign" OK. Lars> It makes things easier, and although we get some clutter and Lars> unwanted stuff in include.am, we get a much nice

Re: figinset cruft

2002-03-13 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> This is cruft from the figinset. It should go, go , go! Angus Go ahead. JMarc

Re: small stuff

2002-03-13 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> On Wednesday 13 March 2002 11:50 am, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | On Wed, Mar 13, 2002 at 12:35:06PM +0100, Lars Gullik Bjønnes wrote: >> >> How hard is it to make owner_ private?

Re: small stuff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 11:58 am, Andre Poenitz wrote: > On Wed, Mar 13, 2002 at 12:50:25PM +0100, Lars Gullik Bjønnes wrote: > > | So we could have > > |a private 'owner_' and a protected 'getPixmap' > > > > a protected getPixmap is then probably best. > > Uh... I just see we need Pixmap

Re: small stuff

2002-03-13 Thread Andre Poenitz
On Wed, Mar 13, 2002 at 11:59:32AM +, Angus Leeming wrote: > Incidentally, these are historical cruft too by the look of things... > > aleem@pneumon:src-> grep -n dummy Painter*.[Ch] > PainterBase.C:21:int PainterBase::dummy1 = 0; > PainterBase.C:22:int PainterBase::dummy2 = 0; > PainterBase.

Re: small stuff

2002-03-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Mar 13, 2002 at 12:50:25PM +0100, Lars Gullik Bjønnes wrote: >> | So we could have >> |a private 'owner_' and a protected 'getPixmap' >> >> a protected getPixmap is then probably best. > | Uh... I just see we need Pixmap defined... | We do

Re: small stuff

2002-03-13 Thread Andre Poenitz
On Wed, Mar 13, 2002 at 12:50:25PM +0100, Lars Gullik Bjønnes wrote: > | So we could have > |a private 'owner_' and a protected 'getPixmap' > > a protected getPixmap is then probably best. Uh... I just see we need Pixmap defined... We do not to #include for that, do we? > | or > |a pr

Re: small stuff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 11:50 am, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Wed, Mar 13, 2002 at 12:35:06PM +0100, Lars Gullik Bjønnes wrote: > >> How hard is it to make owner_ private? > > > | It is only use a couple of times to call a single function: >

Re: small stuff

2002-03-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Mar 13, 2002 at 12:35:06PM +0100, Lars Gullik Bjønnes wrote: >> How hard is it to make owner_ private? > | It is only use a couple of times to call a single function: > |owner_.getPixmap() > | So we could have |a private 'owner_' and a p

Re: small stuff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 11:43 am, Andre Poenitz wrote: > On Wed, Mar 13, 2002 at 12:35:06PM +0100, Lars Gullik Bjønnes wrote: > > How hard is it to make owner_ private? > > It is only use a couple of times to call a single function: > >owner_.getPixmap() > > So we could have >a priva

Re: small stuff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 11:45 am, Andre Poenitz wrote: > On Wed, Mar 13, 2002 at 11:41:59AM +, Angus Leeming wrote: > > > How hard is it to make owner_ private? > > > > If you're modifying Painter, then perhaps you could merge image() and > > pixmap() as we no longer have a figinset. > >

Re: small stuff

2002-03-13 Thread Andre Poenitz
On Wed, Mar 13, 2002 at 11:41:59AM +, Angus Leeming wrote: > > How hard is it to make owner_ private? > > If you're modifying Painter, then perhaps you could merge image() and > pixmap() as we no longer have a figinset. Uh.. it was just trivial stuff that caught my eye when hunting for 'pap

Re: small stuff

2002-03-13 Thread Andre Poenitz
On Wed, Mar 13, 2002 at 12:35:06PM +0100, Lars Gullik Bjønnes wrote: > How hard is it to make owner_ private? It is only use a couple of times to call a single function: owner_.getPixmap() So we could have a private 'owner_' and a protected 'getPixmap' or a protected 'owner() const'

Re: small stuff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 11:35 am, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | * whitespace changes > | * member var with trailing underscore > > I try to stay with the rule that only private class variables get the > trailing underscore. > > How hard is it to

proposed cursor patch try 2

2002-03-13 Thread Angus Leeming
Gives us a well behaved and configurable cursor in the main window as well as in the dialogs (fixes bug #73). Angus Index: src/BufferView_pimpl.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/BufferView_pimpl.C,v retrieving rev

Re: small stuff

2002-03-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | * whitespace changes | * member var with trailing underscore I try to stay with the rule that only private class variables get the trailing underscore. How hard is it to make owner_ private? -- Lgb

small stuff

2002-03-13 Thread Andre Poenitz
* whitespace changes * member var with trailing underscore * one-line comments changed to /// Ok to apply (together with ChangeLog entry)? Andre' -- André Pönitz .. [EMAIL PROTECTED] Index: Painter.C ===

Re: getFontSettings optimization

2002-03-13 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > > | Lars> Each sample counts as 0.01 seconds. | [...] > | getFontSettings is down to .23ms/call from 0.89. This is good. > | Lars> | I've been wanting to work on getFontSetting aft

Re: read access to Painter::owner

2002-03-13 Thread Andre Poenitz
On Wed, Mar 13, 2002 at 11:52:55AM +0100, Juergen Vigna wrote: > > MathXArray::draw(). I just want to skip any work for cell outside the > > visible workarea. > > Have a look at InsetTabular::draw I'll do that there too. Ah... PainterBase::paperHeight() and ...Width() seem to do the trick. Andr

Re: getFontSettings optimization

2002-03-13 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Each sample counts as 0.01 seconds. [...] getFontSettings is down to .23ms/call from 0.89. This is good. Lars> | I've been wanting to work on getFontSetting after 1.2.0, so I Lars> would | like to see whether this very simp

Re: read access to Painter::owner

2002-03-13 Thread Juergen Vigna
On 13-Mar-2002 Andre Poenitz wrote: > MathXArray::draw(). I just want to skip any work for cell outside the > visible workarea. Have a look at InsetTabular::draw I'll do that there too. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna

figinset cruft

2002-03-13 Thread Angus Leeming
This is cruft from the figinset. It should go, go , go! Angus Index: src/WorkArea.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/WorkArea.C,v retrieving revision 1.62 diff -u -p -r1.62 WorkArea.C --- src/WorkArea.C 28 Feb

Re: getFontSettings optimization

2002-03-13 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> I think this is a better algorithm for font lookup. (at least | Lars> gprof tells me so) > | This is probably true, since there are very few font changes in a | typical para

  1   2   >