Re: LyX/Mac 1.3.6 - Keybindings

2005-06-03 Thread Juergen Spitzmueller
Bennett Helm wrote: Something needs to change, and the question is what. Here are some options (which I think go from less desirable to more desirable, other things being equal): Perhaps the easiest solution (for 1.3.6) is to disable the QIMEvent stuff for Mac. For 1.4, I think we have to

Re: LyX/Mac 1.3.6 - Keybindings

2005-06-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: Perhaps the easiest solution (for 1.3.6) is to disable the QIMEvent stuff for Mac. For 1.4, I think we have to investigate further. Did the qt-immodule problem (bug 1830) occur on Mac or is qt/mac not patched with qt-immodule at all? After some more investigation

Re: LyX/Mac 1.3.6 - Keybindings

2005-06-03 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Juergen Spitzmueller wrote: Perhaps the easiest solution (for 1.3.6) is to disable the QIMEvent stuff for Mac. For 1.4, I think we have to investigate further. Did the qt-immodule problem (bug 1830) occur on Mac or is qt/mac

Re: LyX/Mac 1.3.6 - Keybindings

2005-06-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: It is definitely the best solution. About the tests, what about using #if defined(Q_WS_X11) QT_VERSION = 0x030200 OK. I was careful because I didn't know how these two tests can be mixed. Thanks. You could also define a USE_INPUT_METHODS in QContentPane.h #if

Re: [PATCH] fix selection of error range through errorlist dialog

2005-06-03 Thread Jean-Marc Lasgouttes
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Jean-Marc The following patch fixes in the common cases the selection Jean-Marc relevant document range when clicking on an entry of the Jean-Marc errorlist dialog. There are still cases where this does not Jean-Marc work at all, the

Re: [Patch] Re: [patch] key event queue

2005-06-03 Thread Helge Hafting
Lars Gullik Bjnnes wrote: Martin Vermeer [EMAIL PROTECTED] writes: [...] | No, I meant that just the other way around. The fact that fast mouse | scrolling exists allows us to make keyboard scrolling slow... as your | event queue for ex. does. The slowness will drive people to use the |

[PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=961 The attached patch reimplements those lfuns. It also fixes InsetBibtex::delDatabase, which is broken in 1.3. The only drawback is that the lfuns are not working when the cursor sits behind the inset. The same applies to 1.3. The reason is that

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen The only drawback is that the lfuns are not working when the Juergen cursor sits behind the inset. The same applies to 1.3. The Juergen reason is that getInsetByCode stops at the end of the Juergen document. Did you look at

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: Did you look at gotoInset in bufferview_funcs.[Ch]? Yes, but I think this is not what I need here. gotoInset moves the cursor to the next inset, while LFUN_BIBDB_* needs the next bibtex inset, without moving the cursor. It would probably make more sense to use

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: /// Get next inset of this class from current cursor position template class T T * getInsetByCode(LCursor cur, InsetBase::Code code) { T * inset = 0; DocIterator it = cur; if (it.nextInset()    it.nextInset()-lyxCode() == code)

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: I'm not even sure I understand what LABEL_GOTO does (or is it broken?) OK, now I do. This is really odd. Jürgen

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: I'm not even sure I understand what LABEL_GOTO does (or is it broken?) OK, now I do. This is really odd. I think this menu entry is extremely irritating. How about the following patch, that does enable the entry only when it actually makes sense? Jürgen Index:

Re: LyX/Mac 1.3.6 - Keybindings

2005-06-03 Thread Juergen Spitzmueller
Bennett Helm wrote: > Something needs to change, and the question is what. Here are some > options (which I think go from less desirable to more desirable, other > things being equal): Perhaps the easiest solution (for 1.3.6) is to disable the QIMEvent stuff for Mac. For 1.4, I think we have to

Re: LyX/Mac 1.3.6 - Keybindings

2005-06-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Perhaps the easiest solution (for 1.3.6) is to disable the QIMEvent stuff > for Mac. For 1.4, I think we have to investigate further. > > Did the qt-immodule problem (bug 1830) occur on Mac or is qt/mac not > patched with qt-immodule at all? After some more

Re: LyX/Mac 1.3.6 - Keybindings

2005-06-03 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Juergen Spitzmueller wrote: >> Perhaps the easiest solution (for 1.3.6) is to disable the QIMEvent >> stuff for Mac. For 1.4, I think we have to investigate further. >> >> Did the qt-immodule problem (bug 1830) occur on

Re: LyX/Mac 1.3.6 - Keybindings

2005-06-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > It is definitely the best solution. About the tests, what about using > #if defined(Q_WS_X11) && QT_VERSION >= 0x030200 OK. I was careful because I didn't know how these two tests can be mixed. Thanks. > You could also define a USE_INPUT_METHODS in QContentPane.h >

Re: [PATCH] fix selection of error range through errorlist dialog

2005-06-03 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> The following patch fixes in the common cases the selection Jean-Marc> relevant document range when clicking on an entry of the Jean-Marc> errorlist dialog. There are still cases where this does not Jean-Marc> work

Re: [Patch] Re: [patch] key event queue

2005-06-03 Thread Helge Hafting
Lars Gullik Bjønnes wrote: Martin Vermeer <[EMAIL PROTECTED]> writes: [...] | No, I meant that just the other way around. The fact that fast mouse | scrolling exists allows us to make keyboard scrolling slow... as your | event queue for ex. does. The slowness will drive people to use the

[PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=961 The attached patch reimplements those lfuns. It also fixes InsetBibtex::delDatabase, which is broken in 1.3. The only drawback is that the lfuns are not working when the cursor sits behind the inset. The same applies to 1.3. The reason is that

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> The only drawback is that the lfuns are not working when the Juergen> cursor sits behind the inset. The same applies to 1.3. The Juergen> reason is that getInsetByCode stops at the end of the Juergen> document. Did you

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Did you look at gotoInset in bufferview_funcs.[Ch]? Yes, but I think this is not what I need here. gotoInset moves the cursor to the next inset, while LFUN_BIBDB_* needs the next bibtex inset, without moving the cursor. It would probably make more sense to use

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > /// Get next inset of this class from current cursor position > template > T * getInsetByCode(LCursor & cur, InsetBase::Code code) > { > T * inset = 0; > DocIterator it = cur; > if (it.nextInset() && >    it.nextInset()->lyxCode() ==

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > I'm not even sure I understand what LABEL_GOTO does (or is it broken?) OK, now I do. This is really odd. Jürgen

Re: [PATCH] Bug 961: reintroduce LFUN_BIBDB_ADD/DEL

2005-06-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > > I'm not even sure I understand what LABEL_GOTO does (or is it broken?) > > OK, now I do. This is really odd. I think this menu entry is extremely irritating. How about the following patch, that does enable the entry only when it actually makes sense? Jürgen