Re: [patch] fix setDefaultParagraph in insettabular

Georg == Georg Baum [EMAIL PROTECTED] writes: Georg I see. I would also document the argument of Georg forceDefaultParagraphs in insetbase.h so that misunderstandings Georg like in the current code do not longer happen: Georg /// if this inset has paragraphs should they be output all as Georg

lyx win1.3.6

 first i install software lyx, and run, but i had problem with view View→PDF or View-- PS, (view-dvi run) i search for resolver it i see http://wiki.lyx.org/Windows/LyX136and old version lyx win page, but at the end, on the bar menu view, i not see view-dvi ), i think to uninstall lyx, and

Re: ftp://ftp.sylvan.com/pub/lyx/devel

On Mon, Nov 14, 2005 at 10:58:09AM +0100, Hartmut Haase wrote: Hello Kayvan Sylvan, could you just provide a tarred lyx-devel directory. A lyx-devel.tar.bz2 would only have ~6MB. Okay. Done. And automatically updated from this point on. It's at

Re: [patch] fix setDefaultParagraph in insettabular

Georg Baum wrote: I see. I would also document the argument of forceDefaultParagraphs in insetbase.h so that misunderstandings like in the current code do not longer happen: /// if this inset has paragraphs should they be output all as default /// paragraphs with Standard layout? /// \p in

Re: [patch] fix setDefaultParagraph in insettabular

Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Georg Baum wrote: I see. I would also document the argument of forceDefaultParagraphs in insetbase.h so that misunderstandings like in the current code do not longer happen: /// if this inset has paragraphs should they be

Re: [patch] fix setDefaultParagraph in insettabular

Jean-Marc Lasgouttes wrote: And the parameter passed to the method seems bogus to me. It seems to be always like inset.forceDefaultParagraphs(inset) The only case that is different is with insettabular, it seems. This does not make sense... It makes sense in so far as the parameter is

Re: [patch] fix setDefaultParagraph in insettabular

Juergen Spitzmueller wrote: Is it worth it to add the argument for documentation purposes? The argument is already there. Do you mean to name it? IMHO it is worth it. Attached is a patch with some mor FIXME's and the proposed documentation (without having added the argument). Would this

[Patch in bugzilla] for 1966, and others

As it says. http://bugzilla.lyx.org/show_bug.cgi?id=1966 Also, Stephan's fix to 1656 was confirmed, and a fix to 822 is also in: http://bugzilla.lyx.org/show_bug.cgi?id=822 (and my 2015 fix is in Lars's queue...) Just for reference. - Martin signature.asc Description: This is a digitally

Re: lyx win1.3.6

[EMAIL PROTECTED] wrote: first i install software lyx, and run, but i had problem with view View→PDF or View-- PS, (view-dvi run) i search for resolver it i see http://wiki.lyx.org/Windows/LyX136 and old version lyx win page, but at the end, on the bar menu view, i not see view-dvi ), i think

Re: [New patch] Re: Fix for bug 2015: font properties propagation in environments

Andre Poenitz [EMAIL PROTECTED] writes: | ParagraphList::const_iterator it = | find_if(pars_.begin(), pars_.end(), some_functor(par)); | | Why? It's obviously more code to type, to read, and not simpler to | understand. You obviously could write out the for loop but cut

Re: [New patch] Re: Fix for bug 2015: font properties propagation in environments

Andre Poenitz [EMAIL PROTECTED] writes: | + pit_type pit = 0; | + for ( ; pit pars_.size() pars_[pit] != par; ++pit) | + ; You know... terse does not mean easy to understand. -- Lgb

Re: Fix for bug 2015: font properties propagation in environments

Andre Poenitz [EMAIL PROTECTED] writes: | On Wed, Nov 09, 2005 at 10:21:19AM +0100, Georg Baum wrote: | class ParAddressEqual : public std::unary_functionParagraph, bool { | public: | ParAddressEqual(Paragraph const * par) : par_(par) {} | bool operator()(Paragraph const par)

Re: [Patch in bugzilla] for 1966, and others

Martin Vermeer [EMAIL PROTECTED] writes: | (and my 2015 fix is in Lars's queue...) I have a queue? -- Lgb

Re: [patch] fix setDefaultParagraph in insettabular

Jean-Marc Lasgouttes wrote: What about redefining as virtual bool forceDefaultParagraphs(idx_type cell =0) Paragraph::forceDefaultParagraph would pass 0 (or no value), the others would use the cursor. Considering the low number of instance of this method, it seems both easy and correct.

Re: [patch] fix setDefaultParagraph in insettabular

Juergen Spitzmueller wrote: Jean-Marc Lasgouttes wrote: The problem is probably (as in bugs 1952/53) that there is no way when the cursor is in a tabular (top.inset() is the insettabular) to access the insettext itself (the cell). InsetTabular suffers from some personality disorder: it is a

Re: [patch] fix setDefaultParagraph in insettabular

Jean-Marc Lasgouttes wrote: What about redefining as virtual bool forceDefaultParagraphs(idx_type cell =0) Paragraph::forceDefaultParagraph would pass 0 (or no value), the others would use the cursor. Looks much nicer :-) I wonder if passing 0 from Paragraph::forceDefaultParagraphs() is

Re: When will the 1.3.7 released

Luis Rivera wrote: I think I have the squasher somewhere... let me see... do we have the NewAPI.h patch somewhere in the cvs tree? Where should I look for to see the existing patches? The NewAPI.h patch is already in the code base. However, from what I understand, it, or our use of it, is

Re: [Patch in bugzilla] for 1966, and others

On Mon, Nov 14, 2005 at 05:23:29PM +0200, Martin Vermeer wrote: As it says. http://bugzilla.lyx.org/show_bug.cgi?id=1966 Also, Stephan's fix to 1656 was confirmed, and a fix to 822 is also in: http://bugzilla.lyx.org/show_bug.cgi?id=822 (and my 2015 fix is in Lars's queue...) Just

Re: [Patch in bugzilla] for 1966, and others

On Mon, Nov 14, 2005 at 11:04:36PM +0100, Helge Hafting wrote: On Mon, Nov 14, 2005 at 05:23:29PM +0200, Martin Vermeer wrote: As it says. http://bugzilla.lyx.org/show_bug.cgi?id=1966 Also, Stephan's fix to 1656 was confirmed, and a fix to 822 is also in:

Re: [patch] fix setDefaultParagraph in insettabular

Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Looks much nicer :-) Indeed. If it works to your liking, please apply it. Juergen I wonder if passing 0 from Juergen Paragraph::forceDefaultParagraphs() is always correct, Juergen though. I think it is equivalent to what we

Re: [patch] fix setDefaultParagraph in insettabular

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> I see. I would also document the argument of Georg> forceDefaultParagraphs in insetbase.h so that misunderstandings Georg> like in the current code do not longer happen: Georg> /// if this inset has paragraphs should they be output

lyx win1.3.6

 first i install software lyx, and run, but i had problem with view View→PDF  or View--> PS, (view->dvi run) i search for resolver it i see http://wiki.lyx.org/Windows/LyX136 and old version lyx win page, but at the end, on the bar menu view, i not see view->dvi ), i think to uninstall

Re: ftp://ftp.sylvan.com/pub/lyx/devel

On Mon, Nov 14, 2005 at 10:58:09AM +0100, Hartmut Haase wrote: > Hello Kayvan Sylvan, > could you just provide a tarred lyx-devel directory. A lyx-devel.tar.bz2 > would > only have ~6MB. Okay. Done. And automatically updated from this point on. It's at

Re: [patch] fix setDefaultParagraph in insettabular

Georg Baum wrote: > I see. I would also document the argument of forceDefaultParagraphs in > insetbase.h so that misunderstandings like in the current code do not > longer happen: > > /// if this inset has paragraphs should they be output all as default > /// paragraphs with "Standard" layout? >

Re: [patch] fix setDefaultParagraph in insettabular

> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Georg Baum wrote: >> I see. I would also document the argument of forceDefaultParagraphs >> in insetbase.h so that misunderstandings like in the current code >> do not longer happen: >> >> /// if this inset has

Re: [patch] fix setDefaultParagraph in insettabular

Jean-Marc Lasgouttes wrote: > And the parameter passed to the method seems bogus to me. It seems to > be always like > inset.forceDefaultParagraphs() > > The only case that is different is with insettabular, it seems. This > does not make sense... It makes sense in so far as the parameter is

Re: [patch] fix setDefaultParagraph in insettabular

Juergen Spitzmueller wrote: > Is it worth it to add the argument for documentation purposes? The argument is already there. Do you mean to name it? IMHO it is worth it. > Attached is a patch with some mor FIXME's and the proposed documentation > (without having added the argument). > > Would

[Patch in bugzilla] for 1966, and others

As it says. http://bugzilla.lyx.org/show_bug.cgi?id=1966 Also, Stephan's fix to 1656 was confirmed, and a fix to 822 is also in: http://bugzilla.lyx.org/show_bug.cgi?id=822 (and my 2015 fix is in Lars's queue...) Just for reference. - Martin signature.asc Description: This is a digitally

Re: lyx win1.3.6

[EMAIL PROTECTED] wrote: first i install software lyx, and run, but i had problem with view View→PDF or View--> PS, (view->dvi run) i search for resolver it i see http://wiki.lyx.org/Windows/LyX136 and old version lyx win page, but at the end, on the bar menu view, i not see view->dvi ), i

Re: [New patch] Re: Fix for bug 2015: font properties propagation in environments

Andre Poenitz <[EMAIL PROTECTED]> writes: | > ParagraphList::const_iterator it = | > find_if(pars_.begin(), pars_.end(), some_functor(par)); | | Why? It's obviously more code to type, to read, and not simpler to | understand. You obviously could write out the for loop but

Re: [New patch] Re: Fix for bug 2015: font properties propagation in environments

Andre Poenitz <[EMAIL PROTECTED]> writes: | + pit_type pit = 0; | + for ( ; pit < pars_.size() && _[pit] != ++pit) | + ; You know... terse does not mean easy to understand. -- Lgb

Re: Fix for bug 2015: font properties propagation in environments

Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Nov 09, 2005 at 10:21:19AM +0100, Georg Baum wrote: | > class ParAddressEqual : public std::unary_function { | > public: | > ParAddressEqual(Paragraph const * par) : par_(par) {} | > bool operator()(Paragraph

Re: [Patch in bugzilla] for 1966, and others

Martin Vermeer <[EMAIL PROTECTED]> writes: | (and my 2015 fix is in Lars's queue...) I have a queue? -- Lgb

Re: [patch] fix setDefaultParagraph in insettabular

Jean-Marc Lasgouttes wrote: > What about redefining as > > virtual bool forceDefaultParagraphs(idx_type cell =0) > > Paragraph::forceDefaultParagraph would pass 0 (or no value), the > others would use the cursor. > > Considering the low number of instance of this method, it seems both > easy and

Re: [patch] fix setDefaultParagraph in insettabular

Juergen Spitzmueller wrote: > Jean-Marc Lasgouttes wrote: >> The problem is probably (as in bugs 1952/53) that there is no way when >> the cursor is in a tabular (top.inset() is the insettabular) to access >> the insettext itself (the cell). InsetTabular suffers from some >> personality disorder:

Re: [patch] fix setDefaultParagraph in insettabular

Jean-Marc Lasgouttes wrote: > What about redefining as > > virtual bool forceDefaultParagraphs(idx_type cell =0) > > Paragraph::forceDefaultParagraph would pass 0 (or no value), the > others would use the cursor. Looks much nicer :-) I wonder if passing 0 from Paragraph::forceDefaultParagraphs()

Re: When will the 1.3.7 released

Luis Rivera wrote: > I think I have the squasher somewhere... let me see... do we have the > NewAPI.h patch somewhere in the cvs tree? Where should I look for to see > the existing patches? The NewAPI.h patch is already in the code base. However, from what I understand, it, or our use of it, is

Re: [Patch in bugzilla] for 1966, and others

On Mon, Nov 14, 2005 at 05:23:29PM +0200, Martin Vermeer wrote: > As it says. > > http://bugzilla.lyx.org/show_bug.cgi?id=1966 > > Also, Stephan's fix to 1656 was confirmed, and a fix to 822 is also in: > > http://bugzilla.lyx.org/show_bug.cgi?id=822 > > (and my 2015 fix is in Lars's

Re: [Patch in bugzilla] for 1966, and others

On Mon, Nov 14, 2005 at 11:04:36PM +0100, Helge Hafting wrote: > On Mon, Nov 14, 2005 at 05:23:29PM +0200, Martin Vermeer wrote: > > As it says. > > > > http://bugzilla.lyx.org/show_bug.cgi?id=1966 > > > > Also, Stephan's fix to 1656 was confirmed, and a fix to 822 is also in: > > > >

Re: [patch] fix setDefaultParagraph in insettabular

> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Looks much nicer :-) Indeed. If it works to your liking, please apply it. Juergen> I wonder if passing 0 from Juergen> Paragraph::forceDefaultParagraphs() is always correct, Juergen> though. I think it is equivalent